Purpose of Patch 1.4.2

https://discord.com/channels/288415776782942210/288417145493258240/1223814148610068520

On this user's 1440p panel with display scaling, game did not correctly set the render region for some strange reason. Both with and without dxvk.

For now we force a window resize to correct it, but in the long run, we should do a more proper patch and figure out what the game does during window resize, and replicate that.

Is it possible to configure anti-aliasing with this mod?

I am dumbfounded, speechless and in the last two days, cannot come to a conclusion.

There appears to be a possibility of either a very deeply rooted runtime bug in the .NET Core runtime involving managed -> unmanaged code transition that is exposed hooking certain functions or heap corruption when hooking some functions.

Specifically compiling the Hooks Project of Graphics Essentials in Release Mode causes the following side effects:

Initial Problems

• Stage Injector
  NullReferenceException in the following hook to get end position, despite the object nor delegate being null which could be verified by debugging/printing the line before:
  https://github.com/Sewer56/Heroes.StageInjector.ReloadedII/blob/228799a995ff047100955af9939b351469d71f2e/sonicheroes.utils.stageinjector/StageCollection.cs#L115
  

• Controller Hook
  https://github.com/Sewer56/Heroes.Controller.Hook.ReloadedII/blob/bc40b3f0c8ffb27d47c83113a706d91f0268007e/Heroes.Controller.Hook/ReloadedController.cs#L61

Passing the interface to constructor of ExtendedController caused an access violation... for passing an object on the stack.

This error was only triggered in Special Stages, whereby the game would crash when the emerald indicator is drawn.

Fixed?

These initial problems may have been fixed by adding the ESI parameter into the following function used to draw the emerald indicator:

Which the previous lack of may have possibly caused memory corruption.

Persistent Issues

• Special Stage Emerald Indicator Draw Crash

Directly related to the heading above, and the same function.
Compiling the library as Release still causes the game to freeze when the emerald indicator is drawn. The game works for another 2-3 frames, until it freezes without crashing.

According to the Crash Dumps %localappdata%\Crash Dumps, the error is 0xC0000409 (Stack Overflow/Stack Buffer overrun) however debugging the process I could not find any evidence of a stack overflow.

This might be a case of perhaps an expected register to be callee preserved used later in code, I have yet unfortunately not figured out.

Help would be appreciated.

• The vertical FOV expansion was meant to lock the horizontal fov to 16:9 while extending the vertical, not zoom it in.
• Certain orthographic elements such as the "Now Loading" text render using the main resolution on it's code execution before they're resized into 4:3 canvas making it appear incorrect on a blank screen.
• Powerup icons aren't positioned correctly on vertical display.
• The dot in the 2P hud is scaled incorrectly and the bar is supposed to be above the formation maestro.
• Shadows shouldn't be scaled by the screen aspect ratio.