Comments (4)
josephzhang8
commented on June 30, 2024
Thank you Claire and I agree with you. Aron/Xavier: can u plz take a look? Thanks.
…-Joseph
Joseph Zhang
Office: (804) 684 7466
Web: schism.wiki
From: Claire Trenham ***@***.***
Sent: Sunday, July 18, 2021 9:47 PM
To: schism-dev/schism ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [schism-dev/schism] Failure to define bounds files causes segfault? (#36)
[EXTERNAL to VIMS received message]
This may well be indicative of a problem on our end, however I believe that we should be seeing an error not a segfault, which is presumably not desired code behaviour!
In WWMIII wwm_bdcons.F90, SUBROUTINE COMPUTE_IFILE_IT(IFILE, IT)
contains the following line
IF (IT .GT. NDT_BND_FILE(IFILE)) THEN
However we have a situation where NDT_BND_FILE is not defined (doubtless for another reason that we need to get to the bottom of!), and this produces a segfault. The following additional check for boundary files resolves the segfault though it may be a place where an error needs to be raised, so I won't open a pull request as I think this needs consideration from the developers as to what is expected behaviour here?
IF (NUM_NETCDF_FILES_BND .GT. 0) THEN
IF (IT .GT. NDT_BND_FILE(IFILE)) THEN
IFILE = IFILE + 1
IT = 1
ENDIF
ENDIF
Thanks for your consideration!
-Claire
-
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism%2Fissues%2F36&data=04%7C01%7Cyjzhang%40vims.edu%7Cca885ed01a0b46b2e4bf08d94a570eb0%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637622560040442018%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2Fd1cJMpEHLyTTzvLlM1hFTwTKXVQ6SAwDrV3A5NLz8I%3D&reserved=0>, or unsubscribe<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZZHOSFX4OIRDYTU6CTTYN7YBANCNFSM5ASXIV2Q&data=04%7C01%7Cyjzhang%40vims.edu%7Cca885ed01a0b46b2e4bf08d94a570eb0%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637622560040451974%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=z88ivqDMRUsBd2DgHNtLSE%2Fhw6t4z372U7ZghmzT8yM%3D&reserved=0>.
from schism.
huyquangtranaus
commented on June 30, 2024
We need to tag @aronroland in as he is currently not subscribing the github repo :)
from schism.
aronroland
commented on June 30, 2024
hi all, thanks for the nice digging ... can i have the case?
from schism.
hot007
commented on June 30, 2024
Oh, goodness me, you asked for a case a year ago and I didn't notice. Sincere apologies! I have asked my colleague who hit the snag to reply to this ticket if possible!
Our problem was sort of a user error - we were trying to switch from bulk to spectral boundary forcing, and from what we could see we didn't need to supply bounds data when using spectral forcing, however we were hitting the above segfault. I think there were probably forum posts or emails on the subject at the time, and it seemed no one else was having the problem, so doubtless we had something wrong, just that we managed to trigger this Segfault which is... not ideal behaviour :)
Our solution at the time was to move from the v5.8.0 tag to the dev branch - which doesn't affect this WWM file at all, it was something in the upstream file handling I guess, however if you want to iron out undesirable segfaults, well... there's one!
If not, well, it's a corner case in an older version so maybe it doesn't matter now.
from schism.
Related Issues (20)
- Error copying Fortran module "include/schism_glbl.mod" HOT 23
- Incorrect Pi value in read_output10_xyz.f90 HOT 2
- Help SCHISM-WWM III HOT 1
- Update ugrid conventions HOT 13
- Help - pschism seems to not able to find the hdf5 libraries and netcdf-c libraries. HOT 3
- General Info: how to run Pschism on AWS pcluster with Spack HOT 1
- Format overflow in staout HOT 1
- Issue Running with Sflux generated from HAFS HOT 10
- No rule to make target 'pschism' / BLD_STANDALONE HOT 5
- Exit code is zero even when simulator fails HOT 3
- Compile GOTM 3.2.5 HOT 2
- Updating variable names in hotstart.nc HOT 6
- latest version in git wants deprecated NetCDF-Fotran build (with f90) HOT 7
- set_mask error during compilation of SCHISM-FABMv2-(ECOSMO) HOT 6
- FABM/SCHISM: UNFULFILLED DEPENDENCY: downwelling_photosynthetic_radiative_flux HOT 6
- Error when run a 2D model with tidal elevation and velocity ( 23: ABORT: STEP: wetted cross section length on open bnd <=0; boundary ndx= 1 , length= 0.000000000000000E+000) HOT 3
- Support for the Intel 2024+ compilers
- Julian Date Calculation Imprecision Leads to Issues with Time Indices Slicing in the sflux_air_1.0001.nc File HOT 3
- Missing inverse barometer effect? HOT 3
- Initial timesteps results for a hotstart run HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from schism.