set_mask error during compilation of SCHISM-FABMv2-(ECOSMO) about schism HOT 6 CLOSED

Thanks for reporting this. I have not been able to reproduce the problem, but I'll try with the makefile you provided.

In general, I found the use of set_mask much more consistent than internal hacks employing constructs like foreach value in array[i,k,n] if value == NaN then cycle. Using a 2d mask makes this much more efficient.

from schism.

I also noticed that the fabm_driver.h has not been merged upstream yet.

So to define the mask, you need to add the file:

echo << EOT >  $FABM_BASE/src/drivers/schism/fabm_driver.h
! Copyright 2017 Helmholtz-Zentrum Geesthacht
! Licensed under the Apache License, Version 2.0
!  (http://www.apache.org/licenses/LICENSE-2.0)
! Author(s): Richard Hofmeister

#define _FABM_DIMENSION_COUNT_ 2
#define _FABM_DEPTH_DIMENSION_INDEX_ 1
#define _FABM_VECTORIZED_DIMENSION_INDEX_ 1

#define _FABM_VERTICAL_BOTTOM_TO_SURFACE_
#define _FABM_BOTTOM_INDEX_ -1

#define _FABM_MASK_TYPE_ integer
#define _FABM_MASKED_VALUE_ 1

#include "fabm.h"

EOT

from schism.

So this problem might be related to the missing fabm_driver.h. Please report if adding the driver fixes the problem. I will then merge it upstream.

from schism.

Thanks! After adding these lines

#define FABM_MASK_TYPE integer
#define FABM_MASKED_VALUE 1

to fabm_driver.h (of FABM) compilation works.

from schism.

Thanks for reporting, closing this as fixed

from schism.

I filed a PR on official fabm repo to include these lines upstream fabm-model/fabm#64

from schism.