Description

Right now the screen is completely blank whenever there are no orders, and still looks empty when a user has some orders.

Relevant files

• orders.dart

Screenshot

@ SWoC mentors, please drop your GitHub username below -

• I'll add you as a collaborator
• The participants will know who the mentors are

Please don't merge any pull requests, I'd like to do that on my own. You can review and approve a pull request (and help the participants in every other possible way).

Description

There are a lot of unnecessary imports in almost all of the files, they should be removed.

With flutter, we can build apps for android, iOS, and web from a single code base. But, right now the project is not configured for web.

I think adding web support would be good for desktop users.

Description

Right now the file names and the code is not linted properly (or does not follow the convention naming etc.). Lint all the files.

Multiple contributors

This issue can have multiple PRs but each PR should lint at least 3 files.

Description

Add a workflow that checks the linting of the codebase on every pull_request, push and schedule.

References

• https://github.com/smaranjitghose/DocLense/blob/main/.github/workflows/ci.yml

Screenshot

Description

Right now the screen looks very dull. I'd like to keep the overall structure of the screen and the cards, but the rest of everything can be updated.

As the package name of your android app in the firebase console is not editable, I think the best course of action would be to delete the current app from the console and add a new android app with the correct package name, then download the auto-generated google-services.json and replace it with the current one.

After some research, I found this, here an employee of firebase is also suggesting the same. Also, if we scroll a bit, we can find users who had problems after editing google-service.json manually.

Originally posted by @letsintegreat in #114 (comment)

Description

Make the screen dynamic.

Relevant files

• YourOrders.dart

Screenshot

Description

Add "Program" section in the PR template.

Relevant files

• https://github.com/Saransh-cpp/BookRentApp-Chapter3/blob/master/.github/PULL_REQUEST_TEMPLATE.md

Description

We have a Contact us section but it doesn't do anything yet. Adding some non-void functionality to this section will enhance the app.

Relevant files

lib/Screens/Contact.dart

Screenshot

NotApplicable

References

NotApplicable

Description

I have upgraded my flutter version for my android studio few days ago now when I'm trying to run the code of this app then I'm getting a warning which suggest me to migrate the project to it's updated flutter version.

Relevant files

MainActivity.java/kt
android/app/src/main/AndroidManifest.xml
Drawable
styles.xml

Screenshot

References

more_info

Description

======== Exception caught by widgets library =======================================================
The following assertion was thrown while applying parent data.:
Incorrect use of ParentDataWidget.

The ParentDataWidget Flexible(flex: 2) wants to apply ParentData of type FlexParentData to a RenderObject, which has been set up to accept ParentData of incompatible type ParentData.

Usually, this means that the Flexible widget has the wrong ancestor RenderObjectWidget. Typically, Flexible widgets are placed directly inside Flex widgets.
The offending Flexible is currently placed inside a RepaintBoundary widget.

The ownership chain for the RenderObject that received the incompatible parent data was:
  Column ← Flexible ← RepaintBoundary ← IndexedSemantics ← NotificationListener<KeepAliveNotification> ← KeepAlive ← AutomaticKeepAlive ← KeyedSubtree ← SliverList ← MediaQuery ← ⋯
When the exception was thrown, this was the stack: 
#0      RenderObjectElement._updateParentData.<anonymous closure> (package:flutter/src/widgets/framework.dart:5761:11)
#1      RenderObjectElement._updateParentData (package:flutter/src/widgets/framework.dart:5778:6)
#2      RenderObjectElement.attachRenderObject (package:flutter/src/widgets/framework.dart:5800:7)
#3      RenderObjectElement.mount (package:flutter/src/widgets/framework.dart:5470:5)
#4      MultiChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:6268:11)
...     Normal element mounting (39 frames)
#43     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3631:14)
#44     Element.updateChild (package:flutter/src/widgets/framework.dart:3383:18)
#45     SliverMultiBoxAdaptorElement.updateChild (package:flutter/src/widgets/sliver.dart:1243:37)
#46     SliverMultiBoxAdaptorElement.createChild.<anonymous closure> (package:flutter/src/widgets/sliver.dart:1228:20)
#47     BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2531:19)
#48     SliverMultiBoxAdaptorElement.createChild (package:flutter/src/widgets/sliver.dart:1221:12)
#49     RenderSliverMultiBoxAdaptor._createOrObtainChild.<anonymous closure> (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:349:23)
#50     RenderObject.invokeLayoutCallback.<anonymous closure> (package:flutter/src/rendering/object.dart:1962:59)
#51     PipelineOwner._enableMutationsToDirtySubtrees (package:flutter/src/rendering/object.dart:910:15)
#52     RenderObject.invokeLayoutCallback (package:flutter/src/rendering/object.dart:1962:14)
#53     RenderSliverMultiBoxAdaptor._createOrObtainChild (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:338:5)
#54     RenderSliverMultiBoxAdaptor.insertAndLayoutChild (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:484:5)
#55     RenderSliverList.performLayout.advance (package:flutter/src/rendering/sliver_list.dart:239:19)
#56     RenderSliverList.performLayout (package:flutter/src/rendering/sliver_list.dart:281:12)
#57     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#58     RenderSliverEdgeInsetsPadding.performLayout (package:flutter/src/rendering/sliver_padding.dart:137:12)
#59     RenderSliverPadding.performLayout (package:flutter/src/rendering/sliver_padding.dart:371:11)
#60     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#61     RenderViewportBase.layoutChildSequence (package:flutter/src/rendering/viewport.dart:510:13)
#62     RenderViewport._attemptLayout (package:flutter/src/rendering/viewport.dart:1580:12)
#63     RenderViewport.performLayout (package:flutter/src/rendering/viewport.dart:1489:20)
#64     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#65     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#66     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#67     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#68     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#69     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#70     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#71     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#72     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#73     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#74     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#75     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#76     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#77     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#78     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#79     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#80     RenderCustomPaint.performLayout (package:flutter/src/rendering/custom_paint.dart:545:11)
#81     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#82     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#83     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#84     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#85     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#86     MultiChildLayoutDelegate.layoutChild (package:flutter/src/rendering/custom_layout.dart:171:12)
#87     _ScaffoldLayout.performLayout (package:flutter/src/material/scaffold.dart:1005:7)
#88     MultiChildLayoutDelegate._callPerformLayout (package:flutter/src/rendering/custom_layout.dart:240:7)
#89     RenderCustomMultiChildLayoutBox.performLayout (package:flutter/src/rendering/custom_layout.dart:403:14)
#90     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#91     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#92     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#93     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#94     _RenderCustomClip.performLayout (package:flutter/src/rendering/proxy_box.dart:1376:11)
#95     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#96     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#97     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#98     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#99     RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#100    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#101    RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#102    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#103    RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#104    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#105    RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#106    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#107    RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#108    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#109    RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#110    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#111    RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#112    RenderOffstage.performLayout (package:flutter/src/rendering/proxy_box.dart:3426:14)
#113    RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#114    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#115    RenderObject.layout (package:flutter/src/rendering/object.dart:1852:7)
#116    _RenderTheatre.performLayout (package:flutter/src/widgets/overlay.dart:751:15)
#117    RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:1707:7)
#118    PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:879:18)
#119    RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:497:19)
#120    WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:883:13)
#121    RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:363:5)
#122    SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1145:15)
#123    SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1082:9)
#124    SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:996:5)
#128    _invoke (dart:ui/hooks.dart:150:10)
#129    PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:270:5)
#130    _drawFrame (dart:ui/hooks.dart:114:31)
(elided 3 frames from dart:async)
====================================================================================================

Relevant files

Contact.dart

Description

The app is behaving very weirdly in different situations. One that I encountered -

1. Add a book to the cart (notice how the cart icon disappears)
2. Go to the cart screen (notice how it loads for a long time) and place an order/delete the items
3. Go back and open any books (It won't open)
4. The app is stuck in a weird place where nothing is working

The bug is somewhere between the commit 3a3c330 and the latest commit for sure.

Description

In this app we have implemented firebase_admob package for showing mobile ads on myCart screen, which is deprecated now, instead we should use google_mobile_ads package.

Relevant files

lib/Screens/YourOrders.dart

Screenshot

References

reference

Description

I think the Google Sign In has been implemented but has not been added to the frontend. Add it to the Register and Log In screen with all the necessary data. Adding this as hard as this will require passing the data in between files or initializing dummy data.

Relevant files

• https://github.com/Saransh-cpp/BookRentApp-Chapter3/blob/master/lib/Utility/auth.dart
• https://github.com/Saransh-cpp/BookRentApp-Chapter3/blob/master/lib/model/user.dart
• https://github.com/Saransh-cpp/BookRentApp-Chapter3/blob/master/lib/Screens/Register.dart
• https://github.com/Saransh-cpp/BookRentApp-Chapter3/blob/master/lib/Screens/LoginPage.dart

Description

Right now the register screen looks really bad (well, the whole app looks really bad), for starters, we can try making the UI on a single screen a bit uniform.

• Add white background in all the fields
• Create a similar eye icon in confirm password field

Relevant screens

Register.dart

Screenshot

Note - You might also would need to refactor the code by creating a new widget (hence I am keeping this a moderate level issue)

Description

The shopping Cart screen looks very dull and the checkout button does not match the aesthetic of the app.
Also, the Your cart is empty pop-up looks plain

Screenshot

For many of us we can't see the content of HomeScreen due to error with SingleChildScrollView (because it is encapsulating AppBar, Drawer, Body etc.).
Though the app is running even with this issue.
As a result we may see some error like this:

Description

The drawer right now looks ugly, create a new design and implement it in the app. You might also need to create a new widget for the tiles and refactor some code (hence putting this issue as a hard one).

Screenshot

Description

Add a splash screen in the application with the app's logo.

Resources

https://whiteviolin.medium.com/creating-splash-screens-in-flutter-apps-8a284d86aa1b

Logo

2. Pull the latest code in.

   # make sure you are on the main branch
   git pull upstream main
   

The branch name in upstream is master, not main. It needs to be fixed.

Description

The screen looks very bland. Some suggestions -

• Update the button
• Show something if the cart is empty
• Update the app bar
• Change the background color
• Check how the item cards are displayed
• Check how the alert message on ordering something is displayed
• Background color

You might also face some issues with the written code, hence, I am putting this as a moderate level issue.

Relevant files

• https://github.com/Saransh-cpp/BookRentApp-Chapter3/blob/master/lib/Screens/YourOrders.dart

Reference

Description

Some widgets on the home screen overflow by some pixels. This occurs on 1080p and 720p screen resolution devices and does not occur on 1440p devices (tested on only these resolutions).

Relevant files

lib/Screens/Home.dart

Screenshot

Description

On signing in with incorrect credentials. the app does not display a snackbar about the failed sign in.
On signing out, the login screen is not pushed to the screen, instead it just stays signed in until we restart the app.

Relevant files

lib/Screens/LoginPage.dart
lib/Screens/Home.dart
Could be many others

Description

Revamp the screen, the UI is completely up to you (tho it will require my approval). This would also require some refactoring and some fixing with the updation logic (might turn this into a bonus issue).

Relevant files

• Profile.dart

Screenshot

Description

The "Register" button is redundant in the Sign In screen and should be removed.
Edit: Also make the screen consistent with the Register screen (#8).

Relevant file

LoginPage.dart

Screenshot

We cannot build and run the project for android using the latest SDK as it uses old versions for some dependencies, e.g. win32.

Screenshot of the error message:

Description

I don't have the resources to run the app in iOS but if someone can then it would be nice to check if everything is working smoothly, and if not, feel free to open up new issues:)

Description

We don't have any tests right now, but we can build the apk to check if the app is doing well or not. Add another step in the workflow to build the apk.

Relevant files

• https://github.com/Saransh-cpp/BookRentApp-Chapter3/blob/master/.github/workflows/Test.push.yml

Screenshot

Please attach screenshots for the same, if applicable

References

• https://github.com/subosito/flutter-action

steps:
- uses: actions/checkout@v2
- uses: actions/setup-java@v2
  with:
    distribution: 'zulu'
    java-version: '11'
- uses: subosito/flutter-action@v1
  with:
    channel: 'stable' # or: 'beta', 'dev' or 'master'
- run: flutter pub get
- run: flutter test
- run: flutter build apk

Description

Create a workflow to label issues with the tag CodePeak, and SWoC.

References

• https://docs.github.com/en/actions/managing-issues-and-pull-requests/adding-labels-to-issues

Description

Create the About screen from scratch -

• Come up with a short description of the app.
• Make the screen visually appealing (you can use undraw's illustrations)
• Make an Author section and add me (GitHub profile).
• Make a Contributors section, and show all the contributors in a grid view using GitHub's API.

Relevant file

• AboutUs.dart

Reference

Description

The screen where a single product is displayed (a book) looks ugly, I'll see if I can update the data, but update the UI and make it consistent throughout the screen. You might need to deep dive into the code and make sure that nothing breaks, hence, putting this as a moderate issue.

Relevant file

• product_details.dart

Screenshot

Description

The PR template has a lot of unnecessary line breaks (<br>). Remove all of them.

Relevant file

• https://github.com/Saransh-cpp/BookRentApp-Chapter3/blob/master/.github/PULL_REQUEST_TEMPLATE.md

Description

There are a lot of tools available on the internet that integrates with our app and let a user report bug/glitch with extra information. Look out for such SDKs and integrate with the app.

Screenshot

References

• https://github.com/smaranjitghose/DocLense

Throughout the code we can see many deprecated widget (e.g. RaisedButton, showSnackBar etc .) which may cause unexpected behavior in future, so this syntax need to be replaced with their latest alternative.

Description

Right now the screen is completely blank whenever there are no favorites, and still looks empty when a user has favorite books.

Relevant files

• Favourites.dart

Screenshot

Description

Add a compiled image of all the screens in the README file.

References

• https://github.com/smaranjitghose/DocLense#app-screens
• https://app-mockup.com/

Description

It would be nice to have an all contributors section in the README file.

References

Preference 1 - https://github.com/pybamm-team/PyBaMM#-contributors
Preference 2 - https://github.com/smaranjitghose/DocLense#our-valuable-contributors-

Let me know if I have to enable something in order to implement this!

I will add you all to the Firebase console as a viewer, so that you can see all the stored dummy data.

Description

2 badges should be added below the Chapter 3 logo, and the existing badge should also be moved there.

Two badges -

Relevant files

• https://github.com/Saransh-cpp/BookRentApp-Chapter3/blob/master/README.md

Screenshot

Please attach screenshots for the same, if applicable

References

• https://github.com/pybamm-team/BattBot#readme

Description

The README right now looks ugly. Things to do -

1. Centre align all the images.
2. There are some numbering issues, fix them.
3. Fix spelling mistakes.
4. Make sure all the links work.
5. Add some emojis in the headings.
6. Also the logo looks weird, crop the logo in such a way that it take all the width.
   The file -
   

References

1. https://github.com/pybamm-team/PyBaMM#readme
2. https://github.com/smaranjitghose/DocLense#readme

The app lets us login with invalid email and password. We can put any non-empty email like '123' and any password with more than 6 characters and sign in to the app. But the home screen and cart screen will display an error as shown ->

Description

Create an issue template. The template would look something like this -

Description

Relevant files

Screenshot

References

Description

The register screen throws an error anytime it is opened.

Relevant files

lib/Screens/Register.dart

Screenshot

Description

The home screen and login screen has overflowing widgets in landscape mode. Other screens may be affected too.
Login screen only has overflow when typing the email and password.

Relevant files

lib/Screens/Home.dart
lib/Screens/LoginPage.dart

Screenshot

Should look something like -

Program -
Fixes

Description

Type of change

Screenshot

Checklist

• The app builds properly
• Code is commented in difficult to understand areas
• Code is formatted well

Description

I think Wrapper.dart and database.dart are redundant. Remove them and make sure that it doesn't break anything.

The app is not getting installed because of some error:

To reproduce the error, try to run the app on the latest version of android. (API 31)