Revamp the single product screen about bookrentapp-chapter3 HOT 20 OPEN

@ManavSarkar First you have to Fork this Repo using the Fork button which is on the top-right side, then clone the forked repo onto your system, make the desired changes, then create a new branch for your changes, push that branch onto your repo and then open a Pull Request in the main Repository.

from bookrentapp-chapter3.

Hi, Can I work on this?
I am Manav Sarkar

from bookrentapp-chapter3.

I have some better designs in my mind for this page

from bookrentapp-chapter3.

Yes, go ahead!

from bookrentapp-chapter3.

@ManavSarkar, any updates?

from bookrentapp-chapter3.

Can I take it?

from bookrentapp-chapter3.

Can I take it?

I am already working on it

from bookrentapp-chapter3.

@ManavSarkar, any updates?

Yes sir, almost done and within tomorrow I will submit.
The reason for my late contribution is my final sem exams. But I will do submit by tomorrow.
Thank you

from bookrentapp-chapter3.

@Saransh-cpp please can you guide where to publish the branch, in upstream or in origin
Getting error

from bookrentapp-chapter3.

Did you clone my repository or the forked repository?

from bookrentapp-chapter3.

Did you clone my repository or the forked repository?

No I just cloned the repository.i was working on the issue 22 branch

from bookrentapp-chapter3.

Did you clone my repository or the forked repository?

No I just cloned the repository.i was working on the issue 22 branch

Have I made any mistake?
Please guide as this is my first time open source contribution.

from bookrentapp-chapter3.

@ManavSarkar, a workaround for your situation now -

git remote set-url origin your-forked-repo-url
git remote add upstream my-repo-url

Then you can push to origin

from bookrentapp-chapter3.

Can I start from beginning by forking the repository and then paste the product page code. But it will have only single commit. Will that be fine?

from bookrentapp-chapter3.

@Saransh-cpp

from bookrentapp-chapter3.

Can I start from beginning by forking the repository and then paste the product page code. But it will have only single commit. Will that be fine?

Yes, no issues!

from bookrentapp-chapter3.

@Saransh-cpp Please confirm whether the UI is looking good or not.

from bookrentapp-chapter3.

@all-contributors please add @arnav1776 for mentoring

from bookrentapp-chapter3.

@Saransh-cpp

I've put up a pull request to add @arnav1776! 🎉

from bookrentapp-chapter3.

@Saransh-cpp Please confirm whether the UI is looking good or not. ![71](https://user-

Yes, looks awesome!

from bookrentapp-chapter3.