sandstorm-io / blackrock Goto Github PK

View Code? Open in Web Editor NEW

72.0 72.0 14.0 826 KB

Cluster management

License: Apache License 2.0

C++ 87.65% Cap'n Proto 10.21% Makefile 0.70% Shell 1.45%

blackrock's People

Contributors

Stargazers

Watchers

Forkers

kustomzone maniacs-ops zeigerpuppy fgiorlando mark19891107 pdis thomasaquinas monotonemonk wgbdev handsofthecommunity dioptre unimol

blackrock's Issues

Oasis: Users can get stuck in demo if they already have an account but start a new demo

Create an Oasis account.
Log out.
Start a demo.
Try to log in with your existing Oasis account.

This won't work, because you can't merge a demo account with an existing account. Unfortunately, there are two big usability problems here:

The user has no way to end the demo, in order to allow them to log in with their account.
In the case of OAuth login, no error message is displayed. The user is simply redirected back to the home page, still in demo mode. This is a known problem with our OAuth login flow -- errors are not displayed anywhere. See e.g. sandstorm-io/sandstorm#1798, sandstorm-io/sandstorm#1755, etc.

Should mention referral program on account settings page

Steps to reproduce:

Visit a blackrock-enabled Sandstorm
Visit /account

Expected behavior:

See some info about the referral program, even if you haven't managed to refer anyone

Actual behavior:

No info about referral program

cc: @neynah who mentioned this recently

Grain Size of 4.10kB - but no grains...

Payments are broken by identity refactor

Specifically Meteor.user().profile.email is broken (see

blackrock/shell/packages/blackrock-payments/billingPrompt.js

Line 200 in b5f8b43

email: Meteor.user().profile.email

Implement zero-downtime updates for Oasis

Currently, updating Oasis requires ~10 minutes of downtime and happens approximately weekly. Eventually, we will implement zero-downtime rolling updates. For now, downtime alerts may link to this issue.

To find out what's changing, compare the Sandstorm changelog with the current Oasis version listed on the Oasis about page.

OpenStack ComputeDriver

I think it would be great to be able to integrate this with OpenStack.

SandstormApi.save() doesn't work

The problem is:

The supervisor implements save() to call the capability's SystemPersistent.save().
It passes in an ApiTokenOwner of type grain with the grain ID set.
It gets the grain ID from the supervisor's command-line.
Originally, the grain ID was passed on the command line for the sole purpose of determining the path to the grain's data.
On Blackrock, the grain data is at a static path that doesn't include the grain ID.
So on Blackrock the grain ID passed to the supervisor's command-line is "grainid-not-applicable".
So, save() ends up requesting that the saved capability be sealed for the grain with ID grainid-not-applicable.
Hence, it cannot be restore()ed later.
Dang.

FilesystemStorage hits concurrent assignment

I left a tab with Oasis open, with a single Wekan grain open, and didn't look at it for a while. I suspend/resumed my laptop, biked home, changed networks, and when I looked back at the tab in question, I see this exception:

Error: Error: remote exception: remote exception: remote exception: remote exception: remote exception: Assignable modified concurrently
C++ location:(javascript):??
type: disconnected

A little digging suggests this is from https://github.com/sandstorm-io/blackrock/blob/master/src/blackrock/fs-storage.c%2B%2B#L1559..L1575 :

      if (expectedVersion > 0) {
        if (object.version != expectedVersion) {
          return KJ_EXCEPTION(DISCONNECTED, "Assignable modified concurrently");
        }
        ++expectedVersion;
      }

Reduce journal size

We can probably get a way with creating small journals for our ext4 images, which might make users happier as there isn't a weird hidden storage cost while the grain is running.

Oasis: Update user's storage from back-end more often

Under the old UI, the storage usage number above the grain list updated more proactively than it does under the new UI. I think I had designed it to query for an update every time the user visited the grain list. (The storage usage number stored in Mongo can be stale -- the backend has the right number, but does not publish it reactively, so it needs to be queried from time to time.)

Quota weirdness on oasis

So, looking at my Oasis account right now, the grain page tells me that my quota usage is:

0 of 100 grains
-2.19e+7B of 1.20GB used

Looks like floating point weirdness. Screenshot:

(I noticed this having just deleted a Piwik grain I had there, which I hadn't really been using).

fs-storage-test.c++ failure

I'm having trouble reproducing this right now, but earlier today I was repeatedly hitting this test failure:

blackrock/fs-storage.c++:2123: failed: expected journal.openObject(id, xattr) != nullptr; object not found
stack: 0x4a105d 0x4400ab 0x440109 0x4e9d8d 0x495022 0x4e95a0 0x4e6410 0x4eb1f0 0x4ea590 0x4ec380 0x488d70 0x48ec8c 0x47e425 0x4d2570
[ FAIL ] fs-storage-test.c++:99: basic assignables
[ TEST ] fs-storage-test.c++:158: use after reload
blackrock/fs-storage-test.c++:164: failed: expected value.getText() == "bar"
stack: 0x4904f5 0x47c70a 0x4d2570 0x49b78a 0x4d1cf4 0x4d1aad 0x4c810f 0x49b78a 0x4c632c 0x4d0e12 0x7f8b12cb3a40 0x4079a9
:0: failed: Called null capability.
stack: 0x488d70 0x48ec8c 0x47c805 0x4d2570
[ FAIL ] fs-storage-test.c++:158: use after reload
[ TEST ] fs-storage-test.c++:185: delete some children
blackrock/fs-storage-test.c++:194: failed: expected sandstorm::listDirectoryFd(main).size() == 4
stack: 0x48bcf5 0x47a423 0x4d2570 0x49b78a 0x4d1cf4 0x4d1aad 0x4c810f 0x49b78a 0x4c632c 0x4d0e12 0x7f8b12cb3a40 0x4079a9
blackrock/fs-storage-test.c++:207: failed: expected size == 4096 * 2; size = 4096
stack: 0x48f7bf 0x47ab74 0x4d2570 0x49b78a 0x4d1cf4 0x4d1aad 0x4c810f 0x49b78a 0x4c632c 0x4d0e12 0x7f8b12cb3a40 0x4079a9
blackrock/fs-storage-test.c++:216: failed: expected sandstorm::listDirectoryFd(main).size() == 2
stack: 0x48bcf5 0x47adb2 0x4d2570 0x49b78a 0x4d1cf4 0x4d1aad 0x4c810f 0x49b78a 0x4c632c 0x4d0e12 0x7f8b12cb3a40 0x4079a9
:0: failed: Called null capability.
stack: 0x487db0 0x48f0fc 0x47b0e5 0x4d2570
[ FAIL ] fs-storage-test.c++:185: delete some children
[ TEST ] fs-storage-test.c++:242: delete volume child while still writing
blackrock/fs-storage-test.c++:251: failed: expected sandstorm::listDirectoryFd(main).size() == 2
stack: 0x48bcf5 0x4772b3 0x4d2570 0x49b78a 0x4d1cf4 0x4d1aad 0x4c810f 0x49b78a 0x4c632c 0x4d0e12 0x7f8b12cb3a40 0x4079a9
blackrock/fs-storage-test.c++:280: failed: expected size == 4096 * 2; size = 4096
stack: 0x48f7bf 0x478454 0x4d2570 0x49b78a 0x4d1cf4 0x4d1aad 0x4c810f 0x49b78a 0x4c632c 0x4d0e12 0x7f8b12cb3a40 0x4079a9
blackrock/fs-storage-test.c++:287: failed: expected sandstorm::listDirectoryFd(main).size() == 2
stack: 0x48bcf5 0x4785aa 0x4d2570 0x49b78a 0x4d1cf4 0x4d1aad 0x4c810f 0x49b78a 0x4c632c 0x4d0e12 0x7f8b12cb3a40 0x4079a9
blackrock/fs-storage-test.c++:301: failed: expected root.getStorageUsageRequest().send().wait(env.io.waitScope).getTotalBytes() == 4096*2
stack: 0x48fd65 0x4789ab 0x4d2570 0x49b78a 0x4d1cf4 0x4d1aad 0x4c810f 0x49b78a 0x4c632c 0x4d0e12 0x7f8b12cb3a40 0x4079a9

Blackrock bundle fails to build after changelog added to sandstorm bundle

make bundle
...
==== convert icons/share.svg ====
==== convert icons/close.svg ====
==== convert icons/menu.svg ====
make[1]: *** No rule to make target 'CHANGELOG.md', needed by 'shell/client/changelog.html'.  Stop.
make[1]: Leaving directory '/home/zarvox/git/blackrock'
Makefile:30: recipe for target 'bundle' failed
make: *** [bundle] Error 2