samuell1 / revisions-plugin Goto Github PK

Version: ocms v3

Cannot use object of type Closure as array
~/plugins/samuell/revisions/formwidgets/RevisionHistory.php line 251

        $optionConfig = $field->config['options'];

        foreach ($oldValue as $item) {
            $old .= isset($optionConfig[$item]) ? $optionConfig[$item] . ' • ' : '';
        }

$field->config['options'] is a closure now. This closure is also present for repeaters. Therefore repeaters also pass this check

            if (isset($field->config['options'])) {
                return $this->getOptionsDiff($field, $oldValue, $newValue);
            }

Which results in method getFIELDNAMEOptions() not exists.

My current hotfixes in RevisionHistory:

    private function getDiff($fieldName, $oldValue, $newValue)
    {
        $fields = $this->parentForm->getFields();

        if (array_key_exists($fieldName, $fields)) {
            ...

            if (isset($field->config['widget']) && $field->config['widget'] === 'repeater') {
                return Diff::htmlDiff(e($oldValue), e($newValue));
            }

            if (isset($field->config['options'])) {
                return $this->getOptionsDiff($field, $oldValue, $newValue);
            }
        }

        return Diff::htmlDiff(e($oldValue), e($newValue));
    }

    private function getOptionsDiff($field, $oldValue, $newValue)
    {
        $optionConfig = $field->config['options']();
        ...
     }

I asked Daftspunky, if the options closure is intended, waiting for reply:
https://octobercms.slack.com/archives/C09864473/p1655826963967629

When hitting delete on a grouped revision, only one of them actually gets deleted.
I would expect that all revisions are deleted.

cc @evwerkz

Hi! I got error :(

Problem in view file _revisionhistory.htm at string 44:

<?= $record->created_at->locale(Lang::getLocale())->isoFormat('LLL') ?>

Hello,

When you open a revision popup, checkbox are not visibles (october 2)

Best regards,

Hello,

I'm testing your module, you did a great job to provide the missing UI to the revisionable octobercms trait.

However, I got a bug after applying it to one of my model :

SQLSTATE[42000]: Syntax error or access violation: 1055 'bdd.system_revisions.id' isn't in GROUP BY (SQL: select * from system_revisions where system_revisions.revisionable_id = 21 and system_revisions.revisionable_id is not null and system_revisions.revisionable_type = Acme\Blog\Models\Post group by created_at, user_id order by created_at desc)

I would find a quick fix by commenting this line in getHistory() method of your RevisionHistory form widget :

->groupBy('created_at', 'user_id')

Best regards

Hello,

I have a model with a date field, each time I save that model, a revision change is detected, even if I don't change anything

my database table is of type : "date"

and my field is a standard datepicker

Best regards,

Alex

They have also null values instead of empty arrays. Don't know if that is Ocms v3 related.

I'll probably create a pull request for this soon.

Hello,

My revisionable model contain many to many relations, but changes are not tracked.

Does this module support many to many relations ? If yes, how do you define them ?

Thank you

When you make a types (checkboxlist, radio ) revisionable, only the changed ID will be displayed. Also with tags for richeditor. It is very uncomfortable.
If you add the ability to fix it, I will be very grateful.

the plugin detects where there is not in the case of RichTextEditor.

Hello,

Is it possible to alter the output of a field before rendering it ?

Because repeater fields render very badly and I would like to be able to deal with it before display it

Also, it would be great to not escape content when displaying it in partial like here :

<?= $getFieldDiff($revision->field, e($revision->old_value), e($revision->new_value)) ?>

And let user display html if they need to

Thank you