They have also null values instead of empty arrays. Don't know if that is Ocms v3 rela

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

This is already the case <div class="highlight highlight-text-html-php notranslate

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Jsonable fields are getting all logged right now, even when there is not a single change about revisions-plugin HOT 7 CLOSED

samuell1 commented on May 29, 2024

Jsonable fields are getting all logged right now, even when there is not a single change

from revisions-plugin.

Comments (7)

TimFoerster commented on May 29, 2024

All entries are also stored twice?

from revisions-plugin.

TimFoerster commented on May 29, 2024

All entries are also stored twice?

Both listen to the same events, therefore it will be stored twice.

revisions-plugin/traits/Revisions.php

Lines 15 to 35 in da90583

 public static function bootRevisionable() 

 { 

 if (!property_exists(get_called_class(), 'revisionable')) { 

 throw new Exception(sprintf( 

 'You must define a $revisionable property in %s to use the Revisionable trait.', 

 get_called_class() 

 )); 

 } 

 static::extend(function ($model) { 

 $model->morphMany['revision_history'] = ['System\Models\Revision', 'name' => 'revisionable']; 

 $model->bindEvent('model.afterUpdate', function () use ($model) { 

 $model->revisionableAfterUpdate(); 

 }); 

 $model->bindEvent('model.afterDelete', function () use ($model) { 

 $model->revisionableAfterDelete(); 

 }); 

 }); 

 }

Revisionable:

public function initializeRevisionable()
    {
        if (!is_array($this->revisionable)) {
            throw new Exception(sprintf(
                'The $revisionable property in %s must be an array to use the Revisionable trait.',
                get_class($this)
            ));
        }

        $this->bindEvent('model.afterUpdate', function () {
            $this->revisionableAfterUpdate();
        });

        $this->bindEvent('model.afterDelete', function () {
            $this->revisionableAfterDelete();
        });
    }

from revisions-plugin.

Samuell1 commented on May 29, 2024

@TimFoerster Hey, you need to only include trait from this plugin, if you add both traits it will fire 2 times.

from revisions-plugin.

TimFoerster commented on May 29, 2024

This is already the case

use Samuell\Revisions\Traits\Revisions;

class Company extends Model
{
    use Revisions;

    protected $revisionable = [
        'section',
        'name',
        'address',
        'type',
        'station_id',
        'content',
        'contacts',
        'divisions',
        'persons'
    ];
    ...

Error appears only with ocms 3.

from revisions-plugin.

Samuell1 commented on May 29, 2024

@TimFoerster if you remove that bindEvent it works correctly?

from revisions-plugin.

skacco commented on May 29, 2024

I have the same problem.
You need to comment this part on your plugin inside revisions/traits/Revisions.php

       /* $model->bindEvent('model.afterUpdate', function () use ($model) {
            $model->revisionableAfterUpdate();
        });

        $model->bindEvent('model.afterDelete', function () use ($model) {
            $model->revisionableAfterDelete();
        });*/

from revisions-plugin.

Jsonable fields are getting all logged right now, even when there is not a single change about revisions-plugin HOT 7 CLOSED

Comments (7)

Related Issues (12)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	public static function bootRevisionable()
	{
	if (!property_exists(get_called_class(), 'revisionable')) {
	throw new Exception(sprintf(
	'You must define a $revisionable property in %s to use the Revisionable trait.',
	get_called_class()
	));
	}

	static::extend(function ($model) {
	$model->morphMany['revision_history'] = ['System\Models\Revision', 'name' => 'revisionable'];

	$model->bindEvent('model.afterUpdate', function () use ($model) {
	$model->revisionableAfterUpdate();
	});

	$model->bindEvent('model.afterDelete', function () use ($model) {
	$model->revisionableAfterDelete();
	});
	});
	}