samirhodzic / ngx-youtube-player Goto Github PK

View Code? Open in Web Editor NEW

88.0 13.0 46.0 2.14 MB

YouTube player app built with Angular 7

Home Page: https://samirhodzic.github.io/ngx-youtube-player

License: MIT License

HTML 19.92% TypeScript 59.97% CSS 20.11%

angular-cli typescript youtube youtube-api music-player video-player youtube-player ngx-youtube-player video playlist

ngx-youtube-player's People

Contributors

Stargazers

Watchers

ngx-youtube-player's Issues

Update UI to be fully responsive for mobile/tablet

Export or Import problem

When i export playlist it's save to "text/plain" type, not to "application/json" Link to export function
I thing the type specified in let file = new Blob([data], { type: "text/json" }); is wrong..
must be "application/json" ?
But this it does not matter, because i tried to "application/json" and don't work..
And is show me "File is not supported."
I attached a screen photo of debug when i trying to import play list.

Fix TSLint errors or update TSLint rules

I just noticed a lot of errors in IntelliJ Idea, and it was all about TSLint errors.

Here's the result when running

npm run lint

Could not find implementations for the following rules specified in the configuration:
    label-undefined
    no-duplicate-key
    no-unreachable
    directive-selector-prefix
    component-selector-prefix
    directive-selector-name
    component-selector-name
    directive-selector-type
    component-selector-type

Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed.
If TSLint was recently upgraded, you may have old rules configured which need to be cleaned up.

Warning: The 'no-unused-variable' rule requires type information.
Warning: The 'no-use-before-declare' rule requires type information.

ERROR: src/app/app.module.ts[45, 1]: trailing whitespace
ERROR: src/app/main/main.component.ts[80, 3]: if statements must be braced
ERROR: src/app/main/main.component.ts[139, 1]: Exceeds maximum line length of 140
ERROR: src/app/main/main.component.ts[16, 28]: Type boolean trivially inferred from a boolean literal, remove type annotation
ERROR: src/app/main/main.component.ts[17, 25]: Type boolean trivially inferred from a boolean literal, remove type annotation
ERROR: src/app/main/main.component.ts[18, 24]: Type boolean trivially inferred from a boolean literal, remove type annotation
ERROR: src/app/main/main.component.ts[19, 17]: Type boolean trivially inferred from a boolean literal, remove type annotation
ERROR: src/app/main/main.component.ts[20, 18]: Type boolean trivially inferred from a boolean literal, remove type annotation
ERROR: src/app/main/main.component.ts[22, 31]: Type boolean trivially inferred from a boolean literal, remove type annotation
ERROR: src/app/main/main.component.ts[114, 1]: trailing whitespace
ERROR: src/app/main/main.component.ts[33, 2]: Implement lifecycle hook interface AfterViewInit for method ngAfterViewInit in class MainComponent (https://angular.io/styleguide#style-09-01)
ERROR: src/app/main/video-player/video-player.component.ts[39, 1]: tab indentation expected
ERROR: src/app/main/video-player/video-player.component.ts[40, 1]: tab indentation expected
ERROR: src/app/main/video-player/video-player.component.ts[41, 1]: tab indentation expected
ERROR: src/app/main/video-player/video-player.component.ts[42, 1]: tab indentation expected
ERROR: src/app/main/video-player/video-player.component.ts[12, 20]: Type boolean trivially inferred from a boolean literal, remove type annotation
ERROR: src/app/main/video-player/video-player.component.ts[13, 25]: Type boolean trivially inferred from a boolean literal, remove type annotation
ERROR: src/app/main/video-player/video-player.component.ts[14, 23]: Type string trivially inferred from a string literal, remove type annotation
ERROR: src/app/main/video-player/video-player.component.ts[15, 18]: Type boolean trivially inferred from a boolean literal, remove type annotation
ERROR: src/app/main/video-player/video-player.component.ts[16, 17]: Type boolean trivially inferred from a boolean literal, remove type annotation
ERROR: src/app/main/video-player/video-player.component.ts[17, 27]: Type boolean trivially inferred from a boolean literal, remove type annotation
ERROR: src/app/main/video-player/video-player.component.ts[18, 27]: Type string trivially inferred from a string literal, remove type annotation
ERROR: src/app/main/video-player/video-player.component.ts[121, 1]: trailing whitespace
ERROR: src/app/main/video-player/video-player.component.ts[51, 61]: missing whitespace
ERROR: src/app/main/video-player/video-player.component.ts[52, 64]: missing whitespace
ERROR: src/app/main/video-player/video-player.component.ts[62, 61]: missing whitespace
ERROR: src/app/main/video-player/video-player.component.ts[58, 5]: missing whitespace
ERROR: src/app/main/video-player/video-player.component.ts[114, 5]: missing whitespace
ERROR: src/app/main/video-player/video-player.component.ts[130, 6]: missing whitespace
ERROR: src/app/main/videos-search/videos-search.component.ts[35, 3]: if statements must be braced
ERROR: src/app/main/videos-search/videos-search.component.ts[43, 5]: if statements must be braced
ERROR: src/app/shared/constants.ts[1, 82]: file should end with a newline
ERROR: src/app/shared/constants.ts[1, 31]: Type string trivially inferred from a string literal, remove type annotation
ERROR: src/app/shared/directives/lazy-scroll/lazy-scroll.directive.ts[35, 2]: file should end with a newline
ERROR: src/app/shared/directives/lazy-scroll/lazy-scroll.directive.ts[5, 2]: Use @HostBindings and @HostListeners instead of the host property (https://angular.io/styleguide#style-06-03)
ERROR: src/app/shared/directives/lazy-scroll/lazy-scroll.directive.ts[13, 2]: In the class "LazyScroll", the directive input property "scrollTrigger" should not be renamed.Please, consider the following use "@Input() scrollTrigger: string"
ERROR: src/app/shared/directives/lazy-scroll/lazy-scroll.directive.ts[9, 14]: The name of the class LazyScroll should end with the suffix Directive (https://angular.io/styleguide#style-02-03)
ERROR: src/app/shared/pipes/now-playing-name.pipe.ts[17, 2]: file should end with a newline
ERROR: src/app/shared/pipes/now-playing-name.pipe.ts[10, 1]: trailing whitespace
ERROR: src/app/shared/pipes/playlist-item-name.pipe.ts[17, 2]: file should end with a newline
ERROR: src/app/shared/pipes/playlist-item-name.pipe.ts[10, 1]: trailing whitespace
ERROR: src/app/shared/pipes/video-duration.pipe.ts[31, 2]: file should end with a newline
ERROR: src/app/shared/pipes/video-likes.pipe.ts[11, 2]: file should end with a newline
ERROR: src/app/shared/pipes/video-likes.pipe.ts[9, 10]: Missing radix parameter
ERROR: src/app/shared/pipes/video-views.pipe.ts[11, 2]: file should end with a newline
ERROR: src/app/shared/pipes/video-views.pipe.ts[9, 10]: Missing radix parameter
ERROR: src/app/shared/services/notification.service.ts[19, 2]: file should end with a newline
ERROR: src/app/shared/services/notification.service.ts[7, 2]: Declaration of instance field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface.
ERROR: src/app/shared/services/notification.service.ts[7, 27]: Type number trivially inferred from a number literal, remove type annotation
ERROR: src/app/shared/services/playlist-store.service.ts[51, 2]: file should end with a newline
ERROR: src/app/shared/services/playlist-store.service.ts[7, 2]: Declaration of instance field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface.
ERROR: src/app/shared/services/playlist-store.service.ts[8, 2]: Declaration of instance field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface.
ERROR: src/app/shared/services/playlist-store.service.ts[7, 23]: Type string trivially inferred from a string literal, remove type annotation
ERROR: src/app/shared/services/playlist-store.service.ts[9, 3]: " should be '
ERROR: src/app/shared/services/youtube-api.service.ts[81, 2]: file should end with a newline
ERROR: src/app/shared/services/youtube-api.service.ts[22, 1]: Exceeds maximum line length of 140
ERROR: src/app/shared/services/youtube-api.service.ts[42, 1]: Exceeds maximum line length of 140
ERROR: src/app/shared/services/youtube-api.service.ts[60, 1]: Exceeds maximum line length of 140
ERROR: src/app/shared/services/youtube-api.service.ts[10, 12]: Type string trivially inferred from a string literal, remove type annotation
ERROR: src/app/shared/services/youtube-api.service.ts[11, 15]: Type number trivially inferred from a number literal, remove type annotation
ERROR: src/app/shared/services/youtube-api.service.ts[19, 2]: misplaced opening brace
ERROR: src/app/shared/services/youtube-player.service.ts[83, 3]: if statements must be braced
ERROR: src/app/shared/services/youtube-player.service.ts[85, 25]: missing whitespace
ERROR: src/app/shared/services/youtube-player.service.ts[42, 9]: missing whitespace
ERROR: src/app/shared/services/youtube-player.service.ts[57, 5]: missing whitespace
ERROR: src/app/shared/services/youtube-player.service.ts[83, 5]: missing whitespace

Loved your app! Can you convert it to angular 6 ?

I am currently learning angular & found your app at AngularExpo.com. Your app is in Angular 5 and I am learning Angular 6, I wonder what changes should be made to this app to convert it to angular 6.

I don't no what should be changed, but if there are major changes than if you convert it to 6, than it will be very useful to people like who is learning angular.

Browser notification interface when new song is going to start

How to turn on auto play option for video?

I'm using ngx-youtube-player. I can't find out auto play option for video. How can I do that?

Functionality problems on linux

On Ubuntu 16.04 LTS (tested on google chrome and firefox) your app is mostly not working:

search doesn't work at all;
when I add a video to my playlist I have to refresh the page to see the video in the playlist;
should play button transform in a pause button when video is playing? Right now it's always a play button;
repeat and shuffle are not working at all
burger menu doesn't do anything on click
fullscreen buton on player-controls-block doesn't work correctly (the video gets a little bigger in the left-bottom corner)
video thumbnails are not loaded

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.