Git Product home page Git Product logo

pinit's People

Contributors

actions-user avatar albanobattistella avatar amereyeu avatar braidenpsiuk avatar comradekingu avatar danieltolentino avatar daphipz avatar dependabot[bot] avatar flipflop97 avatar fnogcps avatar hanaral avatar ihorhordiichuk avatar jeysonflores avatar johndumpling avatar lenemter avatar nathanbnm avatar oersen avatar polpolylingo avatar rene-coty avatar ryonakano avatar tsc2end avatar vistaus avatar weblate avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

pinit's Issues

Pin It! is not compatible with autoupdating apps such as Beeper

I use Pin It! to get a Gnome desktop entry for the Beeper AppImage.

Location of the AppImage:

image

Pin It! configuration for Beeper:

image

Beeper has a self updating system, where the name of the AppImage changes in the following format: beeper-3.63.16.AppImage > beeper-3.63.20.AppImage. Due to this, I have to update the Pin It! entry every time I get a Beeper update. This is inconvenient. I tried adding an asterisk (*) as a wildcard after beeper in the form of beeper-*.AppImage, however this did not work. Please suggest a way to get this issue solved.

After the update to Fedora 36, the icon of pinned apps in the launcher won't be shown even if reinstalled

I've just updated to fedora 36 / GNOME 42.1 and i 'm having the following issue which it was not existing in the previous versions of fedora.

issue

  1. the icon of pinned apps (appimage) in the launcher has disappeared after the update to fedora 36
  2. I've reinstalled "Pin it" several times and as a result the icon of pinned apps have bean appeared each time but after the restarting of my laptop the same issue reappears

Don' let users take care of the file name of desktop files

  • UI
    • Remove file name entry
    • Show the new entry in the files list when clicking the plus button
  • Backend
    • Create a new desktop file when clicking the plus button
    • Automatically decide the file name of desktop files

This should have a side effect that fixes Open button won't work for new desktop file (since the file is not written to the storage yet before clicking the save button at the moment).

Dark theme style not working

The dark theme style does not work, and after selecting it, the theme remains light. The version I use is 1.4.1.

Errors with localized keys

Hello,

When I use Pin It! to create a .desktop file. I get the following errors if I then run desktop-file-validate on the resulting file.

.local/share/applications/com.logseq.desktop: error: key "Name[en_US.UTF-8]" in group "Desktop Entry" is a localized key, but there is no non-localized key "Name"
.local/share/applications/com.logseq.desktop: error: key "Comment[en_US.UTF-8]" in group "Desktop Entry" is a localized key, but there is no non-localized key "Comment"
.local/share/applications/com.logseq.desktop: error: required key "Name" in group "Desktop Entry" is not present

Can't choose .ico as icon

This format is not supported and I don't understand why. I manually specified the path to the .ico file for the application, works great.

The viewport for "edit a desktop file" is broken

The viewport is not resizable and there isn't any scrollbar. The only way to view the entries is to grab the window with a keybinding and move it up off the screen.

image

  • Debian 11
  • Gnome 3.38
  • Pin It 1.2

The window is not resizable

First of all, thanks for this cool application.

The problem is, I cannot simply resize the window. My screen is small (i.e. 1366x768), so the window is too large to fit there, and I have to move it using Alt + F7 on Gnome to actually see the Save Entry button, for example.

The "edit a desktop file" window is too wide

Upon loading, the main window appears fine, as shown in this screenshot:

image

The new file option also looks fine. But the edit file option opens a window that is too wide:

image

image

There's no horizontal scrollbar, so I have to grab the window with the Gnome keybinding (super) and click and drag the whole window to show you the other half.

  • Debian 11
  • Gnome 3.38.5
  • Wayland
  • Pinit 1.2.1 (Flatpak)

Pinned entries do not persist after reboot

Behavior

Pin It! works great as expected after install from PopShop, and launcher entries are added as expected.

However, the pinned entries are lost after reboot. To restore them, I need to return to Pin It! and re-open/re-save the entries for them to reappear.

System info:

Distributor ID: Pop
Description: Pop!_OS 22.04 LTS
Release: 22.04
Codename: jammy

Pin It does not display the icons

OS: elementary OS 6.1 Jólnir x86_64
Pin It from flathub: com.github.ryonakano.pinit, version 1.4.1

I have the issue, that the icon in Pin It is not displayed

Bildschirmfoto von 2022-05-09 13 22 08

The icon is displayed in the menu tho

Bildschirmfoto von 2022-05-09 13 24 26

journalctl logs the following:

com.github.ryon[2662]: Failed to load module "canberra-gtk-module"
com.github.ryon[2662]: FilesView.vala:54: Datei »/home/florian/.var/app/com.valvesoftware.Steam/data/icons/hicolor/256x256/apps/steam_icon_239030.png« konnte nicht geöffnet werden: No such file or directory
com.github.ryon[2662]: FilesView.vala:54: Datei »/home/florian/.wine/drive_c/Program Files (x86)/Sub Culture/ICON/5.png« konnte nicht geöffnet werden: No such file or directory
com.github.ryon[2662]: FilesView.vala:54: Datei »/home/florian/.var/app/com.valvesoftware.Steam/data/icons/hicolor/96x96/apps/steam_icon_212680.png« konnte nicht geöffnet werden: No such file or directory

Which is odd - this is definitely the correct path for all three icons.

the canberra-error is also strange; there are a dozen of canberra-libs already installed


florian@X302UA178cf8b1:~$ apt list | grep canberra-gtk

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

libcanberra-gtk-common-dev/focal,focal 0.30-7ubuntu1 all
libcanberra-gtk-dev/focal 0.30-7ubuntu1 amd64
libcanberra-gtk-dev/focal 0.30-7ubuntu1 i386
libcanberra-gtk-module/focal,now 0.30-7ubuntu1 amd64  [installiert]
libcanberra-gtk-module/focal 0.30-7ubuntu1 i386
libcanberra-gtk0/focal,now 0.30-7ubuntu1 amd64  [Installiert,automatisch]
libcanberra-gtk0/focal 0.30-7ubuntu1 i386
libcanberra-gtk3-0/focal,now 0.30-7ubuntu1 amd64  [Installiert,automatisch]
libcanberra-gtk3-0/focal 0.30-7ubuntu1 i386
libcanberra-gtk3-dev/focal 0.30-7ubuntu1 amd64
libcanberra-gtk3-dev/focal 0.30-7ubuntu1 i386
libcanberra-gtk3-module/focal,now 0.30-7ubuntu1 amd64  [Installiert,automatisch]
libcanberra-gtk3-module/focal 0.30-7ubuntu1 i386

Respect GNOME HIG

Since now we use GTK 4 and libadwaita, it's better to follow the GNOME HIG for consistency with other apps on GNOME. I'm not familiar with it and still reading it, so labeling as "Help Wanted" for more familiar people.

Embedded FilesView

Currently, you need to open ~/.local/share/applications explicitly if you want to open existing desktop files. But this is a hidden folder so we should provide a list of desktop files in this folder and prevent users from being conscious of the file location

Program uses different directory when browsing path of executable

I have an issue where if I browse to the path of my program, which in this case is in the /home/<folder> directory, it instead uses the /run/user/ directory. I don't know if this was intended behavior, system error or program error so some insight would be much appreciated. I like using this program since it saves me a lot of headaches, so to have this issue solved would be a life-changer.

Information:

  1. OS is Fedora 36 Workstation Beta
  2. Application was installed through flathub

Add an app icon

Hi @hanaral, sorry for mentioning you but I'd like to ask you a favor.

You made the app icon for Louper before and I really like it. And now I've started developing my fourth app here. Would you mind creating an app icon for this app too?

Add the possibility to enter the StartupWMClass

OS: elementary OS 6.1 Jólnir x86_64
Pin It!: com.github.ryonakano.pinit 1.4.1

I really prefer using Pin It! over other applications like menulibre since it fits the minimalistic design of elementary OS. Yet there is one feature that I do miss: a way to add the StartupWMClass to the .deskop file.

Without the StartupWMClass applications will usually run in another instance and not use the entry I pinned to plank:
Bildschirmfoto von 2022-07-10 12 42 38
(Papers, Please does not use the entry I pinned to the dock but another instance without an icon)

This means I usually have to open the .desktop file with a text editor anyway.
Bildschirmfoto von 2022-07-10 12 56 26
(after addin the StartupWMClass; Papers, Please is not shown as running in another instance)

Proposal: another line in the "Edit Menu" for the Startup WM Class, much like in menulibre
7oCRkTW
bonus points for a picker, e.g. click on the magnifying glass and then on the application window to get the correct value

File name too restrictive

Allowing characters like dash or underscore in the filename is a good thing to have. For instance, pling-store.desktop is way better than plingstore.desktop. Even further, should be even there a restriction?

App Listing Quality on Flathub

Listing failed checks of the app:

I'm not sure if this blocks publishing future releases, but tagging as "Help Wanted" since I'm not good at designing icons 😇

Sufficient valadoc

  • src/Application.vala
  • src/Config.vala.in
  • src/Define.vala
  • src/MainWindow.vala
  • src/Model/DesktopFile.vala
  • src/Model/DesktopFileModel.vala
  • src/Util/DesktopFileUtil.vala
  • src/View/EditView.vala
  • src/View/FilesView.vala
  • src/Widget/CategoriesRow.vala
  • src/Widget/KeywordsRow.vala

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.