ryan-rsm-mckenzie / bsa Goto Github PK

I am able to reproduce this bug with this simple code

#include <bsa/fo4.hpp>

int main()
{
    using namespace bsa::fo4;
    file f;
    f.read("textures/in.dds", format::directx);
    f.write("textures/out.dds", format::directx);
}

This corrupts all tested textures. : Example

By looking at it in a hex editor, the header appears to be fine. The corruption starts at the end of the header, as soon as we enter the data section

The issue appears to be in write . Creating a textures BSA, and extracting it with another tool seems to work

When iterating this archive (from WACCF) the file "textures\\weapons\\orcish\\orcisharrow.dds" is listed twice.

This causes issues in multithreading with two threads trying to open the same file

This is due to how byte_container is defined. By default, it creates an empty span

By making data_owner the first alternative, we could avoid this issue. Or maybe default construction should be a span to a static empty vector, for performance?

If this is by design, I suggest adding an assertion to make debugging easier.

With the introduction of the v2 and v3 variants of the .ba2 format in Starfield, the archive format is no longer sufficient to discriminate between data format variants. Most functions now also require a compression_format to handle compression properly, which means that configuring inputs to functions has become overly obnoxious. As a result, I have taken the liberty to convert many functions to take some form of *_param. This offers users the flexibility to override only the fields they need, while leaving others untouched by leveraging designated initializers. Unfortunately, this has the undesired side effect of being the largest API break this library has had thus far. This issue stands as a forum for users to provide feedback on the new API changes: whether they like them/don't like them/think they could be better/etc.

For reference, the .ba2 format is described in detail here.

I am currently investigating, but haven't found anything yet

Reproducing:

• Create a fo4dds archive
• Open in archive2
• Delete a single file
• Try to save the archive
• Lots of errors will appear about "unsupported file type"

Recap of what I found so far:

• BitsPerPixel should be always 8.
• Flags should be 0 or 1 if the texture is a cubemap
• It looks like archive2 does not produce the same archive header as rsm-bsa. I linked an example below. bsarch is correct, so studying its code may help. The first difference is the string table offset