Comments (1)
zecakeh
commented on June 18, 2024
1
I would make content an Option<C> in the BundledReplacement.
We could add a method apply_bundled_replacement, that does nothing if the content is not present in the aggregations, and otherwise replaces the content.
The question is, will it be okay at some point to replace the Option<C> with C? But that's an issue for later.
By the way this wouldn't be a breaking change (in our API anyway), if done like I said.
from ruma.
Related Issues (20)
- Error parsing error response for `POST /_matrix/client/v3/keys/signatures/upload` HOT 5
- Make DST ID types less awkward under the `Arc` ID representation HOT 4
- Implement Matrix 1.8 changes
- Relax validation of identifiers for clients HOT 2
- Implement Matrix 1.9 changes
- There's no way to get the name of the algorithm out of the `SecretEncryptionAlgorithm` struct HOT 1
- `cargo doc` fails to document `ruma_events` HOT 1
- Release automation does not pick up release notes if skipping all previous steps
- Add call.notify event (MSC4075)
- `m.direct` account data parsing should be more lenient HOT 2
- The `strike` and `font` HTML elements are deprecated and `s` is introduced HOT 1
- Implement Matrix 1.10 changes HOT 1
- Inconsistent m.call.candidates candidate definition
- Upgrade http to version 1.x HOT 6
- Upgrade html5ever HOT 1
- Make `room_alias_or_id::Variant` a public enum HOT 8
- How to send encrypted message to encrypted room HOT 3
- When user reply to their message, the reply mentions the current user HOT 1
- API responses always return a `200 OK` status code HOT 4
- Support optional path parameters for endpoints HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ruma.