Error parsing error response for `POST /_matrix/client/v3/keys/signatures/upload` about ruma HOT 5 CLOSED

I'm not sure how we should handle that. Looking at dendrite's code it returns the regular Matrix error format, like in the example.

Maybe for now we could add a compat feature to accept both formats?

from ruma.

Yeah, we could add a compat feature that simply adds #[serde(alias = "message")] to the error property. I think there should be a Synapse issue for this too. I don't see why Ruma and Dendrite should change long-term here, especially since the error name is more common than message elsewhere.

from ruma.

I don't disagree that synapse is being stupid here, but it is compliant with the letter of the spec, as far as it goes.

Do we actually need the message at all? I'm wary that relying on it to exist is just adding more reliance on unspecced behaviour.

from ruma.

You've got a point, but I'd rather not make more changes before the spec is clarified for this, unless required for compatibility with existing software.

from ruma.

before the spec is clarified for this

Let's be honest, the spec isn't going to get clarified unless somebody is sufficiently motivated to write and push through an MSC, and even then you have to handle servers which do not comply with the latest spec...

from ruma.