rsm-hcd / andculturecode.csharp Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 3.0 1.42 MB

Commonly used C# interfaces, patterns, extension methods and utilities by andculture engineering

License: Apache License 2.0

C# 99.95% Shell 0.05%

csharp dotnet hacktoberfest

andculturecode.csharp's People

Contributors

Stargazers

Watchers

Forkers

klauffer myty rllowman

andculturecode.csharp's Issues

Extract ObjectExtensions #FromByteArray and #ToByteArray

Extract ObjectExtensions #FromByteArray and #ToByteArray to AndcultureCode.CSharp.Extensions and write unit tests

Add/fix XML doc comments for Extensions

See warning list from a recent build:

Extensions\EnumerableExtensions.cs(9,25): warning CS1591: Missing XML comment for publicly visible type or member 'EnumerableExtensions' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IAndcultureCodeWebHostBuilderExtensions.cs(7,25): warning CS1591: Missing XML comment for publicly visible type or member 'IAndcultureCodeWebHostBuilderExtensions' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IAndcultureCodeWebHostBuilderExtensions.cs(11,29): warning CS1591: Missing XML comment for publicly visible type or member 'IAndcultureCodeWebHostBuilderExtensions.ASPNETCORE_ENVIRONMENT' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IAndcultureCodeWebHostBuilderExtensions.cs(28,43): warning CS1573: Parameter 'configurationProvider' has no matching param tag in the XML comment for 'IAndcultureCodeWebHostBuilderExtensions.PreloadAmazonElasticBeanstalk(IAndcultureCodeWebHostBuilder, bool, AmazonEBConfigurationProvider)' (but other parameters do) [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IConfigurationBuilderExtensions.cs(6,25): warning CS1591: Missing XML comment for publicly visible type or member 'IConfigurationBuilderExtensions' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\ICultureExtensions.cs(11,25): warning CS1591: Missing XML comment for publicly visible type or member 'ICultureExtensions' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\ICultureExtensions.cs(15,32): warning CS1591: Missing XML comment for publicly visible type or member 'ICultureExtensions.Default(IEnumerable<ICulture>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\ICultureExtensions.cs(33,28): warning CS1591: Missing XML comment for publicly visible type or member 'ICultureExtensions.Exists(IEnumerable<ICulture>, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\ICultureExtensions.cs(50,36): warning CS1591: Missing XML comment for publicly visible type or member 'ICultureExtensions.ToCultureCodes(IEnumerable<ICulture>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\ICultureExtensions.cs(53,30): warning CS1591: Missing XML comment for publicly visible type or member 'ICultureExtensions.ToCultureCodes(IEnumerable<ICulture>, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\ICultureExtensions.cs(73,35): warning CS1591: Missing XML comment for publicly visible type or member 'ICultureExtensions.ToCultureInfo(ICulture)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\ICultureExtensions.cs(76,41): warning CS1591: Missing XML comment for publicly visible type or member 'ICultureExtensions.ToCultureInfos(IEnumerable<ICulture>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(15,25): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(29,30): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.AddError<T>(IResult<T>, IError)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(44,30): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.AddError<T>(IResult<T>, ErrorType, string, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(70,104): warning CS1573: Parameter 'type' has no matching param tag in the XML comment for 'IResultExtensions.AddError<T>(IResult<T>, IStringLocalizer, ErrorType, string, params object[])' (but other parameters do) [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(73,30): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.AddError<T>(IResult<T>, string, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(97,30): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.AddExceptionError<T>(IResult<T>, string, Exception)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(107,30): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.AddValidationError<T>(IResult<T>, string, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(123,36): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.AddErrors<T>(IResult<T>, IEnumerable<IError>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(138,36): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.AddErrors<T, TSource>(IResult<T>, IResult<TSource>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(163,28): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.AddErrorAndLog<T>(IResult<T>, ILogger, string, string, long?)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(170,28): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.AddErrorsAndLog<T>(IResult<T>, ILogger, string, string, long, IEnumerable<IError>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(177,28): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.AddErrorsAndLog<T>(IResult<T>, ILogger, string, string, IEnumerable<IError>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(307,50): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.AddNextLinkParam<T>(IResult<T>, string, int)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(346,28): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.DoesNotHaveErrors<T>(IResult<T>, ErrorType)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(347,28): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.DoesNotHaveErrors<T>(IResult<T>, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(353,36): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.GetErrors<T>(IResult<T>, ErrorType)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(363,36): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.GetErrors<T>(IResult<T>, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(373,36): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.GetValidationErrors<T>(IResult<T>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(379,28): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.HasErrors<T>(IEnumerable<IResult<T>>, ErrorType)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(382,28): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.HasErrors<T>(IEnumerable<IResult<T>>, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(385,28): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.HasErrors<T>(IEnumerable<IResult<T>>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(388,28): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.HasErrors<T>(IResult<T>, ErrorType)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(391,28): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.HasErrors<T>(IResult<T>, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(394,28): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.HasErrorsOrResultIsFalse(IResult<bool>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(397,28): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.HasErrorsOrResultIsNull<T>(IResult<T>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(400,28): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.HasValidationErrors<T>(IResult<T>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(407,30): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.ListErrors<T>(IEnumerable<IResult<T>>, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(423,30): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.ListErrors<T>(IResult<T>, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(445,34): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.ThrowIfAnyErrors<T>(IResult<T>, Exception)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(459,34): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.ThrowIfAnyErrorsOrResultIsNull<T>(IResult<T>, Exception, Exception)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IResultExtensions.cs(483,37): warning CS1591: Missing XML comment for publicly visible type or member 'IResultExtensions.ThrowIfAnyErrorsOrResultIsFalse(IResult<bool>, Exception, Exception)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\IStringLocalizerExtensions.cs(7,25): warning CS1591: Missing XML comment for publicly visible type or member 'IStringLocalizerExtensions' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\ResourceVerbExtensions.cs(7,25): warning CS1591: Missing XML comment for publicly visible type or member 'ResourceVerbExtensions' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\ResourceVerbExtensions.cs(9,36): warning CS1591: Missing XML comment for publicly visible type or member 'ResourceVerbExtensions.ToResourceVerb(string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Extensions\ResourceVerbExtensions.cs(12,42): warning CS1591: Missing XML comment for publicly visible type or member 'ResourceVerbExtensions.ToResourceVerbs(IEnumerable<string>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]

Add or fix comments as needed to reduce the number of warnings.

If you're not sure what a function/field does and you're an andculture employee, feel free to ask to pair with another engineer or in Slack to figure out how to best document the actor, or move on to another area.

If you're not an andculture employee, try to add something to the best of your ability - otherwise, feel free to add in a TODO comment with a link to this issue so another engineer can search for those in the code base and fill them in with an actual description. For example:

/// <summary>
/// TODO https://github.com/AndcultureCode/AndcultureCode.CSharp.Core/issues/38
/// </summary>
/// <param name="key"></param>
/// <param name="value"></param>
public void Add(TKey key, TValue value)
...

Deprecate Packages Owned by the andculture NuGet Organization

For each package owned by the andculture NuGet organization, deprecate all versions of the package. For the reason, select Other and indicate that all packages under the andculture organization have moved to the rsm-hcd organization

          Maybe we could deprecate the packages and point folks to the newer org, similar to what we're doing with GitHub?

Originally posted by @rllowman in #54 (comment)

Merge AndcultureCode.CSharp.Core into AndcultureCode.CSharp

Rename AndcultureCode.CSharp to RSM.HCD.CSharp

Rename the AndcultureCode.CSharp repo to RSM.HCD.CSharp.

Port Open Issues and PRs over from AndcultureCode.CSharp.Testing

Move Open Issues and PRs over from AndcultureCode.CSharp.Testing. Then mark Repo as Archived

IResult<IEnumerable<IAuditable>> matcher extensions

Follow up to AndcultureCode/AndcultureCode.CSharp.Testing#48 IResult Auditable matcher extensions

Having some additional extension matchers for collections of ICreatable, IDeletable, etc. results would also be nice:

// Current
result.ResultObject.ShouldAllBe((e) => e.CreatedById == expectedUser.Id);

// Proposed
result.ShouldAllBeCreatedBy(expectedUser);

New extensions:

public static void ShouldAllBeCreated<TCreatable>(this IResult<IEnumerable<TCreatable>> result) where TCreatable : ICreatable
public static void ShouldAllBeCreatedBy<TCreatable>(this IResult<IEnumerable<TCreatable>> result, long createdById) where TCreatable : ICreatable
public static void ShouldAllBeCreatedBy<TCreatable>(this IResult<IEnumerable<TCreatable>> result, IEntity createdBy) where TCreatable : ICreatable
public static void ShouldAllBeDeleted<TDeletable>(this IResult<IEnumerable<TDeletable>> result) where TDeletable : IDeletable
public static void ShouldAllBeDeletedBy<TDeletable>(this IResult<IEnumerable<TDeletable>> result, long deletedById) where TDeletable : IDeletable
public static void ShouldAllBeDeletedBy<TDeletable>(this IResult<IEnumerable<TDeletable>> result, IEntity deletedBy) where TDeletable : IDeletable
public static void ShouldAllBeUpdated<TUpdatable>(this IResult<IEnumerable<TUpdatable>> result) where TUpdatable : IUpdatable
public static void ShouldAllBeUpdatedBy<TUpdatable>(this IResult<IEnumerable<TUpdatable>> result, long updatedById) where TUpdatable : IUpdatable
public static void ShouldAllBeUpdatedBy<TUpdatable>(this IResult<IEnumerable<TUpdatable>> result, IEntity updatedBy) where TUpdatable : IUpdatable

ShouldNotHaveResultObject / ShouldNotHaveResultObjects

Inverse extensions of ShouldHaveResultObject / ShouldHaveResultObjects. Add appropriate test coverage following existing patterns.

// Arrange
var result = BuildResult<UserStub>((e) => e.ResultObject = null);

// Act & Assert
result.ShouldNotHaveResultObject(); // Passes

// Arrange
var result = BuildResult<IEnumerable<UserStub>>((e) => e.ResultObject = null);

// Act & Assert
result.ShouldNotHaveResultObjects(); // Passes

// Arrange
var result = BuildResult<IEnumerable<UserStub>>((e) => e.ResultObject = Enumerable.Empty<UserStub>());

// Act & Assert
result.ShouldNotHaveResultObjects(); // Passes

Scrub AndcultureCode from C# Repo

Replace all instances of andculture and AndcultureCode with RSM HCD

Common Replacements

GitHub Organization: rsm-hcd
NuGet Organization: rsm-hcd
Namespace Prefix: RSM.HCD
Assembly Name Prefix: RSM.HCD
Package Name Prefix: RSM.HCD
Email: [email protected]

Publish Renamed RSM.HCD.CSharp Packages to the New rsm-hcd NuGet Organization

Update CI/CD pipeline to automatically push renamed packages to the new org
Publish major version 3.0

Add Task<T> overloads for IActionResult matchers

Problem
When testing a controller method that is async, the IActionResult is wrapped in Task<T>. While not a huge deal, can lead to some confusion having to add .Result. between the controller method invocation and matcher method.

var result = sut.Created(dto).Result.AsCreated<IResult<MyDto>>();

Solution
Add additional overloads to matchers in IActionResultMatcherExtensions that don't already have a Task<IActionResult> variant.

Merge AndcultureCode.CSharp.Extensions into AndcultureCode.CSharp

Create RSM HCD Nuget Organization

Create a new NuGet organization for RSM HCD. Name: rsm-hcd

Update Csharp monorepo namespaces

Rename AndcultureCode.CSharp to RSM.HCD.CSharp
Create new Nuget organization
Publish major version change (3.0) to Nuget under the new Nuget organization
Scrub anything with AndcultureCode

BuildList<T> overloads to set properties

Similar to the CreateList<T> overloads in BaseIntegrationTest.cs, it would be nice to have equivalent overloads for BuildList<T> that provide a way to configure properties on the created objects.

Port IncludeExtensions

NOTE: Must be an andculture employee to work on this issue due to requiring access to private resources.

From the LMS project, port over the IncludeExtensions static class used for building out include property strings. While it has unit tests, please review during the port and see if it requires more.

Once done, we will want to refactor this and other projects to leverage the new extension method approach.

Investigate issue with filter/orderBy expressions in repository conductor mock extensions

As alluded to in this XML comment: https://github.com/AndcultureCode/AndcultureCode.CSharp.Testing/blob/daf5d7ec6efc4b43d5ce070f832c328c3d4dc0fa/src/AndcultureCode.CSharp.Testing/Extensions/Mocks/Conductors/IRepositoryReadConductorMockExtensions.cs#L24-L26

There is a known (but not well documented) issue with the FindAll and probably any other mock setup methods for the various conductors that accept Expression or Funcs type params (such as the filter or orderBy params). Moq does not seem to properly resolve the mocked method when the actual implementation passes these values in (despite us defaulting to It.IsAny<Expression<...>>, etc), and will end up returning null when the method is called.

Spend some time digging into this, with the goal in mind being a way to allow those methods to be mocked properly. Report any findings, hiccups, potential paths of resolution, etc. here.

update deployment to make the correct nuget packages and nuget package dependency

Remove Nuget packages and reference project dependencies directly

Automate documentation generation

We can achieve this via GitHub actions. This step should be done immediately before the publish action and should include the following:

Update version in source code based on the tag version tied to the release
documentation step should automatically run with the generated docs being committed to the repo

Add/fix XML doc comments for Interfaces

See warning list from a recent build:

Interfaces\Conductors\IPermissionConductor.cs(34,1): warning CS1570: XML comment has badly formed XML -- 'Expected an end tag for element 'summary'.' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IPermissionConductor.cs(36,13): warning CS1570: XML comment has badly formed XML -- 'End tag was not expected at this location.' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IPermissionConductor.cs(46,1): warning CS1570: XML comment has badly formed XML -- 'Expected an end tag for element 'summary'.' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IPermissionConductor.cs(48,13): warning CS1570: XML comment has badly formed XML -- 'End tag was not expected at this location.' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryReadConductor.cs(28,15): warning CS1570: XML comment has badly formed XML -- 'End tag 'summary' does not match the start tag 'T'.' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryReadConductor.cs(36,1): warning CS1570: XML comment has badly formed XML -- 'Expected an end tag for element 'summary'.' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryReadConductor.cs(66,15): warning CS1570: XML comment has badly formed XML -- 'End tag 'summary' does not match the start tag 'T'.' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryReadConductor.cs(74,1): warning CS1570: XML comment has badly formed XML -- 'Expected an end tag for element 'T'.' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryReadConductor.cs(74,1): warning CS1570: XML comment has badly formed XML -- 'Expected an end tag for element 'summary'.' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(100,15): warning CS1570: XML comment has badly formed XML -- 'End tag 'summary' does not match the start tag 'T'.' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(108,1): warning CS1570: XML comment has badly formed XML -- 'Expected an end tag for element 'summary'.' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IConductor.cs(3,22): warning CS1591: Missing XML comment for publicly visible type or member 'IConductor' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\ILockingConductor.cs(6,22): warning CS1591: Missing XML comment for publicly visible type or member 'ILockingConductor<T>' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IPermissionConductor.cs(31,9): warning CS1587: XML comment is not placed on a valid language element [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IPermissionConductor.cs(43,9): warning CS1587: XML comment is not placed on a valid language element [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryConductor.cs(5,22): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryConductor<T>' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryCreateConductor.cs(7,22): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryCreateConductor<T>' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryCreateConductor.cs(22,26): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryCreateConductor<T>.BulkCreate(IEnumerable<T>, long?)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryCreateConductor.cs(36,26): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryCreateConductor<T>.Create(T, long?)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryCreateConductor.cs(37,26): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryCreateConductor<T>.Create(IEnumerable<T>, long?)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryDeleteConductor.cs(6,22): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryDeleteConductor<T>' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryDeleteConductor.cs(21,23): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryDeleteConductor<T>.BulkDelete(IEnumerable<T>, long?, bool)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryDeleteConductor.cs(22,23): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryDeleteConductor<T>.Delete(long, long?, bool)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryDeleteConductor.cs(23,23): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryDeleteConductor<T>.Delete(T, long?, bool)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryDeleteConductor.cs(24,23): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryDeleteConductor<T>.Restore(T)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryDeleteConductor.cs(25,23): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryDeleteConductor<T>.Restore(long)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryReadConductor.cs(9,22): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryReadConductor<T>' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryReadConductor.cs(58,32): warning CS1573: Parameter 'ignoreQueryFilters' has no matching param tag in the XML comment for 'IRepositoryReadConductor<T>.FindAll(Dictionary<string, string>, Expression<Func<T, bool>>, Func<IQueryable<T>, IOrderedQueryable<T>>, bool?, bool)' (but other parameters do) [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryReadConductor.cs(59,32): warning CS1573: Parameter 'asNoTracking' has no matching param tag in the XML comment for 'IRepositoryReadConductor<T>.FindAll(Dictionary<string, string>, Expression<Func<T, bool>>, Func<IQueryable<T>, IOrderedQueryable<T>>, bool?, bool)' (but other parameters do) [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryReadConductor.cs(95,32): warning CS1573: Parameter 'ignoreQueryFilters' has no matching param tag in the XML comment for 'IRepositoryReadConductor<T>.FindAllCommitted(Dictionary<string, string>, Expression<Func<T, bool>>, Func<IQueryable<T>, IOrderedQueryable<T>>, bool?)' (but other parameters do) [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryReadConductor.cs(103,20): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryReadConductor<T>.FindById(long)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryReadConductor.cs(104,20): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryReadConductor<T>.FindById(long, params Expression<Func<T, object>>[])' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryReadConductor.cs(105,20): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryReadConductor<T>.FindById(long, bool, params Expression<Func<T, object>>[])' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryReadConductor.cs(106,20): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryReadConductor<T>.FindById(long, params string[])' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryUpdateConductor.cs(6,22): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryUpdateConductor<T>' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryUpdateConductor.cs(21,23): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryUpdateConductor<T>.BulkUpdate(IEnumerable<T>, long?)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryUpdateConductor.cs(22,23): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryUpdateConductor<T>.Update(T, long?)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Conductors\IRepositoryUpdateConductor.cs(23,23): warning CS1591: Missing XML comment for publicly visible type or member 'IRepositoryUpdateConductor<T>.Update(IEnumerable<T>, long?)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(50,20): warning CS1571: XML comment has a duplicate param tag for 'items' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(51,20): warning CS1571: XML comment has a duplicate param tag for 'property' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(52,20): warning CS1571: XML comment has a duplicate param tag for 'createdById' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(53,24): warning CS1710: XML comment has a duplicate typeparam tag for 'TKey' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(67,26): warning CS1591: Missing XML comment for publicly visible type or member 'IRepository<T>.BulkUpdate(IEnumerable<T>, long?)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(68,26): warning CS1591: Missing XML comment for publicly visible type or member 'IRepository<T>.Create(T, long?)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(69,26): warning CS1591: Missing XML comment for publicly visible type or member 'IRepository<T>.Create(IEnumerable<T>, long?)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(82,32): warning CS1591: Missing XML comment for publicly visible type or member 'IRepository<T>.Delete(long, long?, bool)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(83,32): warning CS1591: Missing XML comment for publicly visible type or member 'IRepository<T>.Delete(T, long?, bool)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(109,32): warning CS1591: Missing XML comment for publicly visible type or member 'IRepository<T>.FindById(long, bool?)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(110,32): warning CS1591: Missing XML comment for publicly visible type or member 'IRepository<T>.FindById(long, params Expression<Func<T, object>>[])' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(111,32): warning CS1591: Missing XML comment for publicly visible type or member 'IRepository<T>.FindById(long, bool?, params Expression<Func<T, object>>[])' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(112,32): warning CS1591: Missing XML comment for publicly visible type or member 'IRepository<T>.FindById(long, params string[])' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(113,32): warning CS1591: Missing XML comment for publicly visible type or member 'IRepository<T>.Restore(T)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(114,32): warning CS1591: Missing XML comment for publicly visible type or member 'IRepository<T>.Restore(long)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IRepository.cs(116,32): warning CS1591: Missing XML comment for publicly visible type or member 'IRepository<T>.Update(T, long?)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IContext.cs(6,22): warning CS1591: Missing XML comment for publicly visible type or member 'IContext' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IContext.cs(8,29): warning CS1591: Missing XML comment for publicly visible type or member 'IContext.Add<T>(T)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IContext.cs(9,29): warning CS1591: Missing XML comment for publicly visible type or member 'IContext.CreateStructure()' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IContext.cs(10,29): warning CS1591: Missing XML comment for publicly visible type or member 'IContext.DeleteDatabase()' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IContext.cs(11,29): warning CS1591: Missing XML comment for publicly visible type or member 'IContext.Delete<T>(T)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IContext.cs(12,29): warning CS1591: Missing XML comment for publicly visible type or member 'IContext.DetectChanges()' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IContext.cs(13,29): warning CS1591: Missing XML comment for publicly visible type or member 'IContext.DropStructure()' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IContext.cs(14,29): warning CS1591: Missing XML comment for publicly visible type or member 'IContext.ExecuteCommand(string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IContext.cs(15,29): warning CS1591: Missing XML comment for publicly visible type or member 'IContext.Query<T>()' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IContext.cs(16,29): warning CS1591: Missing XML comment for publicly visible type or member 'IContext.SaveChanges()' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Data\IContext.cs(17,29): warning CS1591: Missing XML comment for publicly visible type or member 'IContext.Update<T>(T)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\IAuditable.cs(3,22): warning CS1591: Missing XML comment for publicly visible type or member 'IAuditable' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\ICreatable.cs(5,22): warning CS1591: Missing XML comment for publicly visible type or member 'ICreatable' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\ICreatable.cs(7,25): warning CS1591: Missing XML comment for publicly visible type or member 'ICreatable.CreatedById' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\ICreatable.cs(8,25): warning CS1591: Missing XML comment for publicly visible type or member 'ICreatable.CreatedOn' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\IDeletable.cs(5,22): warning CS1591: Missing XML comment for publicly visible type or member 'IDeletable' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\IDeletable.cs(7,25): warning CS1591: Missing XML comment for publicly visible type or member 'IDeletable.DeletedById' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\IDeletable.cs(8,25): warning CS1591: Missing XML comment for publicly visible type or member 'IDeletable.DeletedOn' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\IEntity.cs(3,22): warning CS1591: Missing XML comment for publicly visible type or member 'IEntity' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\IEntity.cs(5,14): warning CS1591: Missing XML comment for publicly visible type or member 'IEntity.Id' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\ILockable.cs(5,22): warning CS1591: Missing XML comment for publicly visible type or member 'ILockable' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\ILockable.cs(7,14): warning CS1591: Missing XML comment for publicly visible type or member 'ILockable.IsLocked' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\ILockable.cs(8,15): warning CS1591: Missing XML comment for publicly visible type or member 'ILockable.LockedById' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\ILockable.cs(9,25): warning CS1591: Missing XML comment for publicly visible type or member 'ILockable.LockedOn' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\ILockable.cs(10,25): warning CS1591: Missing XML comment for publicly visible type or member 'ILockable.LockedUntil' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\IUpdatable.cs(5,22): warning CS1591: Missing XML comment for publicly visible type or member 'IUpdatable' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\IUpdatable.cs(7,25): warning CS1591: Missing XML comment for publicly visible type or member 'IUpdatable.UpdatedById' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Entity\IUpdatable.cs(8,25): warning CS1591: Missing XML comment for publicly visible type or member 'IUpdatable.UpdatedOn' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Errors\IError.cs(5,22): warning CS1591: Missing XML comment for publicly visible type or member 'IError' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Errors\IError.cs(7,19): warning CS1591: Missing XML comment for publicly visible type or member 'IError.ErrorType' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Errors\IError.cs(8,19): warning CS1591: Missing XML comment for publicly visible type or member 'IError.Key' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Errors\IError.cs(9,19): warning CS1591: Missing XML comment for publicly visible type or member 'IError.Message' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Errors\IResult.cs(5,22): warning CS1591: Missing XML comment for publicly visible type or member 'IResult<T>' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Hosting\IAndcultureCodeWebHostBuilder.cs(5,22): warning CS1591: Missing XML comment for publicly visible type or member 'IAndcultureCodeWebHostBuilder' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Localization\ICulture.cs(6,22): warning CS1591: Missing XML comment for publicly visible type or member 'ICulture' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Localization\ICulture.cs(25,34): warning CS1591: Missing XML comment for publicly visible type or member 'ICulture.CultureTranslations' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Providers\IWorkerProvider.cs(56,9): warning CS1587: XML comment is not placed on a valid language element [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Providers\IWorkerProvider.cs(48,9): warning CS1587: XML comment is not placed on a valid language element [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Security\IAcl.cs(6,22): warning CS1591: Missing XML comment for publicly visible type or member 'IAcl' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Security\IAcl.cs(8,20): warning CS1591: Missing XML comment for publicly visible type or member 'IAcl.Permission' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Security\IAcl.cs(9,16): warning CS1591: Missing XML comment for publicly visible type or member 'IAcl.Resource' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Security\IAcl.cs(10,16): warning CS1591: Missing XML comment for publicly visible type or member 'IAcl.Subject' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Providers\IEmailProvider.cs(22,9): warning CS1587: XML comment is not placed on a valid language element [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Interfaces\Providers\IEmailProvider.cs(27,9): warning CS1587: XML comment is not placed on a valid language element [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]

Add or fix comments as needed to reduce the number of warnings.

/// <summary>
/// TODO https://github.com/AndcultureCode/AndcultureCode.CSharp.Core/issues/38
/// </summary>
/// <param name="key"></param>
/// <param name="value"></param>
public void Add(TKey key, TValue value)
...

Since there are so many warnings, feel free to pick off as many or as few as you'd like to take on.

Port Issues and PRs from AndcultureCode.CSharp.Conductors

Move Open Issues and PRs over from AndcultureCode.CSharp.Conductors. Then Mark Repo as Archived

Add Async variants to IRepository and repository conductor interfaces

As to not leave current projects stranded without a working implementation, please attempt to have our primary use case of SqlServer (rsm-hcd/AndcultureCode.CSharp.Data.SqlServer#5) ready to go before tackling this issue.

Per the issue above, we have an immediate use case with GraphQL data loaders that could leverage having async variants of our various IRepository and repository conductor interfaces.

Methods like...

// IRepository.cs
Task<IResult<IList<T>>> FindAllCommittedAsync(...);
Task<IResult<T>> FindByIdAsync(long id);

Merge AndcultureCode.CSharp.Conductors into AndCulture.CSharp

Add/fix XML doc comments for Models

See warning list from a recent build:

Models\Auditable.cs(7,27): warning CS1591: Missing XML comment for publicly visible type or member 'Auditable' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Auditable.cs(11,32): warning CS1591: Missing XML comment for publicly visible type or member 'Auditable.CreatedById' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Auditable.cs(12,32): warning CS1591: Missing XML comment for publicly visible type or member 'Auditable.CreatedOn' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Auditable.cs(13,32): warning CS1591: Missing XML comment for publicly visible type or member 'Auditable.DeletedById' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Auditable.cs(14,32): warning CS1591: Missing XML comment for publicly visible type or member 'Auditable.DeletedOn' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Auditable.cs(15,32): warning CS1591: Missing XML comment for publicly visible type or member 'Auditable.UpdatedById' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Auditable.cs(16,32): warning CS1591: Missing XML comment for publicly visible type or member 'Auditable.UpdatedOn' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\OrderedList.cs(5,18): warning CS1591: Missing XML comment for publicly visible type or member 'OrderedList<TKey, TValue>' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\OrderedList.cs(15,16): warning CS1591: Missing XML comment for publicly visible type or member 'OrderedList<TKey, TValue>.OrderedList()' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\OrderedList.cs(20,16): warning CS1591: Missing XML comment for publicly visible type or member 'OrderedList<TKey, TValue>.OrderedList(IComparer<TKey>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\OrderedList.cs(29,21): warning CS1591: Missing XML comment for publicly visible type or member 'OrderedList<TKey, TValue>.Add(TKey, TValue)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\OrderedList.cs(40,21): warning CS1591: Missing XML comment for publicly visible type or member 'OrderedList<TKey, TValue>.Remove(TKey, TValue)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\OrderedList.cs(73,36): warning CS1591: Missing XML comment for publicly visible type or member 'OrderedList<TKey, TValue>.GetEnumerator()' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\OrderedList.cs(88,21): warning CS1591: Missing XML comment for publicly visible type or member 'OrderedList<TKey, TValue>.ContainsKey(TKey)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\OrderedList.cs(90,34): warning CS1591: Missing XML comment for publicly visible type or member 'OrderedList<TKey, TValue>.Keys' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\OrderedList.cs(94,21): warning CS1591: Missing XML comment for publicly visible type or member 'OrderedList<TKey, TValue>.TryGetValue(TKey, out ICollection<TValue>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\OrderedList.cs(98,36): warning CS1591: Missing XML comment for publicly visible type or member 'OrderedList<TKey, TValue>.this[TKey]' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\OrderedList.cs(110,21): warning CS1591: Missing XML comment for publicly visible type or member 'OrderedList<TKey, TValue>.Clear()' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\OrderedList.cs(117,20): warning CS1591: Missing XML comment for publicly visible type or member 'OrderedList<TKey, TValue>.Count' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\OrderedList.cs(119,21): warning CS1591: Missing XML comment for publicly visible type or member 'OrderedList<TKey, TValue>.IsReadOnly' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\ReverseComparer.cs(5,18): warning CS1591: Missing XML comment for publicly visible type or member 'ReverseComparer<TKey>' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\ReverseComparer.cs(15,16): warning CS1591: Missing XML comment for publicly visible type or member 'ReverseComparer<TKey>.ReverseComparer()' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\ReverseComparer.cs(17,16): warning CS1591: Missing XML comment for publicly visible type or member 'ReverseComparer<TKey>.ReverseComparer(IComparer<TKey>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Collections\ReverseComparer.cs(26,20): warning CS1591: Missing XML comment for publicly visible type or member 'ReverseComparer<TKey>.Compare(TKey, TKey)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Configuration\DataConfiguration.cs(8,26): warning CS1591: Missing XML comment for publicly visible type or member 'DataConfiguration.EMAIL_LENGTH' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Configuration\DataConfiguration.cs(16,26): warning CS1591: Missing XML comment for publicly visible type or member 'DataConfiguration.EXTRA_SHORT_STRING_LENGTH' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Configuration\DataConfiguration.cs(17,26): warning CS1591: Missing XML comment for publicly visible type or member 'DataConfiguration.LONG_DESCRIPTION_LENGTH' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Configuration\DataConfiguration.cs(18,26): warning CS1591: Missing XML comment for publicly visible type or member 'DataConfiguration.SHORT_DESCRIPTION_LENGTH' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Configuration\DataConfiguration.cs(19,26): warning CS1591: Missing XML comment for publicly visible type or member 'DataConfiguration.SHORT_STRING_LENGTH' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Configuration\DataConfiguration.cs(20,26): warning CS1591: Missing XML comment for publicly visible type or member 'DataConfiguration.SHORT_TITLE_LENGTH' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Entities\Acls\Acl.cs(6,18): warning CS1591: Missing XML comment for publicly visible type or member 'Acl' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Entities\Acls\Acl.cs(8,27): warning CS1591: Missing XML comment for publicly visible type or member 'Acl.Permission' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Entities\Acls\Acl.cs(9,23): warning CS1591: Missing XML comment for publicly visible type or member 'Acl.Resource' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Entities\Acls\Acl.cs(10,23): warning CS1591: Missing XML comment for publicly visible type or member 'Acl.Subject' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Entities\Acls\Acl.cs(11,23): warning CS1591: Missing XML comment for publicly visible type or member 'Acl.Verb' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Entities\Entity.cs(5,27): warning CS1591: Missing XML comment for publicly visible type or member 'Entity' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Entities\Entity.cs(7,21): warning CS1591: Missing XML comment for publicly visible type or member 'Entity.Id' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Workers\RecurringOption.cs(11,20): warning CS1591: Missing XML comment for publicly visible type or member 'RecurringOption.Day' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Workers\RecurringOption.cs(12,26): warning CS1591: Missing XML comment for publicly visible type or member 'RecurringOption.DayOfWeek' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Workers\RecurringOption.cs(13,20): warning CS1591: Missing XML comment for publicly visible type or member 'RecurringOption.Hour' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Workers\RecurringOption.cs(14,20): warning CS1591: Missing XML comment for publicly visible type or member 'RecurringOption.Minute' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Workers\RecurringOption.cs(15,20): warning CS1591: Missing XML comment for publicly visible type or member 'RecurringOption.Month' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Workers\RecurringOption.cs(16,27): warning CS1591: Missing XML comment for publicly visible type or member 'RecurringOption.Recurrence' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\Error.cs(6,18): warning CS1591: Missing XML comment for publicly visible type or member 'Error' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\Error.cs(8,26): warning CS1591: Missing XML comment for publicly visible type or member 'Error.ErrorType' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\Error.cs(9,26): warning CS1591: Missing XML comment for publicly visible type or member 'Error.Key' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\Error.cs(10,26): warning CS1591: Missing XML comment for publicly visible type or member 'Error.Message' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\PagedResult.cs(7,18): warning CS1591: Missing XML comment for publicly visible type or member 'PagedResult<T>' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\PagedResult.cs(11,43): warning CS1591: Missing XML comment for publicly visible type or member 'PagedResult<T>.ErrorCount' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\PagedResult.cs(12,43): warning CS1591: Missing XML comment for publicly visible type or member 'PagedResult<T>.Errors' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\PagedResult.cs(13,43): warning CS1591: Missing XML comment for publicly visible type or member 'PagedResult<T>.HasErrors' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\PagedResult.cs(14,43): warning CS1591: Missing XML comment for publicly visible type or member 'PagedResult<T>.NextLinkParams' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\PagedResult.cs(15,43): warning CS1591: Missing XML comment for publicly visible type or member 'PagedResult<T>.ResultObject' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\PagedResult.cs(16,43): warning CS1591: Missing XML comment for publicly visible type or member 'PagedResult<T>.RowCount' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\PagedResult.cs(23,16): warning CS1591: Missing XML comment for publicly visible type or member 'PagedResult<T>.PagedResult(T, long)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\PagedResult.cs(24,16): warning CS1591: Missing XML comment for publicly visible type or member 'PagedResult<T>.PagedResult(T, long, Dictionary<string, string>)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\Result.cs(8,18): warning CS1591: Missing XML comment for publicly visible type or member 'Result<T>' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\Result.cs(12,51): warning CS1591: Missing XML comment for publicly visible type or member 'Result<T>.ErrorCount' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\Result.cs(13,51): warning CS1591: Missing XML comment for publicly visible type or member 'Result<T>.Errors' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\Result.cs(14,51): warning CS1591: Missing XML comment for publicly visible type or member 'Result<T>.HasErrors' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\Result.cs(15,51): warning CS1591: Missing XML comment for publicly visible type or member 'Result<T>.NextLinkParams' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\Result.cs(16,51): warning CS1591: Missing XML comment for publicly visible type or member 'Result<T>.ResultObject' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\Result.cs(23,16): warning CS1591: Missing XML comment for publicly visible type or member 'Result<T>.Result()' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\Result.cs(24,16): warning CS1591: Missing XML comment for publicly visible type or member 'Result<T>.Result(string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\Result.cs(25,16): warning CS1591: Missing XML comment for publicly visible type or member 'Result<T>.Result(string, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Errors\Result.cs(26,16): warning CS1591: Missing XML comment for publicly visible type or member 'Result<T>.Result(T)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Hosting\AndcultureCodeWebHostBuilder.cs(7,18): warning CS1591: Missing XML comment for publicly visible type or member 'AndcultureCodeWebHostBuilder' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Hosting\AndcultureCodeWebHostBuilder.cs(11,25): warning CS1591: Missing XML comment for publicly visible type or member 'AndcultureCodeWebHostBuilder.Args' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Hosting\AndcultureCodeWebHostBuilder.cs(18,16): warning CS1591: Missing XML comment for publicly visible type or member 'AndcultureCodeWebHostBuilder.AndcultureCodeWebHostBuilder()' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Hosting\AndcultureCodeWebHostBuilder.cs(19,16): warning CS1591: Missing XML comment for publicly visible type or member 'AndcultureCodeWebHostBuilder.AndcultureCodeWebHostBuilder(string[])' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Hosting\AndcultureCodeWebHostBuilder.cs(29,32): warning CS1591: Missing XML comment for publicly visible type or member 'AndcultureCodeWebHostBuilder.CreateDefaultBuilder()' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Localization\Culture.cs(13,27): warning CS1591: Missing XML comment for publicly visible type or member 'Culture' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Localization\Culture.cs(39,32): warning CS1591: Missing XML comment for publicly visible type or member 'Culture.Code' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Localization\Culture.cs(41,41): warning CS1591: Missing XML comment for publicly visible type or member 'Culture.CultureTranslations' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Localization\Culture.cs(79,29): warning CS1591: Missing XML comment for publicly visible type or member 'Culture.IsDefault' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Localization\CultureTranslation.cs(12,23): warning CS1591: Missing XML comment for publicly visible type or member 'CultureTranslation.CultureCode' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Lockable.cs(6,27): warning CS1591: Missing XML comment for publicly visible type or member 'Lockable' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Lockable.cs(12,22): warning CS1591: Missing XML comment for publicly visible type or member 'Lockable.LockedById' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Lockable.cs(13,32): warning CS1591: Missing XML comment for publicly visible type or member 'Lockable.LockedOn' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Lockable.cs(14,32): warning CS1591: Missing XML comment for publicly visible type or member 'Lockable.LockedUntil' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\AccessRule.cs(6,27): warning CS1591: Missing XML comment for publicly visible type or member 'AccessRule' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\AccessRule.cs(10,36): warning CS1591: Missing XML comment for publicly visible type or member 'AccessRule.Permission' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\AccessRule.cs(11,23): warning CS1591: Missing XML comment for publicly visible type or member 'AccessRule.Resource' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\AccessRule.cs(12,23): warning CS1591: Missing XML comment for publicly visible type or member 'AccessRule.Subject' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\AccessRule.cs(13,23): warning CS1591: Missing XML comment for publicly visible type or member 'AccessRule.Verb' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\AccessRule.cs(19,19): warning CS1591: Missing XML comment for publicly visible type or member 'AccessRule.AccessRule(string, string, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\Allow.cs(5,18): warning CS1591: Missing XML comment for publicly visible type or member 'Allow' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\Allow.cs(9,36): warning CS1591: Missing XML comment for publicly visible type or member 'Allow.Permission' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\Allow.cs(15,16): warning CS1591: Missing XML comment for publicly visible type or member 'Allow.Allow(string, string, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\Deny.cs(5,18): warning CS1591: Missing XML comment for publicly visible type or member 'Deny' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\Deny.cs(9,36): warning CS1591: Missing XML comment for publicly visible type or member 'Deny.Permission' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\Deny.cs(15,16): warning CS1591: Missing XML comment for publicly visible type or member 'Deny.Deny(string, string, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\ResourceVerb.cs(5,19): warning CS1591: Missing XML comment for publicly visible type or member 'ResourceVerb' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\ResourceVerb.cs(9,23): warning CS1591: Missing XML comment for publicly visible type or member 'ResourceVerb.Resource' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\ResourceVerb.cs(10,23): warning CS1591: Missing XML comment for publicly visible type or member 'ResourceVerb.Verb' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\ResourceVerb.cs(16,16): warning CS1591: Missing XML comment for publicly visible type or member 'ResourceVerb.ResourceVerb(string, string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\ResourceVerb.cs(22,16): warning CS1591: Missing XML comment for publicly visible type or member 'ResourceVerb.ResourceVerb(string)' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Models\Security\ResourceVerb.cs(39,32): warning CS1591: Missing XML comment for publicly visible type or member 'ResourceVerb.ToString()' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]

Add or fix comments as needed to reduce the number of warnings.

/// <summary>
/// TODO https://github.com/AndcultureCode/AndcultureCode.CSharp.Core/issues/38
/// </summary>
/// <param name="key"></param>
/// <param name="value"></param>
public void Add(TKey key, TValue value)
...

Since there are so many warnings, feel free to pick off as many or as few as you'd like to take on.

Backfill Tests for Culture

Coverage Report

public List<CultureTranslation> CultureTranslations

Port Open Issues and PRs over from AndcultureCode.CSharp.Extensions

Move Open Issues and PRs over from AndcultureCode.CSharp.Extensions. Then mark Repo as Archived

Port Open Issues and PRs from AndcultureCode.CSharp.Core

Move Open Issues and PRs over from AndcultureCode.CSharp.Core. Then Mark Repo as archived

Backfill tests for Do

Coverage report

public Do<T> Catch<TException>(Action<TException, IResult<T>> handler)
public Do<T> Finally(ILogger logger, Action<IResult<T>> workload)
public Do<T> Finally(Action<IResult<T>> workload) => Finally(logger: null, workload: workload);
public static Do<T> Try(ILogger logger, Func<IResult<T>,T> workload)
public static Do<T> Try(ILogger logger, uint retry, Func<IResult<T>,T> workload)
public static Do<T> TrySeed<TContext>(SeedsBase<TContext> seeds, Func<IResult<T>, T> workload, string seedName = null)

Simplify loading of factories by consumers

Factories defined by a project that is consuming this library do not get registered. The static constructor for BaseTest passes in the assembly information for this library to the method that registers factories so only factories defined in this library get registered. As a workaround I created a local base test class that inherits from BaseTest and has its own static constructor that calls into the LoadFactories method with the local assembly as a parameter. If this is the intended usage then I can add documentation around that. If not, I can start work on a refactor and any guidance would be appreciated because I quite honestly am not sure where to start.

Update AndcultureCode packages to latest

To address this issue, https://github.com/AndcultureCode/AndcultureCode.CSharp.Extensions/issues/49, the AndcultureCode.CSharp.Core package needs updated to the latest, but the tests currently fail because this (AndcultureCode.CSharp.Testing) package also needs updated to use latest AndcultureCode.CSharp.Core package to avoid circular packages references.

Add Conductors README section

This can be pulled from the previous Conductors repo.

Pull in ApiClaimTypes from Core once ported

See comment here: https://github.com/AndcultureCode/AndcultureCode.CSharp.Extensions/blob/d486155bbc40ab48b056f8c54b1075c2cbf017a5/src/AndcultureCode.CSharp.Extensions/Constants/ApiClaimTypes.cs#L3-L8

Once https://github.com/AndcultureCode/AndcultureCode.CSharp.Core/issues/62 is complete & published, let's pull it in here and remove the current implementation.

Add/fix XML doc comments for Enumerations

See warning list from a recent build:

Enumerations\Errors\ErrorType.cs(3,17): warning CS1591: Missing XML comment for publicly visible type or member 'ErrorType' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\Errors\ErrorType.cs(5,9): warning CS1591: Missing XML comment for publicly visible type or member 'ErrorType.Error' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\Errors\ErrorType.cs(6,9): warning CS1591: Missing XML comment for publicly visible type or member 'ErrorType.ValidationError' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\HttpVerb.cs(10,9): warning CS1591: Missing XML comment for publicly visible type or member 'HttpVerb.GET' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\HttpVerb.cs(11,9): warning CS1591: Missing XML comment for publicly visible type or member 'HttpVerb.DELETE' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\HttpVerb.cs(12,9): warning CS1591: Missing XML comment for publicly visible type or member 'HttpVerb.HEAD' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\HttpVerb.cs(13,9): warning CS1591: Missing XML comment for publicly visible type or member 'HttpVerb.PUT' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\JobStatus.cs(8,9): warning CS1591: Missing XML comment for publicly visible type or member 'JobStatus.Completed' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\JobStatus.cs(9,9): warning CS1591: Missing XML comment for publicly visible type or member 'JobStatus.Errored' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\JobStatus.cs(10,9): warning CS1591: Missing XML comment for publicly visible type or member 'JobStatus.InProgress' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\LogicalOperator.cs(8,9): warning CS1591: Missing XML comment for publicly visible type or member 'LogicalOperator.And' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\LogicalOperator.cs(9,9): warning CS1591: Missing XML comment for publicly visible type or member 'LogicalOperator.Or' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\Permission.cs(3,17): warning CS1591: Missing XML comment for publicly visible type or member 'Permission' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\Permission.cs(5,9): warning CS1591: Missing XML comment for publicly visible type or member 'Permission.Allow' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\Permission.cs(6,9): warning CS1591: Missing XML comment for publicly visible type or member 'Permission.Deny' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\Recurrence.cs(8,9): warning CS1591: Missing XML comment for publicly visible type or member 'Recurrence.Daily' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\Recurrence.cs(9,9): warning CS1591: Missing XML comment for publicly visible type or member 'Recurrence.Hourly' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\Recurrence.cs(10,9): warning CS1591: Missing XML comment for publicly visible type or member 'Recurrence.Minutely' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\Recurrence.cs(11,9): warning CS1591: Missing XML comment for publicly visible type or member 'Recurrence.Monthly' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\Recurrence.cs(12,9): warning CS1591: Missing XML comment for publicly visible type or member 'Recurrence.Weekly' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]
Enumerations\Recurrence.cs(13,9): warning CS1591: Missing XML comment for publicly visible type or member 'Recurrence.Yearly' [C:\Users\bscot\acc\origin\AndcultureCode.CSharp.Core\src\AndcultureCode.CSharp.Core\AndcultureCode.CSharp.Core.csproj]

Add or fix comments as needed to reduce the number of warnings.

/// <summary>
/// TODO https://github.com/AndcultureCode/AndcultureCode.CSharp.Core/issues/38
/// </summary>
/// <param name="key"></param>
/// <param name="value"></param>
public void Add(TKey key, TValue value)
...

Backfill tests for ACL related models

Coverage report

// ResourceVerb
public ResourceVerb(string resource, string verb)
public override string ToString()

Coverage report

// AccessRule
protected AccessRule(string resource, string verb, string subject)
bool IEquatable<AccessRule>.Equals(AccessRule other)

// RepositoryReadConductor.cs
public async Task<IResult<T>> FindByIdAsync(long id) => await _repository.FindByIdAsync(id);

rsm-hcd / andculturecode.csharp Goto Github PK

andculturecode.csharp's People

Contributors

Stargazers

Watchers

Forkers

andculturecode.csharp's Issues

Recommend Projects

Recommend Topics

Recommend Org