Port IncludeExtensions about andculturecode.csharp HOT 4 OPEN

@brandongregoryscott I'll take this one as well 👍

from andculturecode.csharp.

@brandongregoryscott @wintondeshong Upon looking into this, the IncludeExtensions in the LMS projects are off of our home-grown Include and IncludeBase models.

Am I safe to proceed by adding a task to the Core repo for those models, completing it, and then coming back to this task? If not please let me know what I should do to move forward.

EDIT:
I think it would be a better choice to add Include and IncludeBase to the Core project, along with its extensions so that we don't need to bring along the Core package along with the extensions package every time.

FINAL EDIT:
After discussing this with Bscott last night, be both came to the conclusion that this might best sit in an Infrastructure package so that you don't get the Include libraries with Core, as you may not be using EF at all at that point.

Let me know your thoughts!

from andculturecode.csharp.

@joshuapeters yeah, I'm okay with moving it to Core so long as it didn't bring EF along for the ride. Maybe my version of IncludeExtensions, Include and IncludeBase are old. I don't see any dependency on EF at least in those 3 classes. Mind sharing a snapshot of the file names that would all be ported?

// IncludeExtensions.cs
using System;
using System.Collections.Generic;
using System.Linq.Expressions;
using LMS.Business.Core.Models.Includes;
...

// Include.cs - no usings

// IncludeBase.cs - no usings

from andculturecode.csharp.

Transferred this since the classes don't have any requirement for EF, the only dependency is on the Include model which also makes sense to live in this Core repository.

from andculturecode.csharp.