I've added flow-coverage-report to my project. I'm using flow@0.38.0, and it's not con

BTW, my .flowconfig contains: <div class="snippet

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

[0.3.0] flow@0.38.0 reports unused suppression,about rpl/flow-coverage-report

Comments (3)

avaragado commented on June 12, 2024

BTW, my .flowconfig contains:

suppress_comment=.*\\$FLOW_FIXME

Without this line, [email protected] reports this:

node_modules/flow-coverage-report/src/lib/report-html.js:94
 94:         react.renderToStaticMarkup(new FlowCoverageHTMLReport({
                                        ^ prototype. This type is incompatible with the expected param type of
273:     element: React$Element<any>
                  ^^^^^^^^^^^^^^^^^^ React$Element. See lib: /private/tmp/flow/flowlib_1b0c2da7/react.js:273

node_modules/flow-coverage-report/src/lib/report-html.js:130
130:                 react.renderToStaticMarkup(new FlowCoverageHTMLReport({
                                                ^ prototype. This type is incompatible with the expected param type of
273:     element: React$Element<any>
                  ^^^^^^^^^^^^^^^^^^ React$Element. See lib: /private/tmp/flow/flowlib_1b0c2da7/react.js:273

If you changed your code to use the default $FlowFixMe (see suppress_comment in https://flowtype.org/docs/advanced-configuration.html) then you could remove both your suppress_comment lines from your .flowconfig, and I could remove my line too.

from flow-coverage-report.

rpl commented on June 12, 2024

@avaragado Thanks for reporting this issue!
I opted to update flow-bin and fix the issue related to the suppress comments (#25), which should fix the issue that you describe here.

I merged #25 on master (it is not yet released on npm, but in the meantime you can use the fixed version by switch the devDependencies to use the github repo).

from flow-coverage-report.

avaragado commented on June 12, 2024

Thanks!

from flow-coverage-report.

Recommend Projects