Git Product home page Git Product logo

Comments (9)

smirnowld avatar smirnowld commented on June 12, 2024 1

This can be closed now that 0.6.0 is released. I've tested it and it seems to work.

from flow-coverage-report.

zeorin avatar zeorin commented on June 12, 2024

I actually just submitted a PR for this: #150.

from flow-coverage-report.

zeorin avatar zeorin commented on June 12, 2024

Incidentally, using @flow strict-local doesn't cause an error.

from flow-coverage-report.

zeorin avatar zeorin commented on June 12, 2024

And that's because there's a bug in a dependency: ryan953/flow-annotation-check#55.

from flow-coverage-report.

benfjohnson avatar benfjohnson commented on June 12, 2024

Just left a comment on that PR 🙂. I'll plan on using @flow strict-local for now until your fix is merged. Cheers!

from flow-coverage-report.

ryan953 avatar ryan953 commented on June 12, 2024

I just pushed up v1.8.1-0 of flow-annotation-check, so give that a spin and see if that helps along with #150

from flow-coverage-report.

zeorin avatar zeorin commented on June 12, 2024

@ryan953 thanks for jumping on this so quickly! This works well in the coverage report of my updated PR:

┌──────────┬───────────────────┬─────────┬───────┬─────────┬───────────┐
│ filename │        annotation │ percent │ total │ covered │ uncovered │
│ index.js │ flow strict-local │   100 % │    13 │      13 │ 0         │
└──────────┴───────────────────┴─────────┴───────┴─────────┴───────────┘
┌─────────────────────────┬──────────────────────────────────────────┐
│ included glob patterns: │ **/*.js?(x)                              │
│ excluded glob patterns: │ node_modules/**, **/_book/**             │
│              threshold: │ 100                                      │
│       concurrent files: │ 4                                        │
│           generated at: │ Wed May 16 2018 11:29:00 GMT+0200 (SAST) │
│           flow version: │ 0.72.0                                   │
│      flow check passed: │ yes (0 errors)                           │
└─────────────────────────┴──────────────────────────────────────────┘
┌──────────────┬─────────┬───────┬─────────┬───────────┐
│ project      │ percent │ total │ covered │ uncovered │
│ my-framework │   100 % │    13 │      13 │         0 │
└──────────────┴─────────┴───────┴─────────┴───────────┘

from flow-coverage-report.

ryan953 avatar ryan953 commented on June 12, 2024

Cool, I just pushed that branch up to npm as v1.8.1 for merging.

from flow-coverage-report.

LoganBarnett avatar LoganBarnett commented on June 12, 2024

We just switched our codebase over to @flow strict and verified flow-coverage-report works great with it. Thanks!

from flow-coverage-report.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.