Comments (9)
This can be closed now that 0.6.0 is released. I've tested it and it seems to work.
from flow-coverage-report.
I actually just submitted a PR for this: #150.
from flow-coverage-report.
Incidentally, using @flow strict-local
doesn't cause an error.
from flow-coverage-report.
And that's because there's a bug in a dependency: ryan953/flow-annotation-check#55.
from flow-coverage-report.
Just left a comment on that PR 🙂. I'll plan on using @flow strict-local
for now until your fix is merged. Cheers!
from flow-coverage-report.
I just pushed up v1.8.1-0 of flow-annotation-check, so give that a spin and see if that helps along with #150
from flow-coverage-report.
@ryan953 thanks for jumping on this so quickly! This works well in the coverage report of my updated PR:
┌──────────┬───────────────────┬─────────┬───────┬─────────┬───────────┐
│ filename │ annotation │ percent │ total │ covered │ uncovered │
│ index.js │ flow strict-local │ 100 % │ 13 │ 13 │ 0 │
└──────────┴───────────────────┴─────────┴───────┴─────────┴───────────┘
┌─────────────────────────┬──────────────────────────────────────────┐
│ included glob patterns: │ **/*.js?(x) │
│ excluded glob patterns: │ node_modules/**, **/_book/** │
│ threshold: │ 100 │
│ concurrent files: │ 4 │
│ generated at: │ Wed May 16 2018 11:29:00 GMT+0200 (SAST) │
│ flow version: │ 0.72.0 │
│ flow check passed: │ yes (0 errors) │
└─────────────────────────┴──────────────────────────────────────────┘
┌──────────────┬─────────┬───────┬─────────┬───────────┐
│ project │ percent │ total │ covered │ uncovered │
│ my-framework │ 100 % │ 13 │ 13 │ 0 │
└──────────────┴─────────┴───────┴─────────┴───────────┘
from flow-coverage-report.
Cool, I just pushed that branch up to npm as v1.8.1 for merging.
from flow-coverage-report.
We just switched our codebase over to @flow strict
and verified flow-coverage-report
works great with it. Thanks!
from flow-coverage-report.
Related Issues (20)
- Exit process with 1 when Flow check fails? HOT 5
- Display coverage percent with decimals HOT 5
- Version 10 of node.js has been released
- Kill the Flow server after coverage report generation HOT 2
- doesn't output any files HOT 2
- Help with invoking coverage programatically
- Support higher coverage threshold precision HOT 2
- Should not fail annotation check if .flowconfig [options] all=true HOT 1
- Threshold option for max uncovered line count
- Sorting a long list in the web view is slow
- npm audit produces moderate severity vulnerability HOT 2
- Renamed Properties HOT 1
- Failing to Generate Coverage for Some Files HOT 2
- Meaning of 1x/2x/3x etc in HTML report HOT 1
- What is total, covered and uncovered. ? HOT 1
- Command Injection in Dot package dependency in npm audit security report
- Does not work when server is started in lazy mode
- CVE-2021-3803 via badge-up / svgo / css-select HOT 1
- bable-eslint is depracated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flow-coverage-report.