Comments (5)
Ok, I did a PR (#158) for the default behaviour, but will add a config/cli option when I have some time.
from flow-coverage-report.
Any update here, @rpl?
from flow-coverage-report.
@migueloller Since @rpl doesn't seem to have a look at the issues, I have forked the project and implemented the exit code for flow: https://github.com/fintory/flow-coverage-report
from flow-coverage-report.
@iduuck, that looks great! Thanks for taking the initiative 😄
I'm not sure how responsive @rpl is to PRs but I'm sure it would be helpful if you submit one with the changes done in fintory@9c4a38c. You can likely just setup a branch, cherry-pick that commit and submit the PR. It'll get my +1 for sure!
from flow-coverage-report.
@migueloller @iduuck I personally prefer to have a flow-check npm script that fails when there are flowtype errors and leave the report generator to only fail because the coverage is lower than the desired threshold.
But I'm not against supporting the behavior described in #147 (comment) and I would be more than happy on integrating it as an additional configurable behavior (enabled by an additional cli/config option, instead of being the default behavior, and possibly guarded by a new test case to prevent the new option and related behavior from regressing in the future, the modules around the cli argument parsing based on yargs are unfortunately the parts on which the flow coverage is lower and so, a bit ironically :-P, flow doesn't help a lot there).
from flow-coverage-report.
Related Issues (20)
- Display coverage percent with decimals HOT 5
- Version 10 of node.js has been released
- `flow-coverage-report` should work with `// @flow strict` declaration HOT 9
- Kill the Flow server after coverage report generation HOT 2
- doesn't output any files HOT 2
- Help with invoking coverage programatically
- Support higher coverage threshold precision HOT 2
- Should not fail annotation check if .flowconfig [options] all=true HOT 1
- Threshold option for max uncovered line count
- Sorting a long list in the web view is slow
- npm audit produces moderate severity vulnerability HOT 2
- Renamed Properties HOT 1
- Failing to Generate Coverage for Some Files HOT 2
- Meaning of 1x/2x/3x etc in HTML report HOT 1
- What is total, covered and uncovered. ? HOT 1
- Command Injection in Dot package dependency in npm audit security report
- Does not work when server is started in lazy mode
- CVE-2021-3803 via badge-up / svgo / css-select HOT 1
- bable-eslint is depracated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flow-coverage-report.