Annotation wrong when pragma is defined on the same comment line about flow-coverage-report HOT 6 CLOSED

@karolisgrinkevicius the parsing of the @flow pragma is handled by the flow-annotation-check and so I'm pretty sure that we have to fix this issue in the upstream package and update the dependencies once the fix has been released.

@ryan953 what do you think about this issue?

from flow-coverage-report.

@rpl you are absolutely correct.

@ryan953 I think regex in https://github.com/ryan953/flow-annotation-check/blob/master/src/promisified.js#L17 has to be modified by ignoring any annotation following @ except flow. Maybe there's a better way to solve it.

from flow-coverage-report.

@karolisgrinkevicius the bit that detects the annotation is over here: src/flow.js and here's where flow parses the headers: src/parsing/parsing_service_js.ml

Since I can't read that ml code well, a quick check confirms that flow-annotation-check is too strict and flow itself will find multiple annotations on one line:

So we need a PR, I can put something up tonight

from flow-coverage-report.

@ryan953 you are awesome. Thanks m8.

from flow-coverage-report.

@rpl please review #136.

from flow-coverage-report.

Thanks @karolisgrinkevicius and @ryan953 for your help to quickly fix this issue!
fixed in 798607d (and new integration test added in 30b6ae4)
released on npm as bugfix minor release 0.4.1 🎉

from flow-coverage-report.