Add indication of whether files include the @flow annotation about flow-coverage-report HOT 5 CLOSED

@ryan953 That's a good point

and it looks like the flow ast command can provide some help to extract this information in a more reliable way, e.g.:

$ flow ast test.js
{
  "type" : "Program",
  "body" : [
  ....
  ],
  "comments" : [{
     "range" : [0, 16],
     "loc" : { ... },
     "type" : "Block",
     "value" : " @flow weak "
  } ]
}

from flow-coverage-report.

I started looking at that AST too :).

Flow adds some extra logic to only check the first 9 lines for @flow and other comments/statements. I'm not Sure about all the syntax but checkout https://github.com/facebook/flow/blob/d2930e135f9c34a89a226c2ca36eb4bcab7b59db/src/parsing/docblock.ml for where the limits are.

I think it would be better for flow itself to report the status along with all the files it sees, maybe as an addition to 'flow ls'. HHVM supports this with one of the 'hh' commands.
In the mean time though a method to validate existing @flow annotations would be cool, could even be reused as a lint rule and maybe more.

from flow-coverage-report.

FWIW, it would be useful to also have a flag that will run the coverage report only on files that have the @flow pragma.

from flow-coverage-report.

It would also be useful if the coverage test could ignore files that don't have the // @flow designation because they are not ready to be tested yet.

from flow-coverage-report.

Fixed by #27 (merged as #55)

In the current form it reports the flow preamble annotations but doesn't change the behavior of the coverage return status (and how the coverage totals are computed).
In follow ups issues we can define a different behavior (and related cli options) as being discussed in the comments of this issue and #27.

from flow-coverage-report.