Git Product home page Git Product logo

Comments (4)

tfoote avatar tfoote commented on July 24, 2024

I'm not sure it would make sense to implement the Clock class without the jump support. Otherwise users won't be able to know that time has skipped when the clock has changed. The class is trivial enough that the jump API and ability to pump it from a time source are important for confirming that the API is set that I'd rather not try to review just the simpler API/structure before the higher level functions are confirmed to work.

The timer should have a clock associated with it to test for how long has elapsed. It's ticketed in rclcpp here: ros2/rclcpp#465

from rclpy.

Nickolaim avatar Nickolaim commented on July 24, 2024

I see. I don’t feel comfortable I can have it implemented in reasonable time. I will pass on this ticket.

What’s the right process? Just close this issue? Your original ticket still has all the tasks.

from rclpy.

tfoote avatar tfoote commented on July 24, 2024

Since we have the other ticket with the tracking info we could close this out. If you do find some time in the future this could be a good place to come back to. You could also start the implementation of the clock, but we just wouldn't plan to merge it until the other parts were implemented.

from rclpy.

Nickolaim avatar Nickolaim commented on July 24, 2024

Thanks!

from rclpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.