Check return value of Python functions that can fail about rclpy HOT 9 CLOSED

@sloretz Hello, I'm new to open source and love working with ros. How can I approach this issue?

from rclpy.

I would like to help with this one @sloretz should I proceed?

from rclpy.

First time contributing to open source and interested in learning more about how to fix this issue.

from rclpy.

Hi @db118 ,

This issue is about checking error codes of python functions. Here is an example of error checking done correctly: PyArg_ParseTuple(...) can fail, and if it does the function should return NULL right away.

Here is an example of what should be fixed: PyList_New() can set an exception and return NULL, so pylist needs to be checked before calling PyList_SET_ITEM() with it.

A good first PR would fix one instance of a function that can fail not being checked.

from rclpy.

@sloretz Ahhh that make sense. Also I don't see a requirements.txt. Is there certain python libraries I need to get this up and running.

from rclpy.

@sloretz
Do you want me to switch this null error checking

to this implementation instead

from rclpy.

@db118 See the section "Building from source" for instructions to build this library. It lists the dependencies, as well as shows how to build the other ros 2 packages this one depends on. Once you've built everything once, you can build and test just this backage with colcon build --packages-select rclpy and colcon test --event-handlers console_direct+ --packages-select rclpy.

I don't think I understand the question about swtiching NULL error checking; both of those look fine to me.

from rclpy.

Given our recent switch to pybind11 (which gets completed with #814), I actually think this issue is mostly obsolete. @sloretz what do you think? Should we just close this one out?

from rclpy.

Yup, this one can be closed 🎉

from rclpy.