Comments (5)
Sounds good -- PRs are always welcome!
I do wonder if it wouldn't make more sense to package the shiny app components as a separate package though? I'd be happy to re-import the methods here if that's helpful. The shiny app code so far has all been community-contributed!
from eml.
It might indeed make sense to separate it, but its pretty convenient where it is. Some folks at NCEAS that were doing a lot of data curation with this module contributed it here for convenience. But as a UI function its pretty different from the other functions. I could also see this being a really helpful RStudio extension package.
Adding the annotation fields looks like a great idea. We have some other work on providing annotations in EML via R and via web interfaces, and so it would be great to get perspectives from @amoeba, @jeanetteclark, @laijasmine, and @samanthacsik about what would be helpful here.
from eml.
I think at the moment it would be great to integrate this with the package right now as the Arctic Data Center team will really benefit from this. The current infrastructure makes it difficult to edit attributes without losing all the annotations as @BrennieDev described above with the get_attributes()
-> shiny_attributes()
-> set_attributes()
workflow. I don't know if there are many cases where we would ever use shiny_attributes
without the rest of the EML
functions for us.
from eml.
In the meantime, I've created a PR anyone can take a look at to see the changes (should be pretty straightforward but let me know of any questions/concerns):
#319
from eml.
Closed with merge of PR #319
from eml.
Related Issues (20)
- set_attributes forces all numeric fields to have storageType = "float" HOT 7
- Taxonomic Coverage and bibtex HOT 1
- Species name epithet is not handled the way specified in the EML schema HOT 2
- Error with molePerKilogram in unit list returned by get_unitList() HOT 3
- dataset and datatable entries from README example fail HOT 2
- `shiny_attributes` performance improvments HOT 8
- Revisit how users can find a learn to use the `eml$*` constructors HOT 2
- Add a minimum version requirement on taxadb and wait to release the next version of this package HOT 1
- Web scraping | sapply function | Error in readBin(5L, "raw", 65536L) : Failure when receiving data from the peer HOT 1
- Creating EML elements with XML attributes HOT 2
- Duplicate person when using `write_eml()` HOT 2
- Set attributes for properties, e.g. `<title xml:lang="eng">` HOT 3
- Function to convert DataCite metadata to EML: good fit for this package? HOT 7
- `<![CDATA[` not always recognized HOT 1
- [Units] Discussion about current unit list HOT 5
- `set_coverage()`: Express common names in `commonName` in `taxonomicCoverage` HOT 10
- `set_responsibleParty()`: allow to create organization parties HOT 1
- namespace conflict introduced when importing/exporting EML generated under older schema
- EML::eml_validate conflicts with knb.ecoinformatics.org parser & appears to introduce invalid xml into valid files HOT 1
- EML seems to have trouble with foreign key constraints HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eml.