Git Product home page Git Product logo

Comments (2)

cboettig avatar cboettig commented on July 18, 2024 1

@laijasmine Thanks, good point. I think the better behavior here when given a list of scientific names would be to not split, like you say, but also omit the nested structure, which is just noise. it should be:

if (is.character(sci_names) && !expand) {
  taxa <- lapply(strsplit(sci_names, " "), function(s) {
    list(
      taxonRankName = "Species",
      taxonRankValue = s
    )

anyway. Ideally this would also support giving <Genus> <specificEpithet> <intraSpecificEpithet> as the "Species" name as well.

I think when giving the full classification, it would make sense to follow Darwin Core terms for rank levels, and list the specific epithet as specificEpithet (which should indeed not include the Genus name), and avoid the use of a rank of species (which doesn't exist in darwin core).

(Really I think the choice to define hierarchical ranks as nested instead of rank-value pairs was less than ideal anyway, but oh well!)

Thanks much for a PR!

from eml.

laijasmine avatar laijasmine commented on July 18, 2024

resolved in PR #329

from eml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.