Git Product home page Git Product logo

Comments (3)

earnaud avatar earnaud commented on July 18, 2024

Here is a picture of the two units causing the issue. The description row seems to be invalid with the second unit. Also, this second unit has no description.

image

from eml.

earnaud avatar earnaud commented on July 18, 2024

Hi again !
I corrected some of the values returned by EML::get_unitList(). It concerns mainly the multiplicated units (e.g. millimeter) but also the wordly uncommon values (e.g. feet, inches). I added a unitType to those units, matching their base type despite of their mutiplier.
I think this can greatly help to find the correct desired unit.

EMLunits.csv

from eml.

amoeba avatar amoeba commented on July 18, 2024

Hi @earnaud, thanks for reporting. The two molePerKilogram units does seem like a mistake. This package is largely the result of code-gen from the EML standard so the issue(s) you're seeing originate from there. Any fix could then be propagated to this package with a new release.

It sounds like from #330 (comment) that you found other issues. Is it easy to summarize them here? If not, I can go through your CSV and cross-reference things.

from eml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.