Git Product home page Git Product logo

Comments (8)

rollbear avatar rollbear commented on July 30, 2024 1

I see that MSVC also complains for the same reason. This is tricky. I'll see what I can do.

from trompeloeil.

AndrewPaxie avatar AndrewPaxie commented on July 30, 2024 1

@rollbear: I have seen the conversion warning from GCC before, as reported here: https://godbolt.org/z/zrsdvrhKf .

I'll check my working notes from a couple of years ago and see if the strategy applied then can be reused (sadly I seem to recall it required a rewrite of client code). I also have a new idea to try in the next day or so, and will report success or failure following the experiment.

from trompeloeil.

TimonNoethlichs avatar TimonNoethlichs commented on July 30, 2024

I tried to simplify the problem and I got nothing, but some curiosities:

  1. Removing both const qualifier makes GCC also fail:
  • from the Variant constructor parameter
  • from the Wildcard conversion operator
  1. clang also fails Variant variant = wildcard;
  2. MSVC, however, compiles it.

struct Variant 
{
    template <typename T> 
    Variant(const T&) 
    {}
};

struct Wildcard 
{
    template<typename T>
    operator T() 
    const
    {
        return *this;
    }
};

void func(Variant) { };

int main() 
{
    Wildcard wildcard{};
    
    Variant variant = wildcard;

    func(wildcard);

    return 0;
}

https://godbolt.org/z/bfh5Mj61h

from trompeloeil.

rollbear avatar rollbear commented on July 30, 2024

I can make your example work, but at the cost of reintroducing other old bugs instead. Hopefully I'll find something, but it may take a while.

from trompeloeil.

rollbear avatar rollbear commented on July 30, 2024

Some progress, but not yet there.

This works, but it gives a conversion warning with gcc, which I am not OK with.

https://godbolt.org/z/zrsdvrhKf

So far no success in getting rid of that warning without breaking things even more.

from trompeloeil.

TimonNoethlichs avatar TimonNoethlichs commented on July 30, 2024

Thank you very much! I integrated your fix explicitly for clang using "#ifdef clang" and left the original for gcc. I hope you find a better solution that makes you happy :).

from trompeloeil.

AndrewPaxie avatar AndrewPaxie commented on July 30, 2024

I was hoping ref-qualification (& and &&) of the conversion operators was going to restrict their application, but it created more issues (interesting issues!) and solved no issues. Perhaps they are exactly the reverse of what's needed. Still investigating.

from trompeloeil.

rollbear avatar rollbear commented on July 30, 2024

I have failed to find a better solution, so going with this and suppressing the -Wconversion warning on gcc. Not entirely happy about this. Leaving the issue open until a release has been tagged.

from trompeloeil.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.