Warnings with gcc's -Weffc++ about trompeloeil HOT 9 OPEN

Hmm. I am unable to reproduce this. Where's the difference between your code and my attempt?

https://godbolt.org/z/Escx468z9

from trompeloeil.

Hm. Can't reproduce it on godbolt as well, did you try my CMake project?

from trompeloeil.

Perhaps try the following:

docker run --rm -it dockcross/linux-x64 bash
git clone https://github.com/svenihoney/trompeloeil-effcpp.git
cmake -B build -S trompeloeil-effcpp/
cmake --build build

and you will get the error.

from trompeloeil.

I understand where the problem comes from, I was just baffled that my "obvious" reproduction didn't reproduce it and wondered if you could see a mistake.

from trompeloeil.

Can you try branch Weffc and see if it has resolved your issues?

The warnings about uninitialized member variables are, IMO, incorrect. They are non-trivial types with default constructors that are run at object creation time. Maybe something worth reporting to gcc?

The warnings about default generated operator= were potential bugs, had any future change happened to accidentally call them, so thanks for those.

from trompeloeil.

No, wait, I spoke too soon. The fix doesn't work with older C++ standards... 😞

from trompeloeil.

Now the CI pipeline went green for all compilers and standards. Phiew.

from trompeloeil.