revrobotics / color-sensor-v3 Goto Github PK

For the file ColorSensorV3.java there is an issue with the enum declarations.
The enums which are used by the public configure methods (e.g. configureColorSensor(ColorSensorResolution res, ColorSensorMeasurementRate rate, GainFactor gain) are declared with default visibility but should be public. Default visibility restricts them to use within the same package (com.revrobotics).

The following code fails to compile because the package is not part of com.revrobotics

package frc.robot;

import edu.wpi.first.wpilibj.TimedRobot;
import edu.wpi.first.wpilibj.I2C;
import com.revrobotics.ColorSensorV3;

public class Robot extends TimedRobot {
ColorSensorV3 m_sensor;

public Robot() {
m_sensor = new ColorSensorV3(I2C.Port.kOnboard);
m_sensor.configureColorSensor(ColorSensorV3.ColorSensorResolution.kColorSensorRes16bit,
ColorSensorV3.ColorSensorMeasurementRate.kColorRate50ms,
ColorSensorV3.GainFactor.kGain1x);
}
}

If the delcarations in ColorSensorV3.java are changed from

enum ColorSensorResolution { ...
to
public enum ColorSensorResolution { ...

the code will compile.

The enums aren't public and they are only visible in the package.

We would like to use ColorSensorResolution and ProximitySensorMeasurementRate enums in our code but they are not public in the current release.

Can the WPILib GradleRIO vendordeps JSON file (http://www.revrobotics.com/content/sw/color-sensor-v3/sdk/REVColorSensorV3.json) be updated with the latest code so we can access these enums?

Similar to this method, but public: https://github.com/REVrobotics/Color-Sensor-v3/blob/master/src/main/java/com/revrobotics/ColorSensorV3.java#L397