Git Product home page Git Product logo

redis / lettuce Goto Github PK

View Code? Open in Web Editor NEW
5.3K 5.3K 939.0 21.32 MB

Advanced Java Redis client for thread-safe sync, async, and reactive usage. Supports Cluster, Sentinel, Pipelining, and codecs.

Home Page: https://lettuce.io

License: MIT License

Java 94.69% Makefile 0.23% Shell 0.06% HTML 0.01% CSS 0.61% Kotlin 4.40%
asynchronous aws-elasticache azure-redis-cache java reactive redis redis-client redis-cluster redis-sentinel

lettuce's Introduction

This README is just a fast quick start document. You can find more detailed documentation at redis.io.

What is Redis?

Redis is often referred to as a data structures server. What this means is that Redis provides access to mutable data structures via a set of commands, which are sent using a server-client model with TCP sockets and a simple protocol. So different processes can query and modify the same data structures in a shared way.

Data structures implemented into Redis have a few special properties:

  • Redis cares to store them on disk, even if they are always served and modified into the server memory. This means that Redis is fast, but that it is also non-volatile.
  • The implementation of data structures emphasizes memory efficiency, so data structures inside Redis will likely use less memory compared to the same data structure modelled using a high-level programming language.
  • Redis offers a number of features that are natural to find in a database, like replication, tunable levels of durability, clustering, and high availability.

Another good example is to think of Redis as a more complex version of memcached, where the operations are not just SETs and GETs, but operations that work with complex data types like Lists, Sets, ordered data structures, and so forth.

If you want to know more, this is a list of selected starting points:

Building Redis

Redis can be compiled and used on Linux, OSX, OpenBSD, NetBSD, FreeBSD. We support big endian and little endian architectures, and both 32 bit and 64 bit systems.

It may compile on Solaris derived systems (for instance SmartOS) but our support for this platform is best effort and Redis is not guaranteed to work as well as in Linux, OSX, and *BSD.

It is as simple as:

% make

To build with TLS support, you'll need OpenSSL development libraries (e.g. libssl-dev on Debian/Ubuntu) and run:

% make BUILD_TLS=yes

To build with systemd support, you'll need systemd development libraries (such as libsystemd-dev on Debian/Ubuntu or systemd-devel on CentOS) and run:

% make USE_SYSTEMD=yes

To append a suffix to Redis program names, use:

% make PROG_SUFFIX="-alt"

You can build a 32 bit Redis binary using:

% make 32bit

After building Redis, it is a good idea to test it using:

% make test

If TLS is built, running the tests with TLS enabled (you will need tcl-tls installed):

% ./utils/gen-test-certs.sh
% ./runtest --tls

Fixing build problems with dependencies or cached build options

Redis has some dependencies which are included in the deps directory. make does not automatically rebuild dependencies even if something in the source code of dependencies changes.

When you update the source code with git pull or when code inside the dependencies tree is modified in any other way, make sure to use the following command in order to really clean everything and rebuild from scratch:

% make distclean

This will clean: jemalloc, lua, hiredis, linenoise and other dependencies.

Also if you force certain build options like 32bit target, no C compiler optimizations (for debugging purposes), and other similar build time options, those options are cached indefinitely until you issue a make distclean command.

Fixing problems building 32 bit binaries

If after building Redis with a 32 bit target you need to rebuild it with a 64 bit target, or the other way around, you need to perform a make distclean in the root directory of the Redis distribution.

In case of build errors when trying to build a 32 bit binary of Redis, try the following steps:

  • Install the package libc6-dev-i386 (also try g++-multilib).
  • Try using the following command line instead of make 32bit: make CFLAGS="-m32 -march=native" LDFLAGS="-m32"

Allocator

Selecting a non-default memory allocator when building Redis is done by setting the MALLOC environment variable. Redis is compiled and linked against libc malloc by default, with the exception of jemalloc being the default on Linux systems. This default was picked because jemalloc has proven to have fewer fragmentation problems than libc malloc.

To force compiling against libc malloc, use:

% make MALLOC=libc

To compile against jemalloc on Mac OS X systems, use:

% make MALLOC=jemalloc

Monotonic clock

By default, Redis will build using the POSIX clock_gettime function as the monotonic clock source. On most modern systems, the internal processor clock can be used to improve performance. Cautions can be found here: http://oliveryang.net/2015/09/pitfalls-of-TSC-usage/

To build with support for the processor's internal instruction clock, use:

% make CFLAGS="-DUSE_PROCESSOR_CLOCK"

Verbose build

Redis will build with a user-friendly colorized output by default. If you want to see a more verbose output, use the following:

% make V=1

Running Redis

To run Redis with the default configuration, just type:

% cd src
% ./redis-server

If you want to provide your redis.conf, you have to run it using an additional parameter (the path of the configuration file):

% cd src
% ./redis-server /path/to/redis.conf

It is possible to alter the Redis configuration by passing parameters directly as options using the command line. Examples:

% ./redis-server --port 9999 --replicaof 127.0.0.1 6379
% ./redis-server /etc/redis/6379.conf --loglevel debug

All the options in redis.conf are also supported as options using the command line, with exactly the same name.

Running Redis with TLS:

Please consult the TLS.md file for more information on how to use Redis with TLS.

Playing with Redis

You can use redis-cli to play with Redis. Start a redis-server instance, then in another terminal try the following:

% cd src
% ./redis-cli
redis> ping
PONG
redis> set foo bar
OK
redis> get foo
"bar"
redis> incr mycounter
(integer) 1
redis> incr mycounter
(integer) 2
redis>

You can find the list of all the available commands at https://redis.io/commands.

Installing Redis

In order to install Redis binaries into /usr/local/bin, just use:

% make install

You can use make PREFIX=/some/other/directory install if you wish to use a different destination.

make install will just install binaries in your system, but will not configure init scripts and configuration files in the appropriate place. This is not needed if you just want to play a bit with Redis, but if you are installing it the proper way for a production system, we have a script that does this for Ubuntu and Debian systems:

% cd utils
% ./install_server.sh

Note: install_server.sh will not work on Mac OSX; it is built for Linux only.

The script will ask you a few questions and will setup everything you need to run Redis properly as a background daemon that will start again on system reboots.

You'll be able to stop and start Redis using the script named /etc/init.d/redis_<portnumber>, for instance /etc/init.d/redis_6379.

Code contributions

By contributing code to the Redis project in any form, including sending a pull request via GitHub, a code fragment or patch via private email or public discussion groups, you agree to release your code under the terms of the Redis Software Grant and Contributor License Agreement. Redis software contains contributions to the original Redis core project, which are owned by their contributors and licensed under the 3BSD license. Any copy of that license in this repository applies only to those contributions. Redis releases all Redis project versions from 7.4.x and thereafter under the RSALv2/SSPL dual-license as described in the LICENSE.txt file included in the Redis source distribution.

Please see the CONTRIBUTING.md file in this source distribution for more information. For security bugs and vulnerabilities, please see SECURITY.md.

Redis Trademarks

The purpose of a trademark is to identify the goods and services of a person or company without causing confusion. As the registered owner of its name and logo, Redis accepts certain limited uses of its trademarks but it has requirements that must be followed as described in its Trademark Guidelines available at: https://redis.com/legal/trademark-guidelines/.

Redis internals

If you are reading this README you are likely in front of a Github page or you just untarred the Redis distribution tar ball. In both the cases you are basically one step away from the source code, so here we explain the Redis source code layout, what is in each file as a general idea, the most important functions and structures inside the Redis server and so forth. We keep all the discussion at a high level without digging into the details since this document would be huge otherwise and our code base changes continuously, but a general idea should be a good starting point to understand more. Moreover most of the code is heavily commented and easy to follow.

Source code layout

The Redis root directory just contains this README, the Makefile which calls the real Makefile inside the src directory and an example configuration for Redis and Sentinel. You can find a few shell scripts that are used in order to execute the Redis, Redis Cluster and Redis Sentinel unit tests, which are implemented inside the tests directory.

Inside the root are the following important directories:

  • src: contains the Redis implementation, written in C.
  • tests: contains the unit tests, implemented in Tcl.
  • deps: contains libraries Redis uses. Everything needed to compile Redis is inside this directory; your system just needs to provide libc, a POSIX compatible interface and a C compiler. Notably deps contains a copy of jemalloc, which is the default allocator of Redis under Linux. Note that under deps there are also things which started with the Redis project, but for which the main repository is not redis/redis.

There are a few more directories but they are not very important for our goals here. We'll focus mostly on src, where the Redis implementation is contained, exploring what there is inside each file. The order in which files are exposed is the logical one to follow in order to disclose different layers of complexity incrementally.

Note: lately Redis was refactored quite a bit. Function names and file names have been changed, so you may find that this documentation reflects the unstable branch more closely. For instance, in Redis 3.0 the server.c and server.h files were named redis.c and redis.h. However the overall structure is the same. Keep in mind that all the new developments and pull requests should be performed against the unstable branch.

server.h

The simplest way to understand how a program works is to understand the data structures it uses. So we'll start from the main header file of Redis, which is server.h.

All the server configuration and in general all the shared state is defined in a global structure called server, of type struct redisServer. A few important fields in this structure are:

  • server.db is an array of Redis databases, where data is stored.
  • server.commands is the command table.
  • server.clients is a linked list of clients connected to the server.
  • server.master is a special client, the master, if the instance is a replica.

There are tons of other fields. Most fields are commented directly inside the structure definition.

Another important Redis data structure is the one defining a client. In the past it was called redisClient, now just client. The structure has many fields, here we'll just show the main ones:

struct client {
    int fd;
    sds querybuf;
    int argc;
    robj **argv;
    redisDb *db;
    int flags;
    list *reply;
    // ... many other fields ...
    char buf[PROTO_REPLY_CHUNK_BYTES];
}

The client structure defines a connected client:

  • The fd field is the client socket file descriptor.
  • argc and argv are populated with the command the client is executing, so that functions implementing a given Redis command can read the arguments.
  • querybuf accumulates the requests from the client, which are parsed by the Redis server according to the Redis protocol and executed by calling the implementations of the commands the client is executing.
  • reply and buf are dynamic and static buffers that accumulate the replies the server sends to the client. These buffers are incrementally written to the socket as soon as the file descriptor is writable.

As you can see in the client structure above, arguments in a command are described as robj structures. The following is the full robj structure, which defines a Redis object:

struct redisObject {
    unsigned type:4;
    unsigned encoding:4;
    unsigned lru:LRU_BITS; /* LRU time (relative to global lru_clock) or
                            * LFU data (least significant 8 bits frequency
                            * and most significant 16 bits access time). */
    int refcount;
    void *ptr;
};

Basically this structure can represent all the basic Redis data types like strings, lists, sets, sorted sets and so forth. The interesting thing is that it has a type field, so that it is possible to know what type a given object has, and a refcount, so that the same object can be referenced in multiple places without allocating it multiple times. Finally the ptr field points to the actual representation of the object, which might vary even for the same type, depending on the encoding used.

Redis objects are used extensively in the Redis internals, however in order to avoid the overhead of indirect accesses, recently in many places we just use plain dynamic strings not wrapped inside a Redis object.

server.c

This is the entry point of the Redis server, where the main() function is defined. The following are the most important steps in order to startup the Redis server.

  • initServerConfig() sets up the default values of the server structure.
  • initServer() allocates the data structures needed to operate, setup the listening socket, and so forth.
  • aeMain() starts the event loop which listens for new connections.

There are two special functions called periodically by the event loop:

  1. serverCron() is called periodically (according to server.hz frequency), and performs tasks that must be performed from time to time, like checking for timed out clients.
  2. beforeSleep() is called every time the event loop fired, Redis served a few requests, and is returning back into the event loop.

Inside server.c you can find code that handles other vital things of the Redis server:

  • call() is used in order to call a given command in the context of a given client.
  • activeExpireCycle() handles eviction of keys with a time to live set via the EXPIRE command.
  • performEvictions() is called when a new write command should be performed but Redis is out of memory according to the maxmemory directive.
  • The global variable redisCommandTable defines all the Redis commands, specifying the name of the command, the function implementing the command, the number of arguments required, and other properties of each command.

commands.c

This file is auto generated by utils/generate-command-code.py, the content is based on the JSON files in the src/commands folder. These are meant to be the single source of truth about the Redis commands, and all the metadata about them. These JSON files are not meant to be used by anyone directly, instead that metadata can be obtained via the COMMAND command.

networking.c

This file defines all the I/O functions with clients, masters and replicas (which in Redis are just special clients):

  • createClient() allocates and initializes a new client.
  • The addReply*() family of functions are used by command implementations in order to append data to the client structure, that will be transmitted to the client as a reply for a given command executed.
  • writeToClient() transmits the data pending in the output buffers to the client and is called by the writable event handler sendReplyToClient().
  • readQueryFromClient() is the readable event handler and accumulates data read from the client into the query buffer.
  • processInputBuffer() is the entry point in order to parse the client query buffer according to the Redis protocol. Once commands are ready to be processed, it calls processCommand() which is defined inside server.c in order to actually execute the command.
  • freeClient() deallocates, disconnects and removes a client.

aof.c and rdb.c

As you can guess from the names, these files implement the RDB and AOF persistence for Redis. Redis uses a persistence model based on the fork() system call in order to create a process with the same (shared) memory content of the main Redis process. This secondary process dumps the content of the memory on disk. This is used by rdb.c to create the snapshots on disk and by aof.c in order to perform the AOF rewrite when the append only file gets too big.

The implementation inside aof.c has additional functions in order to implement an API that allows commands to append new commands into the AOF file as clients execute them.

The call() function defined inside server.c is responsible for calling the functions that in turn will write the commands into the AOF.

db.c

Certain Redis commands operate on specific data types; others are general. Examples of generic commands are DEL and EXPIRE. They operate on keys and not on their values specifically. All those generic commands are defined inside db.c.

Moreover db.c implements an API in order to perform certain operations on the Redis dataset without directly accessing the internal data structures.

The most important functions inside db.c which are used in many command implementations are the following:

  • lookupKeyRead() and lookupKeyWrite() are used in order to get a pointer to the value associated to a given key, or NULL if the key does not exist.
  • dbAdd() and its higher level counterpart setKey() create a new key in a Redis database.
  • dbDelete() removes a key and its associated value.
  • emptyData() removes an entire single database or all the databases defined.

The rest of the file implements the generic commands exposed to the client.

object.c

The robj structure defining Redis objects was already described. Inside object.c there are all the functions that operate with Redis objects at a basic level, like functions to allocate new objects, handle the reference counting and so forth. Notable functions inside this file:

  • incrRefCount() and decrRefCount() are used in order to increment or decrement an object reference count. When it drops to 0 the object is finally freed.
  • createObject() allocates a new object. There are also specialized functions to allocate string objects having a specific content, like createStringObjectFromLongLong() and similar functions.

This file also implements the OBJECT command.

replication.c

This is one of the most complex files inside Redis, it is recommended to approach it only after getting a bit familiar with the rest of the code base. In this file there is the implementation of both the master and replica role of Redis.

One of the most important functions inside this file is replicationFeedSlaves() that writes commands to the clients representing replica instances connected to our master, so that the replicas can get the writes performed by the clients: this way their data set will remain synchronized with the one in the master.

This file also implements both the SYNC and PSYNC commands that are used in order to perform the first synchronization between masters and replicas, or to continue the replication after a disconnection.

Script

The script unit is composed of 3 units:

  • script.c - integration of scripts with Redis (commands execution, set replication/resp, ...)
  • script_lua.c - responsible to execute Lua code, uses script.c to interact with Redis from within the Lua code.
  • function_lua.c - contains the Lua engine implementation, uses script_lua.c to execute the Lua code.
  • functions.c - contains Redis Functions implementation (FUNCTION command), uses functions_lua.c if the function it wants to invoke needs the Lua engine.
  • eval.c - contains the eval implementation using script_lua.c to invoke the Lua code.

Other C files

  • t_hash.c, t_list.c, t_set.c, t_string.c, t_zset.c and t_stream.c contains the implementation of the Redis data types. They implement both an API to access a given data type, and the client command implementations for these data types.
  • ae.c implements the Redis event loop, it's a self contained library which is simple to read and understand.
  • sds.c is the Redis string library, check https://github.com/antirez/sds for more information.
  • anet.c is a library to use POSIX networking in a simpler way compared to the raw interface exposed by the kernel.
  • dict.c is an implementation of a non-blocking hash table which rehashes incrementally.
  • cluster.c implements the Redis Cluster. Probably a good read only after being very familiar with the rest of the Redis code base. If you want to read cluster.c make sure to read the Redis Cluster specification.

Anatomy of a Redis command

All the Redis commands are defined in the following way:

void foobarCommand(client *c) {
    printf("%s",c->argv[1]->ptr); /* Do something with the argument. */
    addReply(c,shared.ok); /* Reply something to the client. */
}

The command function is referenced by a JSON file, together with its metadata, see commands.c described above for details. The command flags are documented in the comment above the struct redisCommand in server.h. For other details, please refer to the COMMAND command. https://redis.io/commands/command/

After the command operates in some way, it returns a reply to the client, usually using addReply() or a similar function defined inside networking.c.

There are tons of command implementations inside the Redis source code that can serve as examples of actual commands implementations (e.g. pingCommand). Writing a few toy commands can be a good exercise to get familiar with the code base.

There are also many other files not described here, but it is useless to cover everything. We just want to help you with the first steps. Eventually you'll find your way inside the Redis code base :-)

Enjoy!

lettuce's People

Contributors

atakavci avatar be-hase avatar dengliming avatar dmandalidis avatar dowenliu-xyz avatar gejun123456 avatar gkorland avatar hashzhang avatar hellyguo avatar jongyeol avatar jruaux avatar kichik avatar koisyu avatar larrybattle avatar mp911de avatar perlun avatar rohannagar avatar schnapster avatar sergey-ushakov avatar shikharid avatar sokomishalov avatar sullis avatar taer avatar tgrall avatar tishun avatar wg avatar worldtiki avatar yangbodong22011 avatar yueki1993 avatar zhangjessey avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

lettuce's Issues

API Fixes on 3.0

  • Add isOpen to sentinel connection
  • Fix clusterSlaves on sync cluster connection interfaces
  • Generalize syncHandler in AbstractRedisClient

Improve CRC16 calculation to use lookup table

Use an improved calculation.

The CRC16 is specified as follows:

  • Name: XMODEM (also known as ZMODEM or CRC-16/ACORN)
  • Width: 16 bit
  • Poly: 1021 (That is actually x16 + x12 + x5 + 1)
  • Initialization: 0000
  • Reflect Input byte: False
  • Reflect Output CRC: False
  • Xor constant to output CRC: 0000
  • Output for "123456789": 31C3

Handle absence of optional epoll library in a reasonable way

When a RedisURI is created without the epoll library on the class path the result is a ClassNotFoundError. This should be changed to:

  1. lettuce should work without epoll for regular operations
  2. Throw a qualified exception in case the user wants to use sockets but the library is not available

Change value datatype to long for PUBSUB NUMSUB output

Tests fail due to missing implementation of MapOutput.setInteger. Adjust map value datatype for PUBSUB NUMSUBcommand to Long.

java.lang.IllegalStateException
    at com.lambdaworks.redis.protocol.CommandOutput.set(CommandOutput.java:60)
    at com.lambdaworks.redis.protocol.RedisStateMachine.decode(RedisStateMachine.java:121)
    at com.lambdaworks.redis.protocol.CommandHandler.decode(CommandHandler.java:101)
    at com.lambdaworks.redis.protocol.CommandHandler.channelRead(CommandHandler.java:89)

NPE in MultiOutput when nested Output is null

java.lang.NullPointerException
    at com.lambdaworks.redis.output.MultiOutput.set(MultiOutput.java:48)
    at com.lambdaworks.redis.output.MultiOutput.set(MultiOutput.java:48)
    at com.lambdaworks.redis.protocol.RedisStateMachine.decode(RedisStateMachine.java:108)
    at com.lambdaworks.redis.protocol.CommandHandler.decode(CommandHandler.java:101)
    at com.lambdaworks.redis.protocol.CommandHandler.channelRead(CommandHandler.java:89)
    at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:341)
    at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:327)
    at io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelInboundHandlerAdapter.java:86)
    at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:341)

Memory leak

The following code works for a while but stops receiving messages very quickly. When run without the debugger, I actually get the following error messages:

15/01/09 21:36:50 WARN channel.DefaultChannelPipeline: An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception.
java.lang.OutOfMemoryError: Java heap space

To expedite the process I limit JVM memory with -Xmx32m. However, I first discovered this issue while running a production server with 6GB heap size. It was under very low load and received a small message every 20 seconds. At some point I noticed messages were not being delivered anymore and the logs threw the same OOM errors. A heap dump showed buffer in com.lambdaworks.redis.protocol.CommanHandler was a holding a contiguous 1GB array. It was trying to extend the buffer, but had no more huge contiguous blocks in the heap.

I am weirdly unable to reproduce the OOM in a debugger. However, when running in a debugger, I still do get the same issue with messages not being received after a while.

import java.util.Arrays;
import java.util.concurrent.ExecutionException;
import java.util.logging.Logger;

import com.lambdaworks.redis.RedisClient;
import com.lambdaworks.redis.RedisConnection;
import com.lambdaworks.redis.RedisURI;
import com.lambdaworks.redis.codec.Utf8StringCodec;
import com.lambdaworks.redis.pubsub.RedisPubSubConnectionImpl;
import com.lambdaworks.redis.pubsub.RedisPubSubListener;


public class LettuceMemoryLeak implements RedisPubSubListener<String, String>
{

    private static Logger LOGGER = Logger.getLogger( "LettuceMemoryLeak" );


    public static void main( String[] args ) throws InterruptedException, ExecutionException
    {
        RedisURI uri = RedisURI.Builder.sentinel( "localhost", 26379, "mymaster" ).build();
        RedisClient client = new RedisClient( uri );

        RedisPubSubConnectionImpl<String, String> subscriber = client.connectPubSub( new Utf8StringCodec() );
        subscriber.subscribe( "test" );
        subscriber.addListener( new LettuceMemoryLeak() );

        RedisConnection<String, String> publisher = client.connect( new Utf8StringCodec() );

        char[] chars = new char[8096];
        Arrays.fill( chars, 'a' );
        String str = new String( chars );

        while( true ) {
            publisher.publish( "test", str );
        }
    }


    @Override
    public void message( String channel, String message )
    {
        LOGGER.info( channel );
    }


    @Override
    public void message( String pattern, String channel, String message )
    {
    }


    @Override
    public void subscribed( String channel, long count )
    {
        LOGGER.info( "subscribed to " + channel + " " + count );
    }


    @Override
    public void psubscribed( String pattern, long count )
    {
    }


    @Override
    public void unsubscribed( String channel, long count )
    {
    }


    @Override
    public void punsubscribed( String pattern, long count )
    {
    }

}

I'll update this ticket once I have more information.

Provide a stateful redis connection and decouple sync/async API from connection resources

3.x code:

RedisConnection connection = client.connect();

4.x code:

StatefulRedisConnection stateful = client.connect();
RedisConnection connection = stateful.sync();

The other connect methods like connectAsync and connectSentinelAsync will remain unchanged.

Affected connect methods are:

  • RedisClient.connect (provides a StatefulRedisConnection)
  • RedisClient.connectPubSub (provides a StatefulRedisPubSubConnection)
  • RedisClusterClient.connect (provides a StatefulRedisClusterConnection)

New connect methods:

  • RedisClient.connectSentinel (provides a StatefulRedisSentinelConnection)

Enhance lettuce resilience

Generic exceptions (i.e. protocol exceptions, exceptions on callback to pubsub notifications) can lead to a defective internal state. It might be worth to provide a reconnect-on-exception functionality. This ticket needs further investigation and was opened due to #21

Allow reset on internal connection state

The internal state machine could run into an invalid state due to network failures, VM errors or unexpected/faulty Redis responses (i.e. version does not fit the Redis client).

This could be handled by closing the connection and reconnecting for getting a clear and defined state without any "backlog" on the TCP connection.

Provide an option to connect to Redis via Unix Domain Sockets

Having an option to connect to a local Redis via UDS would be nice to have. It's allegedly faster.
From: http://redis.io/topics/benchmarks

Depending on the platform, unix domain sockets can achieve around 50% more throughput than the TCP/IP loopback (on Linux for instance)

Netty supports UDS in 4.0.26
https://twitter.com/normanmaurer/status/573090616000843777

Additional info from chat

mostly adding a new schemes to RedisURI, say redis-socket and redis-sentinel-socket or something like that then upgrading to latest netty, adding the socket resolution and maybe some bootstrap options.

ERR MULTI calls can not be nested

my code:
public static void main(String[] args) throws Exception {
final RedisConnection<String, byte[]> sync = new RedisClient("10.58.52.60", 5021)
.connect(new BytesCodec());
sync.flushall();

     final CountDownLatch c = new CountDownLatch(1);
        new Thread(new Runnable() {
            public void run() {
                try {
                    c.await();
                } catch (InterruptedException e) {
                    // TODO Auto-generated catch block
                    e.printStackTrace();
                }
                sync.multi();
                sync.set("a", Thread.currentThread().getName().getBytes());
                sync.set("a1", Thread.currentThread().getName().getBytes());
                System.out.println(1234);
            }
        }).start();
        new Thread(new Runnable() {
            public void run() {
                try {
                    c.await();
                } catch (InterruptedException e) {
                    e.printStackTrace();
                }
                sync.multi();
                sync.set("a", Thread.currentThread().getName().getBytes());
                sync.set("a1", Thread.currentThread().getName().getBytes());
                sync.exec();
                System.out.println(5678);
            }
        }).start();

        c.countDown();


}

output:
Exception in thread "Thread-2" com.lambdaworks.redis.RedisCommandExecutionException: ERR MULTI calls can not be nested
at com.lambdaworks.redis.LettuceFutures.await(LettuceFutures.java:76)
at com.lambdaworks.redis.FutureSyncInvocationHandler.handleInvocation(FutureSyncInvocationHandler.java:59)
at com.google.common.reflect.AbstractInvocationHandler.invoke(AbstractInvocationHandler.java:87)
at $Proxy5.multi(Unknown Source)
at com.lambdaworks.redis.AsyncConnectionConcurrentTest$2.run(AsyncConnectionConcurrentTest.java:44)
at java.lang.Thread.run(Thread.java:662)
1234

RedisClusterConnection stops operation after .RedisCommandTimeoutException

Setup: current master checkout of 3.1-SNAPSHOT: One thread, which has a single RedisClusterConnection<String,String>

The thread does a hgetall in a loop. You want to force a timeout on this thread. Do so by placing a VM breakpoint(pause all threads) in Utf8StringCodec.decode(). Let this hang for a bit(60 seconds I believe is the default timeout)

Now, once you're sure you've expired the timeout, remove the breakpoint and resume the JVM. The command you paused will throw from
FutureSyncInvocationHandler:59 return LettuceFutures.await(command, timeout, unit);

It doesn't seem to occur on a normal RedisConnection.

This is as far as I have made it. What happens next is the original caller gets an exception, which is perfectly fine. However, future calls to hgetall on the same connection will now simply timeout.

! com.lambdaworks.redis.RedisCommandTimeoutException: Command timed out
! at com.lambdaworks.redis.LettuceFutures.await(LettuceFutures.java:68) ~[tanknew1.jar:na]
! at com.lambdaworks.redis.FutureSyncInvocationHandler.handleInvocation(FutureSyncInvocationHandler.java:59) ~[tanknew1.jar:na]
! at com.lambdaworks.com.google.common.reflect.AbstractInvocationHandler.invoke(AbstractInvocationHandler.java:87) ~[tanknew1.jar:na]
! at com.sun.proxy.$Proxy95.hgetall(Unknown Source) ~[na:na]

Additional info: The pause all threads didn't seem to matter. I updated to just pause the single thread in the decode, and it broke the same way.

That was how to reproduce the error. Here is all I've managed to dig up so far.

Did a Thread dump. I have numerous requests blocked waiting for lock on
com.lambdaworks.redis.RedisAsyncConnectionImpl.dispatch()

The guy who has that monitor is blocked on
at com.lambdaworks.redis.protocol.Command.get(Command.java:109)
which is a CountDownLatch.await()

Expose futures of re-subscription on reconnect

RedisPubSubConnectionImpl re-subscribes to patterns and channels on reconnects but these futures are not accessible. Adding a protected List<RedisFuture<Void>> resubscribe() will allow accessing these futures.

Change build environment to JDK8

Use JDK8 for build but still support Java 6 and 7. Depends on JavaDoc compatibility with Java 8 #39 and requires to have a test project in order to ensure lettuce usage on JDK6/7/8

JavaDoc compatibility with Java 8

Rework JavaDocs for Java8 compatibility:

[ERROR] Exit code: 1 - javadoc: warning - Error fetching URL: http://netty.io/4.0/api
[ERROR] javadoc: warning - Error fetching URL: http://commons.apache.org/proper/commons-pool/api-2.2
[ERROR] javadoc: warning - Error fetching URL: http://docs.guava-libraries.googlecode.com/git/javadoc
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/codec/CRC16.java:48: warning: no description for @param
[ERROR] * @param bytes
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/AbstractRedisClient.java:216: error: unterminated inline tag
[ERROR] * @param listener must not be {@literal null
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/BaseRedisAsyncConnection.java:47: warning: no description for @param
[ERROR] * @param channels
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/BaseRedisAsyncConnection.java:92: warning: no description for @param
[ERROR] * @param script
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/BaseRedisAsyncConnection.java:139: warning: no description for @param
[ERROR] * @param replicas
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/BaseRedisAsyncConnection.java:140: warning: no description for @param
[ERROR] * @param timeout
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/BaseRedisConnection.java:46: warning: no description for @param
[ERROR] * @param channels
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/BaseRedisConnection.java:69: error: semicolon missing
[ERROR] * @return List&lt;Object&gt array-reply where the first element is one of master, slave, sentinel and the additional
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/BaseRedisConnection.java:91: warning: no description for @param
[ERROR] * @param script
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/BaseRedisConnection.java:137: warning: no description for @param
[ERROR] * @param replicas
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/BaseRedisConnection.java:138: warning: no description for @param
[ERROR] * @param timeout
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/ScanCursor.java:24: warning: no description for @param
[ERROR] * @param cursor
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/ScanCursor.java:45: warning: no description for @param
[ERROR] * @param cursor
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/KeyValue.java:18: warning: no description for @param
[ERROR] * @param key
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/KeyValue.java:19: warning: no description for @param
[ERROR] * @param value
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/LettuceFutures.java:65: warning: no @param for <K>
[ERROR] public static <K, V, T> T await(RedisCommand<K, V, T> cmd, long timeout, TimeUnit unit) {
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/LettuceFutures.java:65: warning: no @param for <V>
[ERROR] public static <K, V, T> T await(RedisCommand<K, V, T> cmd, long timeout, TimeUnit unit) {
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/LettuceFutures.java:65: warning: no @param for <T>
[ERROR] public static <K, V, T> T await(RedisCommand<K, V, T> cmd, long timeout, TimeUnit unit) {
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/LettuceStrings.java:4: error: bad use of '>'
[ERROR] * @author <a href="mailto:[email protected]">Mark Paluch</a>>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisAsyncConnection.java:21: warning: no description for @param
[ERROR] * @param timeout
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisAsyncConnection.java:22: warning: no description for @param
[ERROR] * @param unit
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisAsyncConnection.java:29: warning: no description for @param
[ERROR] * @param db
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisAsyncConnection.java:37: warning: no description for @param
[ERROR] * @param password
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:196: warning: no @param for key
[ERROR] RedisFuture<MapScanCursor<K, V>> hscan(K key);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:196: warning: no @return
[ERROR] RedisFuture<MapScanCursor<K, V>> hscan(K key);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:201: warning: no @param for key
[ERROR] RedisFuture<MapScanCursor<K, V>> hscan(K key, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:201: warning: no @param for scanArgs
[ERROR] RedisFuture<MapScanCursor<K, V>> hscan(K key, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:201: warning: no @return
[ERROR] RedisFuture<MapScanCursor<K, V>> hscan(K key, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:206: warning: no @param for key
[ERROR] RedisFuture<MapScanCursor<K, V>> hscan(K key, ScanCursor scanCursor, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:206: warning: no @param for scanCursor
[ERROR] RedisFuture<MapScanCursor<K, V>> hscan(K key, ScanCursor scanCursor, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:206: warning: no @param for scanArgs
[ERROR] RedisFuture<MapScanCursor<K, V>> hscan(K key, ScanCursor scanCursor, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:206: warning: no @return
[ERROR] RedisFuture<MapScanCursor<K, V>> hscan(K key, ScanCursor scanCursor, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:211: warning: no @param for key
[ERROR] RedisFuture<MapScanCursor<K, V>> hscan(K key, ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:211: warning: no @param for scanCursor
[ERROR] RedisFuture<MapScanCursor<K, V>> hscan(K key, ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:211: warning: no @return
[ERROR] RedisFuture<MapScanCursor<K, V>> hscan(K key, ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:216: warning: no @param for channel
[ERROR] RedisFuture<StreamScanCursor> hscan(KeyValueStreamingChannel<K, V> channel, K key);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:216: warning: no @param for key
[ERROR] RedisFuture<StreamScanCursor> hscan(KeyValueStreamingChannel<K, V> channel, K key);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:216: warning: no @return
[ERROR] RedisFuture<StreamScanCursor> hscan(KeyValueStreamingChannel<K, V> channel, K key);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:221: warning: no @param for channel
[ERROR] RedisFuture<StreamScanCursor> hscan(KeyValueStreamingChannel<K, V> channel, K key, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:221: warning: no @param for key
[ERROR] RedisFuture<StreamScanCursor> hscan(KeyValueStreamingChannel<K, V> channel, K key, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:221: warning: no @param for scanArgs
[ERROR] RedisFuture<StreamScanCursor> hscan(KeyValueStreamingChannel<K, V> channel, K key, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:221: warning: no @return
[ERROR] RedisFuture<StreamScanCursor> hscan(KeyValueStreamingChannel<K, V> channel, K key, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:231: warning: no @return
[ERROR] RedisFuture<StreamScanCursor> hscan(KeyValueStreamingChannel<K, V> channel, K key, ScanCursor scanCursor, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:236: warning: no @param for channel
[ERROR] RedisFuture<StreamScanCursor> hscan(KeyValueStreamingChannel<K, V> channel, K key, ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:236: warning: no @param for key
[ERROR] RedisFuture<StreamScanCursor> hscan(KeyValueStreamingChannel<K, V> channel, K key, ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:236: warning: no @param for scanCursor
[ERROR] RedisFuture<StreamScanCursor> hscan(KeyValueStreamingChannel<K, V> channel, K key, ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisHashesAsyncConnection.java:236: warning: no @return
[ERROR] RedisFuture<StreamScanCursor> hscan(KeyValueStreamingChannel<K, V> channel, K key, ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:132: warning: no description for @param
[ERROR] * @param key
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:140: warning: no description for @param
[ERROR] * @param key
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:244: warning: no @param for key
[ERROR] RedisFuture<List<V>> sort(K key);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:251: warning: no @param for channel
[ERROR] RedisFuture<Long> sort(ValueStreamingChannel<V> channel, K key);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:251: warning: no @param for key
[ERROR] RedisFuture<Long> sort(ValueStreamingChannel<V> channel, K key);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:258: warning: no @param for key
[ERROR] RedisFuture<List<V>> sort(K key, SortArgs sortArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:258: warning: no @param for sortArgs
[ERROR] RedisFuture<List<V>> sort(K key, SortArgs sortArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:265: warning: no @param for channel
[ERROR] RedisFuture<Long> sort(ValueStreamingChannel<V> channel, K key, SortArgs sortArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:265: warning: no @param for key
[ERROR] RedisFuture<Long> sort(ValueStreamingChannel<V> channel, K key, SortArgs sortArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:265: warning: no @param for sortArgs
[ERROR] RedisFuture<Long> sort(ValueStreamingChannel<V> channel, K key, SortArgs sortArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:290: warning: no @return
[ERROR] RedisFuture<KeyScanCursor<K>> scan();
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:295: warning: no @param for scanArgs
[ERROR] RedisFuture<KeyScanCursor<K>> scan(ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:295: warning: no @return
[ERROR] RedisFuture<KeyScanCursor<K>> scan(ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:300: warning: no @param for scanCursor
[ERROR] RedisFuture<KeyScanCursor<K>> scan(ScanCursor scanCursor, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:300: warning: no @param for scanArgs
[ERROR] RedisFuture<KeyScanCursor<K>> scan(ScanCursor scanCursor, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:300: warning: no @return
[ERROR] RedisFuture<KeyScanCursor<K>> scan(ScanCursor scanCursor, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:305: warning: no @param for scanCursor
[ERROR] RedisFuture<KeyScanCursor<K>> scan(ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:305: warning: no @return
[ERROR] RedisFuture<KeyScanCursor<K>> scan(ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:310: warning: no @param for channel
[ERROR] RedisFuture<StreamScanCursor> scan(KeyStreamingChannel<K> channel);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:310: warning: no @return
[ERROR] RedisFuture<StreamScanCursor> scan(KeyStreamingChannel<K> channel);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:315: warning: no @param for channel
[ERROR] RedisFuture<StreamScanCursor> scan(KeyStreamingChannel<K> channel, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:315: warning: no @param for scanArgs
[ERROR] RedisFuture<StreamScanCursor> scan(KeyStreamingChannel<K> channel, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:315: warning: no @return
[ERROR] RedisFuture<StreamScanCursor> scan(KeyStreamingChannel<K> channel, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:320: warning: no description for @param
[ERROR] * @param channel
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:322: warning: no description for @param
[ERROR] * @param scanArgs
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:324: warning: no @return
[ERROR] RedisFuture<StreamScanCursor> scan(KeyStreamingChannel<K> channel, ScanCursor scanCursor, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:329: warning: no @param for channel
[ERROR] RedisFuture<StreamScanCursor> scan(KeyStreamingChannel<K> channel, ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:329: warning: no @param for scanCursor
[ERROR] RedisFuture<StreamScanCursor> scan(KeyStreamingChannel<K> channel, ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisKeysAsyncConnection.java:329: warning: no @return
[ERROR] RedisFuture<StreamScanCursor> scan(KeyStreamingChannel<K> channel, ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:208: warning: no @param for key
[ERROR] RedisFuture<ValueScanCursor<V>> sscan(K key);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:208: warning: no @return
[ERROR] RedisFuture<ValueScanCursor<V>> sscan(K key);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:213: warning: no @param for key
[ERROR] RedisFuture<ValueScanCursor<V>> sscan(K key, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:213: warning: no @param for scanArgs
[ERROR] RedisFuture<ValueScanCursor<V>> sscan(K key, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:213: warning: no @return
[ERROR] RedisFuture<ValueScanCursor<V>> sscan(K key, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:218: warning: no @param for key
[ERROR] RedisFuture<ValueScanCursor<V>> sscan(K key, ScanCursor scanCursor, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:218: warning: no @param for scanCursor
[ERROR] RedisFuture<ValueScanCursor<V>> sscan(K key, ScanCursor scanCursor, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:218: warning: no @param for scanArgs
[ERROR] RedisFuture<ValueScanCursor<V>> sscan(K key, ScanCursor scanCursor, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:218: warning: no @return
[ERROR] RedisFuture<ValueScanCursor<V>> sscan(K key, ScanCursor scanCursor, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:223: warning: no @param for key
[ERROR] RedisFuture<ValueScanCursor<V>> sscan(K key, ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:223: warning: no @param for scanCursor
[ERROR] RedisFuture<ValueScanCursor<V>> sscan(K key, ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:223: warning: no @return
[ERROR] RedisFuture<ValueScanCursor<V>> sscan(K key, ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:228: warning: no @param for channel
[ERROR] RedisFuture<StreamScanCursor> sscan(ValueStreamingChannel<V> channel, K key);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:228: warning: no @param for key
[ERROR] RedisFuture<StreamScanCursor> sscan(ValueStreamingChannel<V> channel, K key);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:228: warning: no @return
[ERROR] RedisFuture<StreamScanCursor> sscan(ValueStreamingChannel<V> channel, K key);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:233: warning: no @param for channel
[ERROR] RedisFuture<StreamScanCursor> sscan(ValueStreamingChannel<V> channel, K key, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:233: warning: no @param for key
[ERROR] RedisFuture<StreamScanCursor> sscan(ValueStreamingChannel<V> channel, K key, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:233: warning: no @param for scanArgs
[ERROR] RedisFuture<StreamScanCursor> sscan(ValueStreamingChannel<V> channel, K key, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:233: warning: no @return
[ERROR] RedisFuture<StreamScanCursor> sscan(ValueStreamingChannel<V> channel, K key, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:238: warning: no description for @param
[ERROR] * @param channel
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:241: warning: no description for @param
[ERROR] * @param scanArgs
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:243: warning: no @return
[ERROR] RedisFuture<StreamScanCursor> sscan(ValueStreamingChannel<V> channel, K key, ScanCursor scanCursor, ScanArgs scanArgs);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:248: warning: no @param for channel
[ERROR] RedisFuture<StreamScanCursor> sscan(ValueStreamingChannel<V> channel, K key, ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisSetsAsyncConnection.java:248: warning: no @param for key
[ERROR] RedisFuture<StreamScanCursor> sscan(ValueStreamingChannel<V> channel, K key, ScanCursor scanCursor);
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisChannelHandler.java:158: error: malformed HTML
[ERROR] * @return RedisChannelWriter<K, V>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisChannelHandler.java:158: error: bad use of '>'
[ERROR] * @return RedisChannelWriter<K, V>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisChannelWriter.java:21: error: malformed HTML
[ERROR] * @return RedisCommand<K, V, T>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisChannelWriter.java:21: error: bad use of '>'
[ERROR] * @return RedisCommand<K, V, T>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisClient.java:111: error: malformed HTML
[ERROR] * @return RedisConnectionPool<RedisConnection<K, V>>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisClient.java:111: error: malformed HTML
[ERROR] * @return RedisConnectionPool<RedisConnection<K, V>>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisClient.java:111: error: bad use of '>'
[ERROR] * @return RedisConnectionPool<RedisConnection<K, V>>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisClient.java:111: error: bad use of '>'
[ERROR] * @return RedisConnectionPool<RedisConnection<K, V>>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisListsConnection.java:22: error: malformed HTML
[ERROR] * @return KeyValue<K,V> array-reply specifically:
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisListsConnection.java:22: error: bad use of '>'
[ERROR] * @return KeyValue<K,V> array-reply specifically:
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisListsConnection.java:35: error: malformed HTML
[ERROR] * @return KeyValue<K,V> array-reply specifically:
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/RedisListsConnection.java:35: error: bad use of '>'
[ERROR] * @return KeyValue<K,V> array-reply specifically:
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/ScriptOutputType.java:13: error: text not allowed in <ul> element
[ERROR] * <li>{@link #MULTI} of these types</li>.
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/ScriptOutputType.java:20: error: bad use of '>'
[ERROR] * <li>Redis integer reply -> Lua number</li>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/ScriptOutputType.java:21: error: bad use of '>'
[ERROR] * <li>Redis bulk reply -> Lua string</li>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/ScriptOutputType.java:22: error: bad use of '>'
[ERROR] * <li>Redis multi bulk reply -> Lua table (may have other Redis data types nested)</li>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/ScriptOutputType.java:23: error: bad use of '>'
[ERROR] * <li>Redis status reply -> Lua table with a single <code>ok</code> field containing the status</li>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/ScriptOutputType.java:24: error: bad use of '>'
[ERROR] * <li>Redis error reply -> Lua table with a single <code>err</code> field containing the error</li>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/ScriptOutputType.java:25: error: bad use of '>'
[ERROR] * <li>Redis Nil bulk reply and Nil multi bulk reply -> Lua false boolean type</li>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/ScriptOutputType.java:31: error: bad use of '>'
[ERROR] * <li>Lua number -> Redis integer reply (the number is converted into an integer)</li>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/ScriptOutputType.java:32: error: bad use of '>'
[ERROR] * <li>Lua string -> Redis bulk reply</li>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/ScriptOutputType.java:33: error: bad use of '>'
[ERROR] * <li>Lua table (array) -> Redis multi bulk reply (truncated to the first nil inside the Lua array if any)</li>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/ScriptOutputType.java:34: error: bad use of '>'
[ERROR] * <li>Lua table with a single <code>ok</code> field -> Redis status reply</li>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/ScriptOutputType.java:35: error: bad use of '>'
[ERROR] * <li>Lua table with a single <code>err</code> field -> Redis error reply</li>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/ScriptOutputType.java:36: error: bad use of '>'
[ERROR] * <li>Lua boolean false -> Redis Nil bulk reply.</li>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/protocol/RedisCommand.java:19: error: malformed HTML
[ERROR] * @return CommandOutput<K, V, T>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/protocol/RedisCommand.java:19: error: bad use of '>'
[ERROR] * @return CommandOutput<K, V, T>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/protocol/RedisCommand.java:30: error: malformed HTML
[ERROR] * @return CommandArgs<K, V>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/protocol/RedisCommand.java:30: error: bad use of '>'
[ERROR] * @return CommandArgs<K, V>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/support/RedisClientFactoryBean.java:14: error: self-closing element not allowed
[ERROR] * </code> <br/>
[ERROR] ^
[ERROR] /Users/mark/git/lettuce/src/main/java/com/lambdaworks/redis/support/package-info.java:2: error: reference not found
[ERROR] * Supportive classes such as {@link com.lambdaworks.redis.support.CdiProducer} for CDI support, {@link com.lambdaworks.redis.support.RedisClientFactoryBean} for Spring.
[ERROR] ^
[ERROR] 
[ERROR] Command line was: /Library/Java/JavaVirtualMachines/jdk1.8.0_05.jdk/Contents/Home/bin/javadoc @options @packages

Add tests for untested code

hvals (streaming)
migrate
mget (streaming)
sdiff (streaming)
sinter (streaming)
smembers (streaming)
sort (streaming)
srandmember (streaming)
wait
zrange (streaming)
zrangeWithScores
zrangebyscore
zrangebyscoreWithScores
zrevrange
zrevrangeWithScores
zrevrangebyscore
zrevrangebyscoreWithScores
scan (streaming)
sscan (streaming)
hscan (streaming)
zscan (streaming)

Support NX|XX|CH|INCR options in ZADD

ZADD options (Redis 3.0.2 or greater)
ZADD supports a list of options, specified after the name of the key and before the first score argument. Options are:

  • XX: Only update elements that already exist. Never add elements.
  • NX: Don't update already existing elements. Always add new elements.
  • CH: Modify the return value from the number of new elements added, to the total number of elements changed (CH is an abbreviation of changed). Changed elements are new elements added and elements already existing for which the score was updated. So elements specified in the command line having the same score as they had in the past are not counted. Note: normally the return value of ZADD only counts the number of new elements added.
  • INCR: When this option is specified ZADD acts like ZINCRBY. Only one score-element pair can be specified in this mode.

RedisPubSubConnectionImpl.activated() deadlock

RedisPubSubConnectionImpl.activated() can deadlock if another thread is trying to subscribe or unsubscribe at the same time. RedisPubSubConnectionImpl.subscribe() calls RedisAsyncConnectionImpl.dispatch() which is synchronized. RedisAsyncConnectionImpl.dispatch() calls CommandHandler.write() which tries to get writeLock. CommandHandler.channelActive() holds writeLock and calls RedisPubSubConnectionImpl.activated() which calls RedisPubSubConnectionImpl.subscribe() and tries to get the object lock held by the other thread trying to subscribe.

So basically:

  • CommandHandler.channelActive() holds writeLock and tries to get RedisAsyncConnectionImpl object lock
  • RedisPubSubConnectionImpl.subscribe() holds RedisAsyncConnectionImpl object lock and then tries to get writeLock

Memory leak on connection loss

There seems to be a memory leak on reconnection. This seems to be related to a very specific way of the connection going down because I don't always see it and I only see it together with the state exception.

I'm using Netty 4.0.25 with pooled buffers -Dio.netty.allocator.type=pooled
To get the stack I use -Dio.netty.leakDetectionLevel=advanced
Latest lettuce 3.0.2.

2015-01-30 16:21:17,932 WARN io.netty.channel.DefaultChannelPipeline: An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception.
com.lambdaworks.redis.RedisException: Invalid first byte: 111
        at com.lambdaworks.redis.protocol.RedisStateMachine.readReplyType(RedisStateMachine.java:200)
        at com.lambdaworks.redis.protocol.RedisStateMachine.decode(RedisStateMachine.java:98)
        at com.lambdaworks.redis.protocol.RedisStateMachine.decode(RedisStateMachine.java:61)
        at com.lambdaworks.redis.pubsub.PubSubCommandHandler.decode(PubSubCommandHandler.java:55)
        at com.lambdaworks.redis.protocol.CommandHandler.channelRead(CommandHandler.java:89)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308)
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294)
        at io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelInboundHandlerAdapter.java:86)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308)
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294)
        at io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelInboundHandlerAdapter.java:86)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308)
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294)
        at io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelInboundHandlerAdapter.java:86)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308)
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294)
        at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:846)
        at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:130)
        at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:511)
        at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:468)
        at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:382)
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:354)
        at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116)
        at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137)
        at java.lang.Thread.run(Thread.java:744)
2015-01-30 16:21:17,935 ERROR io.netty.util.ResourceLeakDetector: LEAK: ByteBuf.release() was not called before it's garbage-collected.
Recent access records: 0
Created at:
        io.netty.buffer.PooledByteBufAllocator.newHeapBuffer(PooledByteBufAllocator.java:240)
        io.netty.buffer.AbstractByteBufAllocator.heapBuffer(AbstractByteBufAllocator.java:136)
        io.netty.buffer.AbstractByteBufAllocator.heapBuffer(AbstractByteBufAllocator.java:122)
        com.lambdaworks.redis.protocol.CommandHandler.channelRegistered(CommandHandler.java:59)
        io.netty.channel.AbstractChannelHandlerContext.invokeChannelRegistered(AbstractChannelHandlerContext.java:133)
        io.netty.channel.AbstractChannelHandlerContext.fireChannelRegistered(AbstractChannelHandlerContext.java:119)
        io.netty.channel.ChannelInboundHandlerAdapter.channelRegistered(ChannelInboundHandlerAdapter.java:42)
        io.netty.channel.AbstractChannelHandlerContext.invokeChannelRegistered(AbstractChannelHandlerContext.java:133)
        io.netty.channel.AbstractChannelHandlerContext.fireChannelRegistered(AbstractChannelHandlerContext.java:119)
        io.netty.channel.ChannelInboundHandlerAdapter.channelRegistered(ChannelInboundHandlerAdapter.java:42)
        io.netty.channel.AbstractChannelHandlerContext.invokeChannelRegistered(AbstractChannelHandlerContext.java:133)
        io.netty.channel.AbstractChannelHandlerContext.fireChannelRegistered(AbstractChannelHandlerContext.java:119)
        io.netty.channel.ChannelInboundHandlerAdapter.channelRegistered(ChannelInboundHandlerAdapter.java:42)
        io.netty.channel.AbstractChannelHandlerContext.invokeChannelRegistered(AbstractChannelHandlerContext.java:133)
        io.netty.channel.AbstractChannelHandlerContext.fireChannelRegistered(AbstractChannelHandlerContext.java:119)
        io.netty.channel.ChannelInitializer.channelRegistered(ChannelInitializer.java:71)
        io.netty.channel.AbstractChannelHandlerContext.invokeChannelRegistered(AbstractChannelHandlerContext.java:133)
        io.netty.channel.AbstractChannelHandlerContext.fireChannelRegistered(AbstractChannelHandlerContext.java:119)
        io.netty.channel.DefaultChannelPipeline.fireChannelRegistered(DefaultChannelPipeline.java:733)
        io.netty.channel.AbstractChannel$AbstractUnsafe.register0(AbstractChannel.java:449)
        io.netty.channel.AbstractChannel$AbstractUnsafe.access$100(AbstractChannel.java:377)
        io.netty.channel.AbstractChannel$AbstractUnsafe$1.run(AbstractChannel.java:423)
        io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:380)
        io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:357)
        io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116)
        io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137)
        java.lang.Thread.run(Thread.java:744)

I'll share more information when I find it.

SSL support

Implement SSL support to connect to redis running behind a stunnel

Confusing project and artifact layout

The project consists of 3 maven modules: parent, lettuce and lettuce shaded. All are deployed to mvn central. Searching for lettuce causes to appear all three artifacts.

Expected: Simplify layout to one maven module, add shaded jar as additional artifact with shaded classifier. This removes the separate parent and lettuce-shaded artifacts.

Reactive support

Add another layer between command creation and execution (today a command is created and immediately executed). Reactive commands should be only executed (example from RxJava as soon as call is invoked).

This layer could be located between the command builder and the async connection itself.

Provide access to cluster connection using the advanced cluster API

Provide access to cluster connections with using an advanced cluster API

RedisAdvancedClusterConnection and RedisAdvancedClusterAsyncConnection

Methods on RedisAdvancedClusterConnection:

RedisClusterConnection getConnection(String nodeId)
RedisClusterConnection getConnection(String host, int port)

and Methods on RedisAdvancedClusterAsyncConnection

RedisClusterAsyncConnection getConnection(String nodeId)
RedisClusterAsyncConnection getConnection(String host, int port)

Add checks for arguments

Arguments to redis commands are currently not checked at all. Empty arrays, empty values (SLAVEOF, CLIENT KILL) and null values in arrays can be passed to redis

Enhance stability when reconnecting

Commands can run into a "won't ever come back" state when lettuce tries to reconnect but fails while reconnecting/re-issuing commands.

Desired behavior:
Either re-issue/retry commands on each reconnect or cancel commands after the reconnect failed but not loose commands.

See #31 (comment) for details

@Kitchik: Will continue parts of #31 here. What do you think about the desired behavior?

Additional cluster tests (new suite)

Methods:
clusterAddSlots
clusterDelSlots
clusterSetSlotNode
clusterSetSlotMigrating
clusterSetSlotImporting
clusterFlushslots
clusterFailover
clusteReset

Fix URL parsing

  • Extract URL parser in own class to enable reuse
  • Fix password/sentinel parsing when supplying multiple hosts

Introduce ClientOptions to control specific behavior

Add new ClientOptions type at AbstractRedisClient level (something like AbstractRedisClient#options()) to control:

  • PING before enable the connection (default to false)
  • Auto-Reconnect (default to true)
  • Cancel commands on reconnect failures (default to false)

Commands have Output fields that are nullable and mutable.

Commands can be created with null outputs. I think this could be cleaned up to require non-null Outputs. I think we should also remove the setOutput() call on command as well. Output is used in the RedisStateMachine, and changing output midstream or having a missing one can lead to issues.

From an initial look, only 2 commands have no output. The debugOOM and debugSegfault. Both these kill the server, so there is no output to report. I wasn't able to find any other places where a null output is used.

If this seems OK, I'd like to go down this path.

Also, is this the best way to discuss code proposals like this?

Migrate RedisFuture to CompletionStage

Need input on this topic. The current RedisFuture is a limited facility in terms of async. The underlying ListenableFuture provides a very basic functionality. Chaining and promises are hard to achieve.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.