Commands have Output fields that are nullable and mutable. about lettuce HOT 8 CLOSED

Hi @taer,
this is a good starting point for improvement. I actually like the style of communication, face2face isn't always possible and there is no mailing list. So Github as communication platform is great.

You're right, currently only the debug commands have null outputs for not waiting on any response after firing the command. Guess, this can be improved. ClusterCommand does no magic when it comes to the outputs.

from lettuce.

@mp911de What are your thoughts about adding jsr305?

<dependency>
    <groupId>com.google.code.findbugs</groupId>
    <artifactId>jsr305</artifactId>
    <version>3.0.0</version>
</dependency>

It would be a compile time dep, since I'd annotate methods with the Nonnull annotation, which means non-shaded downstream users would now need this.

Intellij helps analyze nulls if we can implement this.

from lettuce.

I'd rather go for Sonar in the first place. If you like, we could include it as <optional>true</optional>

from lettuce.

I actually just noticed that guava depends on JSR305 already. And I just learned that annotations don't need to be present on the runtime classpath SO link

So an optional one won't affect users. Either way I'm planning to limit the annotation to a few initial methods.

I do like the idea of getting Sonar in place if it's an easy integration

from lettuce.

Go for it. Thanks for caring.

from lettuce.

lettuce is available on Nemo SonarQube http://nemo.sonarqube.org/dashboard/index/biz.paluch.redis:lettuce

from lettuce.

Added jsr305 lib directly in order to omit javadoc failures

from lettuce.

Closed for now, no progress and no demand

from lettuce.