reactkit / swiftstate Goto Github PK

On carhage update, build fail:

carthage version: 0.27.0
xcode version: 9.2

Build Failed
Task failed with exit code 65:
/usr/bin/xcrun xcodebuild -project /Users/vml933/Documents/XCodeProject/PalLinkTest3/Carthage/Checkouts/SwiftState/SwiftState.xcodeproj -scheme SwiftState -configuration Release -derivedDataPath /Users/vml933/Library/Caches/org.carthage.CarthageKit/DerivedData/9.2_9C40b/SwiftState/4.1.0 -sdk iphoneos ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/c6/cmhy9djd5y52994tjg3lsq7c0000gn/T/SwiftState SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO (launched in /Users/vml933/Documents/XCodeProject/PalLinkTest3/Carthage/Checkouts/SwiftState)

This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/c6/cmhy9djd5y52994tjg3lsq7c0000gn/T/carthage-xcodebuild.WbBQpz.log

I've got a question regarding iOS support.

Do you know if SwiftState will work if I include the code in an iOS project that has min deployment target of iOS 7?

Thanks

From the README, I can see that you could construct state entry and exit handlers likes so:

// onExit handler
machine.addHandler(.State0 => .Any) { context in
   print("0 => 1")
}

// onEntry handler
machine.addHandler(.Any => .State0) { context in
   print("0 => 1")
}

But will these handlers be executed in the expected order? I don't really want to have to manage order through the int myself...

I'm using Xcode 9.4, and the v4.1.0 on cocoa pod doesn't compile. Could you fix it?

When I try to build the swift/2.0 branch on XCode7, I'm getting nearly a hundred errors about private class names. I think what's happening is that the private type aliases are being misinterpreted by the swift compiler. It's difficult to test this assumption because I'm getting so many build errors that I can't find the root of the type/alias dependencies. Have you seen anything like this?

Psudocode

machine.addRoute(nil=>nil) // connect all states
machine.addRouteChain(1=>2=>3) { ctx in println("SUCCEEDED") }
machine.addChainErrorHandler(1=>2=>3) { ctx in println("FAILED") }

// current state = 0
machine <- 1 // start chaining
machine <- 3 // chaining failed (println FAILED)
machine <- 2 // already failed (no println)
machine <- 1 // reset & start chaining again
machine <- 2 // succeeding...
machine <- 3 // chaining succeeded (println SUCCEEDED)

This issue is a very non-issue but... shouldn't machine <- event be event -> machine? Code is naturally read from left to right (at least, in english code).

The only reason I can think of to not use -> is because it is a reserved Swift operator. Instead, why not reuse the => operator that is already declared and used in the project to describe state transitions?

Why can't I use the event handler by itself without adding a route? Shouldn't this be a design decision up to the client programmer?

machine.addEventHandler(.GotoPreviousCard, handler: { (event, transition, order, userInfo) -> Void in
  println("FeedView ! GotoPreviousCard")
})

Instead, I have to add a route that messes everything up. Sure, I can make it work but it's pretty pointless when I don't want to change states and instead I have code firing twice I would rather not be.

I would like my view to react to events without making state changes. If anything, I would rather filter events for certain states. For example, if someone "likes" a picture, you might send a Like event during the ShowingPhoto state. Your library could make the validation and what not.

In lieu of this functionality, I made transitions with nil => nil

Building only SwiftState.xcodeproj:

String+SwiftState.swift:10:1: Type 'String' does not conform to protocol 'NilLiteralConvertible'

Building within another project (as pod):

StateTransitionChain.swift:80:41: Cannot invoke '=>' with an argument list of type '(StateTransitionChain<S>, S)'
StateTransitionChain.swift:91:17: Cannot invoke '=>' with an argument list of type '(S, StateTransitionChain<S>)'

Any idea how to solve these build errors?

On carthage build or carthage update , this library currently emits swiftlint config errors.

$ carthage build --platform tvos SwiftState
*** xcodebuild output can be found in /var/folders/tr/3lftss053tqdh731cgt0w1p00000gn/T/carthage-xcodebuild.eJzwNs.log
*** Building scheme "SwiftState" in SwiftState.xcodeproj
2016-03-05 01:41:43.498 xcodebuild[19404:463121] ### Failed to load Addressbook class CNContactNameFormatter
2016-03-05 01:41:48.926 xcodebuild[19466:463272] ### Failed to load Addressbook class CNContactNameFormatter
configuration error: 'variable_name_min_length' is not a valid rule identifier
configuration error: 'variable_name_min_length' is not a valid rule identifier

IMO, a library should not be running SwiftLint in its Build Phase.

Author Note

Currently swift/1.2 branch is running for Xcode6.3-beta (Swift 1.2) support.

Hi,
is it a bug the that last line of the code below returns false or I misunderstood something?

enum State : StateType {
    case A, B, C
    case AnyState

    init(nilLiteral: Void) {
        self = AnyState
    }
}

enum Event: StateEventType {
    case Event1
    case AnyEvent

    init(nilLiteral: Void) {
        self = AnyEvent
    }
}

let machine = StateMachine<State, Event>(state: State.A) { machine in
    machine.addRoute(.A => .B)
    machine.addRoute(.AnyState => .C)
    machine.addRouteEvent(.Event1, transitions: [.AnyState => .A])
}

machine <- .C       // Returns true
machine <-! .Event1 // Returns false ... ?bug?

Since #25 got merged in (thanks!) it'd be nice to have an updated podspec so I can use it in my apps. However, as Swift 2.0 isn't yet in production a branch would suffice so I can do something like:

pod 'SwiftState', :git => '[email protected]:ReactKit/SwiftState.git', :branch => 'swift-2.0'

What do you think, @inamiy?

Hi

I'm having some trouble understanding the 'State & Event enums with associated values' example on the main project page. I'm specifically confused by incomplete enum definitions ...

enum StrState: StateType {
case str(String) ...
}
enum StrEvent: EventType {
case str(String) ...
}

Can someone please respond to this question with a complete example or update the project README ?

Thanks
Dave

Hi. In Xcode version 6.0 release i have many NilLiteralConvertible errors when i want build iOS framework . i am suggest write compatible version of Xcode for your framework :)

http://i.imgur.com/QWbcEa6.png

I modified the basic test case as following and it's failing.
Any ideas to get rid of ?

    func testREADME_tryEvent()
    {
        var handlerCalled = false
        let machine = StateMachine<MyState, MyEvent>(state: .State0) { machine in

            // add 0 => 1 => 2
            machine.addRoutes(event: .Event0, transitions: [
                .State0 => .State1,
                .State1 => .State2,
            ])
            machine.addHandler(.Any => .Any) { _ in
                handlerCalled = true
            }
        }

        // initial
        XCTAssertEqual(machine.state, MyState.State0)

        // tryEvent
        machine <-! .Event0
        XCTAssertEqual(machine.state, MyState.State1)

        // tryEvent
        machine <-! .Event0
        XCTAssertEqual(machine.state, MyState.State2)

        // tryEvent (fails)
        machine <-! .Event0
        XCTAssertEqual(machine.state, MyState.State2, "Event0 doesn't have 2 => Any")

        XCTAssertTrue(handlerCalled) // Failure
    }

Currently, there are 2 types of handlers in StateMachine:

• based on event transition
• based on state transition

Suppose I want to have a handler that does not care how I got to from one state to another - it could be via state -> state transition or based on some event.

It would be nice if there was a way to handle this scenario with a single handler.

There are currently several issues with the build after the latest Xcode update (6D520o). We are looking at these locally and probably have a patch during today.

How are you handling backwards incompatible changes at the moment? After the updates the code will only compile with Swift 1.2 as there is no proper support for conditional compiling in the language.

After fiddling around a bit more, I got the following compiler error:

String+SwiftState.swift:10:1: Type 'String' does not conform to protocol 'NilLiteralConvertible'

Changing to the following solved my error:

extension String: StateType, StateEventType
{
    public init(nilLiteral: ()) {
        self = ""
    }
}

(Xcode 6.1 Beta 3)

CocoaPod doens't compile with Xcode 9.2

Suggestions and comments about the design (not a bug.)

Should state be an attribute of the machine, or the object which is going through the machine?

My use case is a game having many tokens (AKA sprites) each having state and a state machine. I don't mind each token owning an instance of StateMachine, but then I must configure each instance the same way (easy enough to workaround.) But possibly a StateMachine should have a Design which is configured and passed to a StateMachine instance.

In other implementations of FSM 'context' seems to mean: the object which has state, which the state machine sets the state of, and which is passed to all actions (what you call Handlers) for them to act on. Your context is not the same thing? Maybe a solution is a delegate for the state machine?

On another topic, I don't understand the use case for AnyState. Is one use case adding transitions from any state to a reset state, so that you don't have to specify a transition from every state to the reset state? Maybe you could explain in your document. But I should read the code, and for example study what a transition from AnyState to AnyState would mean.

Thanks, SwiftState is rather elegant.

Apologies for creating an issue for this but it's hectic to keep track of your releases. Would be really helpful if you can start versioning it in a better way. Thanks. :)

素晴らしいライブラリです
I tried from 0=>2, I got a error, whats meaning of nil => .State2, I think state2 can accept a transform from any other state, isn't it?

    // tryState 0 => 2 => 1 => 2 => 1 => 0
    machine <- (.State2, "Ping") //Any => 2, msg=Ping fatal error: unexpectedly found nil while unwrapping an Optional value
    machine <- .State1
    machine <- (.State2, "Hello")
    machine <- (.State1, "Bye")
    machine <- .State0  // fail: no 1 => 0

There is a case that the event has associate values which cannot be enumerated all the possible values, so that it is not possible to add all Event Route into State Machine.

In this case, the only way to do it is to use condition.

But unfortunately, condition only includes transition which has no information about the event.

So I suggest to add Event information into transition.

Hi @inamiy, I really like your take on state machines in Swift. I'm now running into an issue in which support for a Hierarchical State Machine would benefit the architectural design. For example, I have three states: A, B and C. A and B are two variants; and it is possible to go from either A or B to C. However, from C it is only possible to go to A. So I would need a handler (A, B) => C and C => A. However SwiftState doesn't allow me to create a handler (A, B) => C, so either I duplicate the handler (no good), or disregard the current state and add nil => C (but that also allows C => C, and a future D => C). As the states grow complexer, this would result in headaches; as adding yet another state would require re-evaluating all the current handlers.

Current transition-chaining doesn't properly work for cases when transition returns back to starting state while chaining, e.g. 0 => 1=> 2 => 0 (back home) => 3.

I cut and pasted the example in the Readme into a project that references SwiftState framework. It would not compile until 1) I switched to building for "iOS Device" and 2) I cut and pasted your example definition of MyEvent into the project.

Now I understand that the caller must define the MyEvent type. But the example could be better.

Also, I don't understand how some of the StateMachine tests work because they also reference MyEvent type. It is not clear to me how the tests found that type. But I know little about XCTest.

Hi

I'm a Swift/Vapor newbie and need some help configuring my Vapor3 app to use SwiftState.

I support I should first ask if this library can even be used with Swift4/Vapor3 - can it ?

If it can - how do I configure my app to use it ?

Thanks
Dave