Comments (6)
Yes, I put no effort into error handling at the moment. I was debating between using catch_panic
(or whatever we call it now) versus trying to stay on stable Rust.
from rayon.
The other place that panic handling is totally wrong is in the parallel iterator stuff, which fails to drop partially completed results (though technically that is not illegal).
from rayon.
So basically the "stable Rust" option I was debating about would be similar to what you suggest -- use poisoning to poison latches as we unwind, and then have the top-level code bring up another thread to replace the one that was torn down (or perhaps just tear them all down and start things back up). But I'd like to have some notion of how targeted the propagation is -- the strategy I just described seems like a panic in one place could randomly affect other workers.
from rayon.
With stealing, a thread's unwind stack could even have a mix of completely distinct jobs, right? I'm not sure there's really any reasonable panic recovery in that case. I'm only hoping for naive panic propagation as a base case -- let the whole process die rather than hang.
from rayon.
There is a pretty sensible solution to this, which is to catch any panics that occurs while executing a job, send the Box back to the caller of join(), and then re-throw the panic there. This effectively makes the result type of a job Result<T, Box<Any>>
. However this requires panic::recover
, which isn't stable, and panic::propagate
, which hasn't landed yet (rust-lang/rust#30557).
from rayon.
@Amanieu yeah, the main question is whether to just make rayon
rely on panic::recover
(and hence require nightly), or not. I think I'd rather just do something sensible, as @cuviper suggests, and adopt recover
later when things have stabilized (or perhaps under #[cfg(nightly)]
switch).
from rayon.
Related Issues (20)
- Synchronous nature of join might result in suboptimal use of compute resources HOT 1
- par_bridge and IndexedParallelIterator HOT 2
- Feature Request: par_enumerate() HOT 3
- rayon_wasm : "Operation not supported on this platform" when setting number of global threads to be used HOT 1
- Extremely deep call stack on MacOS HOT 2
- calling `buffer.par_sort_unstable_by_key` from a task calls the task itself HOT 4
- How to implement ParallelIterator for a custom Range? HOT 13
- How to dynamically change the number of threads during runtime? HOT 2
- `ParallelExtend` for tuples of references HOT 3
- Using async iterator-like SQLX fetch with Rayon HOT 4
- Docs on "spawn" don't say what exactly this function does HOT 1
- Add SIMD SORT as an option HOT 1
- Handle/guard support for current thread pool HOT 1
- Optional parallelization
- Way to have assertion whether something is outside of a rayon task HOT 2
- how drop rayon whren it in a dylib and dylib should be droped? HOT 4
- Error reporting in scoped tasks
- cooperative yield in ThreadPool::install() causes unexpected behavior in nested pools HOT 4
- rayon-core tests fail to build. HOT 6
- Matrix multiplication with Rayon doesn't see perf improvements HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rayon.