Comments (3)
implementing
ParallelExtend
for(&mut FromA, &mut FromB)
would probably conflict with the original implementation for(FromA, FromB)
.
Yes, since &mut _
can be a FromA
itself, and even implemented downstream since that's a fundamental type. It might have been nice to add a blanket impl for &mut T where T: ParallelExtend
, but it's a breaking change to add that now. We possibly could add that for each upstream type we have implemented, like &mut Vec<T>
, and that would make your example work.
(I feel like the blanket impl must have been discussed somewhere, but I can't find it...)
from rayon.
For now, as a workaround, I'm using a simple wrapper like this:
/// Adds method `by_ref()` to `ParallelExtend` that returns a wrapper around `&mut A`
/// that "inherits" the implementation of `ParallelExtend` from `A`.
pub trait ParExtendByRefTrait<T: Send>: ParallelExtend<T> {
fn by_ref(&mut self) -> ExtendRef<'_, T, Self> {
ExtendRef::new(self)
}
}
impl<T: Send, A: ParallelExtend<T> + ?Sized> ParExtendByRefTrait<T> for A {}
/// A wrapper around `&mut A` that "inherits" the implementation of `ParallelExtend` from `A`.
///
/// The type parameter `T` is necessary for Rust to infer which implementation of `by_ref()` to use.
pub struct ExtendRef<'a, T, A: ?Sized> {
inner: &'a mut A,
_phantom: PhantomData<T>,
}
impl<'a, T, A: ?Sized> ExtendRef<'a, T, A> {
pub fn new(inner: &'a mut A) -> Self {
Self {
inner,
_phantom: PhantomData,
}
}
}
impl<'a, T: Send, A: ParallelExtend<T> + ?Sized> ParallelExtend<T> for ExtendRef<'a, T, A> {
fn par_extend<I>(&mut self, par_iter: I)
where
I: IntoParallelIterator<Item = T>,
{
self.inner.par_extend(par_iter)
}
}
That can later used like this:
(vec1.by_ref(), vec2.by_ref()).par_extend(...)
Do you think it could make sense to add a similar by_ref()
method to ParallelExtend
?
from rayon.
I think by_ref()
is too generic to put in our prelude, where everything else has some par
in it, and this should also indicate that it's only for "extend" somehow. That loses some convenience of brevity though, I know.
Maybe the wrapper should just be a tuple struct, ExtendRef<'a, A>(pub &'a mut A)
? Then you can also use it as a direct constructor, like (ExtendRef(&mut vec1), ExtendRef(&mut vec2)).par_extend(...)
.
Or if this is really only useful for tuples, then something like ExtendTuple(&mut vec1, &mut vec2)
.
from rayon.
Related Issues (20)
- Docs on "spawn" don't say what exactly this function does HOT 1
- Add SIMD SORT as an option HOT 1
- Handle/guard support for current thread pool HOT 1
- Optional parallelization
- Way to have assertion whether something is outside of a rayon task HOT 2
- how drop rayon whren it in a dylib and dylib should be droped? HOT 4
- Error reporting in scoped tasks
- cooperative yield in ThreadPool::install() causes unexpected behavior in nested pools HOT 4
- rayon-core tests fail to build. HOT 6
- Matrix multiplication with Rayon doesn't see perf improvements HOT 3
- general purpose WASM support? HOT 1
- `fold` creates identity for each sublist HOT 10
- Support for some sort of collect()/extend() into `LinkedList<Vec<T>>` HOT 1
- A yield_now/yield_local alternative that allows the thread to go to sleep HOT 3
- Rayon slower than single threaded performance when mixing iter and par_iter HOT 9
- Potential to modify ordering for split_count and tour_counter HOT 2
- rayon 1.9.0 doctest failure - stack overflow on aarch64-unknown-linux-gnu HOT 2
- par_bridge_recursion test sometimes hanging indefinitely HOT 3
- rayon works very slow after MacOS Sonoma 14.4 has beed updated HOT 6
- `&mut [T]` should implement `rayon::slice::ParallelSliceMut` HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rayon.