rayon-core tests fail to build. about rayon HOT 6 CLOSED

Ah sorry, I misread your post as the point was not to get the normal build working by avoiding the dev-dependency. Just that crossbeam-channel suffices as a dev-dependency if only the test is modified. Sorry for noise.

from rayon.

mpsc::Sender gained Sync in Rust 1.72. Rayon supports Rust 1.63 for the library itself, but that doesn't include its tests.

I see that even Debian sid only has Rust 1.70, which is now 4 versions old -- I wonder why?

from rayon.

Yeah, we are a bit behind on rustc and cargo in Debian at the moment, I'm not 100% sure, but I think we need to get cargo caught up to a cargo version that corresponds to our current rustc before we push rustc further forward.

Thanks for the feedback, I've just taken another look at the commit in question and done some testing and I have successfully reverted the changes to the test in question, without touching the rest of the code, and the tests now pass. That's good enough for me.

from rayon.

OK -- I guess part of what you would have needed to revert is the crossbeam-channel dependency, but if you're only changing the test, you can move that to a dev-dependency so it's not included in the normal build. Up to you!

from rayon.

but if you're only changing the test, you can move that to a dev-dependency so its not included in the normal build

This might not help as IIRC Debian usually runs the tests as part of the packaging to increase the confidence that e.g. porting a package to a different architecture actually works (in contrast to just compiling).

from rayon.

Surely they would still build dev-dependencies when running tests? That's the point of those...

from rayon.