raptor / clip2tri Goto Github PK

Hi first thank you for sharing your work. I was wondering if you could add header file installation to the CMake script?

Hi,

When I triangulate the attached geometry it works well but when i want to take 2. index triangle's neighbors it gives 2 neighbors (cyan and blue ons) instead of 1 (just cyan). I attached the neighbors's image also.

I take neighbors with the belowing code and if it is not null pointer I draw

p2t::Triangle tri = outputTriangles[2];
p2t::Trianglen1 = tri->GetNeighbor(0);
p2t::Trianglen2 = tri->GetNeighbor(1);
p2t::Trianglen3 = tri->GetNeighbor(2);

Hi,

It seems that c2t::clip2tri::triangulate could be marked as static, because it does not use any class member variables.

In fact, there are no member variables in clip2tri at all, so maybe c2t::clip2tri::triangulate() should be simply become a free function c2t::triangulate(), and all private clip2tri member functions used in implementation hidden inside .cpp file.

It seems that clip2tri class existence produces some misunderstanding, as I've seen new'ing clip2tri object in Qt source code qdeclarativepolygonmapitem.cpp line 288. There is no object needed as clip2tri has no member variables.