`Object.as_json` is too optimistic and causes errors in 3rd party code. about rails HOT 4 OPEN

I've also seen this reported to sidekiq a few times:

• sidekiq/sidekiq#6000
• sidekiq/sidekiq#5920
• sidekiq/sidekiq#5858 (maybe?)

This was eventually fixed by implementing a custom to_hash in sidekiq/sidekiq#6198

from rails.

I guess it was introduced here: e567a5e

cc @jeremy you have worked on that code quite a bit, do you have any opinion?

from rails.

A safer default might be this:

 class Object 
   def as_json(options = nil) # :nodoc: 
     if respond_to?(:to_hash) 
       to_hash.as_json(options) 
     else 
       self.to_s
     end 
   end 
 end 

from rails.

The problem with to_hash is it makes an object implicitly convertible (equivalent to) a Hash. It would have made more sense to use to_h (explicitly convertible).

See https://zverok.space/blog/2016-01-18-implicit-vs-expicit.html for a good summary of the differences.

from rails.