Comments (8)
Maybe, but this is a change in behavior so it needs to be well justified. Can you expand why the current behavior doesn't work for you giving a real example?
from rails.
Makes sense to me. Do you want to open a pull request?
from rails.
This behavior has existed forever, and I believe it's correct.
In the case of a boolean column, as an example, you may want to force the user to choose the truthy value to proceed. A checkbox is probably more appropriate but some people prefer to use select.
What I've done in the past is simply prompt: value.nil?
from rails.
Thank you Justin. In my case either a select or two mutually-exclusive buttons scripted to a hidden radio, checkbox, or field is most appropriate.
If this change won't proceed, I'll take your suggestion and change from
prompt: 'Choose Voice Gender'
to
prompt: ('Choose Voice Gender' if @record.attribute.nil?)
from rails.
Rafael, I'm just finding that the prompt persists even when a boolean option has been selected and saved. I expected the prompt to disappear as it's no longer needed because the user understands the choices. No prompt also makes the size of this select much more compact and neater.
from rails.
Justin, what's your argument for the current behaviour being correct (rather than just traditional). Is there a circumstance where the changed behaviour would be wrong or unexpected (PLOS-wise)?
from rails.
I can't think of a circumstance where it would be wrong, but you do remove the ability to have false
with prompt. Maybe that's okay? I'm just skeptical why the current behavior has existed for 12 years.
from rails.
I was curious and looked at other frameworks and libraries. For the ones that actually have a prompt option, they allow/require full control over whether it's utilized or not (equivalent in Rails would be removing value.blank?
).
from rails.
Related Issues (20)
- database.yml gets evaluated before initializers run since Rails 7.1.0 HOT 7
- `csp_meta_tag` helper generates a meta tag w/o out making use of the nonce hiding which could lead to nonce value exfiltration of nonce data HOT 2
- [ActiveRecord] PostgreSQL Adapter skips update on CIDR column when only netmask is changed
- ActionView's typecast method raises an TypeError on Resolver-object instance, but it shouldn't HOT 1
- Is there already a built-in method from the Rails API for finding all NESTED belongs_to associations? HOT 1
- Update getting started guide to include ImportMap and Turbo initalization.
- [7.1] MIME parsing raising errors on valid parameters HOT 1
- Rails Query Issue with Null Value Comparison HOT 1
- [Bug][ActionCable/Zeitwerk] Code reloading doesn't close connections
- find_by called with no paramaters HOT 3
- collection_check_boxes hidden field ignores :form option
- Action Cable as Stand Alone server leads to Devise::MissingWarden: error HOT 2
- Postgres prepared statements and array queries with certain syntax result in `PG::InvalidTextRepresentation` HOT 5
- Rubocop binstubs issue causes failures on Windows
- [ActiveRecord] Enum defined methods does not follow naming convention HOT 5
- `ActiveRecord::ConnectionAdapters::SQLite3Adapter#initialize` does not correctly create missing parent directories HOT 6
- `Object.as_json` is too optimistic and causes errors in 3rd party code. HOT 4
- `ActiveSupport::Inflector` isolation/conflicts: recommended approach HOT 4
- ActiveRecord/Postgresql composite primary keys breaks count query on includes+references HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rails.