Git Product home page Git Product logo

Comments (8)

rafaelfranca avatar rafaelfranca commented on May 25, 2024 1

Maybe, but this is a change in behavior so it needs to be well justified. Can you expand why the current behavior doesn't work for you giving a real example?

from rails.

rafaelfranca avatar rafaelfranca commented on May 25, 2024 1

Makes sense to me. Do you want to open a pull request?

from rails.

justinko avatar justinko commented on May 25, 2024 1

This behavior has existed forever, and I believe it's correct.

In the case of a boolean column, as an example, you may want to force the user to choose the truthy value to proceed. A checkbox is probably more appropriate but some people prefer to use select.

What I've done in the past is simply prompt: value.nil?

from rails.

mrj avatar mrj commented on May 25, 2024 1

Thank you Justin. In my case either a select or two mutually-exclusive buttons scripted to a hidden radio, checkbox, or field is most appropriate.

If this change won't proceed, I'll take your suggestion and change from

prompt: 'Choose Voice Gender' 

to

prompt: ('Choose Voice Gender' if @record.attribute.nil?)

from rails.

mrj avatar mrj commented on May 25, 2024

Rafael, I'm just finding that the prompt persists even when a boolean option has been selected and saved. I expected the prompt to disappear as it's no longer needed because the user understands the choices. No prompt also makes the size of this select much more compact and neater.

from rails.

mrj avatar mrj commented on May 25, 2024

Justin, what's your argument for the current behaviour being correct (rather than just traditional). Is there a circumstance where the changed behaviour would be wrong or unexpected (PLOS-wise)?

from rails.

justinko avatar justinko commented on May 25, 2024

I can't think of a circumstance where it would be wrong, but you do remove the ability to have false with prompt. Maybe that's okay? I'm just skeptical why the current behavior has existed for 12 years.

from rails.

justinko avatar justinko commented on May 25, 2024

I was curious and looked at other frameworks and libraries. For the ones that actually have a prompt option, they allow/require full control over whether it's utilized or not (equivalent in Rails would be removing value.blank?).

from rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.