Postgres prepared statements and array queries with certain syntax result in `PG::InvalidTextRepresentation` about rails HOT 5 CLOSED

This was changed in #51139 (cc @byroot).

In the meantime, this works:

    assert_equal([p], Post.where("ratings @> ?", '{4}'))

from rails.

Frankly, I feel like this is a [largely accidental] feature -- interpolating ? values into a string literal seems scary and dangerous and deeply inadvisable.

I also don't think there's much we can do about it: it's not reasonable for us to guarantee the exact characters that will be interpolated... at that point you might as well use #{}.

from rails.

I won't be heartbroken if this doesn't work anymore. Rails only documents the ARRAY[?]::type[] notation at https://guides.rubyonrails.org/active_record_postgresql.html#array and its trivial to change the few occurrences to that.

A basic GitHub code search yields some results though, see here, so deprecation/better error message? I don't know if this warants that.

from rails.

Yeah, I think we can close this. I don't think a specific deprecation would be helpful or needed, this seems extremely niche.

from rails.

Just for posterity, a better replacement for my case above would be where("? = ANY(ratings)", 4) since only one element is being checked for. The array notation makes sense when checking again multiple elements.

from rails.