Git Product home page Git Product logo

Comments (3)

marten-seemann avatar marten-seemann commented on September 23, 2024 1

AFAIK disabling this is recommended: https://blog.trailofbits.com/2019/03/25/what-application-developers-need-to-know-about-tls-early-data-0rtt/

It most definitely is not. 0-RTT is only used for GET requests, and only if the request method is set to http3.MethodGet0RTT.

from quic-go.

marten-seemann avatar marten-seemann commented on September 23, 2024

This makes sense. We install the server's updated transport parameters when we process the Encrypted Extensions during the handshake. The race condition occurs because creating a new streams needs to look up the peer's flow control limits.

In the 1-RTT handshake this is not a problem, since streams can only be opened after completion of the handshake. When using 0-RTT, streams can be opened concurrently, leading to the race you're seeing here.

from quic-go.

oliverpool avatar oliverpool commented on September 23, 2024

As a workaround, Allow0RTT can be disabled:

Edit: the data-race still happens with 0-RTT disabled. The stacktrace is like the one in #4228. Sorry for the unrelated noise.

from quic-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.