Comments (5)
We might not need #4519 (or at the very least reduce the number of flake attempts) once we have this.
from quic-go.
Loss of a single probe packet will make the MTU discoverer believe that it has reached the path's MTU. This is unnecessarily aggressive.
I think this even violates RFC 8899:
The PL is REQUIRED to be robust in the case where probe packets are lost due to other reasons (including link transmission error, congestion).
The RFC seems to recommend up to 3 probes before giving up: https://datatracker.ietf.org/doc/html/rfc8899#name-constants
This paper by the RFC 8899 authors looks quite interesting:
https://www.hb.fh-muenster.de/opus4/frontdoor/deliver/index/docId/14965/file/dplpmtudQuicPaper.pdf
from quic-go.
Thank you @bt90! I wasn't aware of this paper, and I'm not sure I understand how they deal with packet loss: Every time a probe packet is lost, you have the choice to either re-probe the same size, or reduce the probe size by a little and probe a slightly smaller size.
I don't think it hugely matters, PMTUD is cheap, so going for something simple might be the better answer than hunting for the most optimal solution.
from quic-go.
Every time a probe packet is lost, you have the choice to either re-probe the same size, or reduce the probe size by a little and probe a slightly smaller size.
That one is covered by the RFC:
https://datatracker.ietf.org/doc/html/rfc8899#name-probing-for-a-larger-plpmtu
tl;dr: the search only stops after multiple probes failed
from quic-go.
@bt90 I implemented an algorithm that should be more resilient to packet loss in #4545. Would you mind taking a look?
from quic-go.
Related Issues (20)
- quic-go.newStream high memory usage HOT 7
- http3: response body not implemented http3.HTTPStreamer HOT 9
- Datagram no recent network activity error HOT 3
- bug: unable to connect to quiche servers HOT 5
- In some cases I have turned off Stream on the server side, but OpenStreamSync on the client side is still blocked HOT 6
- pass a context to ConnContext context, cancel it when the connection is closed
- Slow transfer speed HOT 10
- Wrong ACK numbers? HOT 1
- gquic branch usage HOT 1
- Go 1.21
- server incorrectly allows 0-RTT with reduced limits when using tls.Config.GetConfigForClient
- introduce a minimum step size of Path MTU Discovery
- Allow applications to specify MaxPacketBufferSize HOT 8
- add more metrics
- Significant Packet Delay with quic-go on iOS Due to Goroutine Handling HOT 3
- http3: RoundTripper is caching dialErr since v0.43.0 HOT 1
- Cancel retransmission of data when sending with quic Client HOT 1
- implement BBRv3 HOT 3
- use `net.ErrClosed` for the server and the connection HOT 3
- [Suggestion] multi-staging build in quic-go example Dockerfile HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quic-go.