Git Product home page Git Product logo

Comments (9)

marten-seemann avatar marten-seemann commented on June 23, 2024 1

You'll need to take the path via the SingleDestinationRoundTripper then.

from quic-go.

marten-seemann avatar marten-seemann commented on June 23, 2024 1

Please take a look at the WebTransport dialer: https://github.com/quic-go/webtransport-go/blob/master/client.go

I believe it does exactly what you need.

from quic-go.

marten-seemann avatar marten-seemann commented on June 23, 2024

This was called out as a breaking change in the release notes of v0.43. It is now the http.ResponseWriter that implements the interface.

from quic-go.

phuslu avatar phuslu commented on June 23, 2024

Thanks. In my understanding the http.ResponseWriter only can be used in server side. (Please correct me if I'm wrong)

How to unwrap the stream in client side (*http.Response), my existing code is here

from quic-go.

phuslu avatar phuslu commented on June 23, 2024

Last question, shall/do we have a RoundTripOpt to let this underlying stream stay opening?

https://github.com/quic-go/quic-go/blob/v0.44.0/http3/client.go#L299

from quic-go.

phuslu avatar phuslu commented on June 23, 2024

Finally I gave up this approach, I turn to another way with more compatibility and but lower performance in phuslu/liner@1054f3b

If the stream unwarp of *http.Response in quic-go/http3 comes back in future, please let me know. thanks again.

from quic-go.

phuslu avatar phuslu commented on June 23, 2024

Understood, but currently I'd like keep unique/same logic in server side, like https://github.com/phuslu/liner/blob/master/handler_http_forward.go#L278-L298

from quic-go.

marten-seemann avatar marten-seemann commented on June 23, 2024

There’s no change to the server side. This is purely a client side API change.

from quic-go.

phuslu avatar phuslu commented on June 23, 2024

thanks for your patience, finally I have a modified webtransport-go dialer of https://github.com/phuslu/liner/blob/master/dialer_http3.go thanks again!

from quic-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.