Git Product home page Git Product logo

Comments (7)

konstin avatar konstin commented on June 5, 2024

In theory, rust should only link symbols old enough for manylinux compliance. iirc in there's a bug where rust currently links two more recent symbols, breaking manylinux and even manylinux2010 compliance. Unfortunately I currently can't check because the latest nightly crashes in the manylinux container with some error about the gcc version: rust-lang/rust#56849. So this means you currently need the docker container for full compliance; I had started creating a Dockerfile with all tools installed, but not finished it.

from maturin.

rth avatar rth commented on June 5, 2024

Thanks for the explanations @konstin !

from maturin.

konstin avatar konstin commented on June 5, 2024

I've filed rust-lang/rust#57497 for glibc part, but I'm not sure if that will get fixed. I've also created a docker container based on the manylinux container with all required tools installed and published it under konstin2/pyo3-pack, but I think I need to pin the nightly, I don't know yet if tags get published and the upload feature can't be used (reqwest got rustls support just 3 days ago, maybe that could help, but that needs to be manually tested for regressions).

from maturin.

konstin avatar konstin commented on June 5, 2024

I've improved the Dockerfile a good bit and updated with proper information.

@rth Could have a look at the readme please and tell me if that fixes the issue?

from maturin.

rth avatar rth commented on June 5, 2024

yes 5375271 fixes this issue, thanks @konstin !

from maturin.

ijl avatar ijl commented on June 5, 2024

@konstin should konstin2/pyo3-pack be public? I need to login to access it.

from maturin.

konstin avatar konstin commented on June 5, 2024

Thanks for the note @ijl, I've changed it to the correct link.

from maturin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.