maturin fails if `sys.stdout` is an `io.StringIO` object about maturin HOT 5 CLOSED

Actually in the case I am not patching the sys.stdout, the type of sys.stdout differs because the standard output is redirected.

How exactly was the stdout redirected? I'm not sure why redirect stdout (like using > /dev/null in shell) would change it to io.StringIO.

Ok, found it in your code

@contextlib.contextmanager
def hook_call():
    captured_out = StringIO()
    with contextlib.redirect_stdout(captured_out):
        yield
    for line in captured_out.getvalue().splitlines():
        print_err('HOOK STDOUT:', line)

so you are effectively patching sys.stdout with io.StringIO().

I'm going to close this as wontfix.

from maturin.

What's your proposed solution here? From reading the issues you linked, I'm leaning towards that if you are patching sys.stdout it's your responsibility to use io.TextIOWrapper.

@konstin What do you think?

from maturin.

Normally, i'd say maturin should support mocked sys.stdout, but for the case of PEP 517 specifically, the spec says:

Frontends should call each hook in a fresh subprocess, so that backends are free to change process global state (such as environment variables or the working directory). A Python library will be provided which frontends can use to easily call hooks this way.

I would argue that a linux distribution should follow the PEP 517 recommendation. You can use the build library which provides an easy integration.

from maturin.

What's your proposed solution here? From reading the issues you linked, I'm leaning towards that if you are patching sys.stdout it's your responsibility to use io.TextIOWrapper.

@konstin What do you think?

Sorry I am not that familiar with python so I am searching for solution as well. If I find an elegant solution, I will comment.

Actually in the case I am not patching the sys.stdout, the type of sys.stdout differs because the standard output is redirected.

from maturin.

Actually in the case I am not patching the sys.stdout, the type of sys.stdout differs because the standard output is redirected.

How exactly was the stdout redirected? I'm not sure why redirect stdout (like using > /dev/null in shell) would change it to io.StringIO.

from maturin.