Git Product home page Git Product logo

Comments (9)

alex avatar alex commented on September 21, 2024 1

To be able to take advantage of improvements (e.g. performance) on newer versions, while maintaining compatibility.

The specific improvement that motivated us to do this was https://github.com/PyO3/pyo3/blob/main/src/impl_/pymodule.rs#L83-L119

from maturin.

messense avatar messense commented on September 21, 2024 1

Do you think support for something like "auto" abi3, where it used the current Python's version is possible?

I think we can support this, we can change maturin to use the current Python's version when abi3 feature is enabled without an explicit abi3-pyXY feature, and print a message about this behavior of course.

from maturin.

konstin avatar konstin commented on September 21, 2024

What's the motivation for targeting multiple abi3 versions instead of the lowest supported?

from maturin.

messense avatar messense commented on September 21, 2024

I think it's already possible by using MATURIN_PEP517_ARGS env var or --config-settings, for example

pip wheel --config-settings=build-args='--features abi3-py312'

from maturin.

alex avatar alex commented on September 21, 2024

Ah, that will be respected? Let me test it. Thanks!

from maturin.

alex avatar alex commented on September 21, 2024

Hmm, it fails when building an sdist with:

Caused by: You have selected the abi3 feature but not a minimum version (e.g. the abi3-py36 feature). maturin needs a minimum version feature to build abi3 wheels.

from maturin.

alex avatar alex commented on September 21, 2024

I guess it fails everywhere except the places I passed that argument.

from maturin.

alex avatar alex commented on September 21, 2024

To follow up on this, it's missing a key element that setuptools-rust "auto" provides: using abi3 with the current python if nothing is explicitly provided.

from maturin.

alex avatar alex commented on September 21, 2024

Do you think support for something like "auto" abi3, where it used the current Python's version is possible?

from maturin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.