Git Product home page Git Product logo

Comments (3)

messense avatar messense commented on June 22, 2024 1

Is there any scenario where -S would break some edge use cases?

For https://github.com/PyO3/maturin/blob/main/src/python_interpreter/get_interpreter_metadata.py, I don't think anything would break.

from maturin.

messense avatar messense commented on June 22, 2024

A potential fix is to use the -S CLI flag to python to avoid loading site customizations when running these configuration scripts (the resulting output is identical in my testing).

Sounds good, pull requests are welcome.

Adding that flag to check_executable the build gets further and fails on failed to run custom build command for pyo3-build-config v0.19.2 so pyo3 may need to implement this same fix

Make sense, cc @davidhewitt

from maturin.

davidhewitt avatar davidhewitt commented on June 22, 2024

Is there any scenario where -S would break some edge use cases? A slightly more cautious option is to fail, retry with -S, and if that succeeds, fail with an error message and a hint to run with PYTHONNOUSERSITE=1 env var set. That way the user knowingly disables their site if it's a problem.

(We could also set the env var rather than -S when retrying.)

PR is very welcome.

from maturin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.