sdist is missing tests about maturin HOT 8 CLOSED

The sdist url is directly referenced from PyPI so it could be easily found without manual intervention.

fwiw the github api provides a way to get the tarball of the latest release, and we also link the github url from pypi, so you might be able to get your automation this way: https://docs.github.com/de/rest/releases/releases?apiVersion=2022-11-28#get-the-latest-release

from maturin.

And why not using the github release .tar.gz source, for example https://github.com/PyO3/maturin/archive/refs/tags/v1.1.0.tar.gz? It contains all of the code.

Git doesn't guarantee that the generated archives will be stable. There have already been cases in the past when changes in git or one of its dependencies suddenly caused all archives to change and broke all downstream consumers via checksum mismatches.

from maturin.

tests are written in Rust, what downstream would run Rust tests for a Python sdist?

from maturin.

I'm packaging maturin for OpenIndiana and testing is something that could find incompatibilities either in the operating system or in the Python project. This is especially valuable for not so common platforms like OpenIndiana.

from maturin.

Thanks, I understand the benefits. I'm just not sure whether adding tests to sdist would work since it needs to be run by cargo test.

And why not using the github release .tar.gz source, for example https://github.com/PyO3/maturin/archive/refs/tags/v1.1.0.tar.gz? It contains all of the code.

from maturin.

Github tarball is possible too, but it creates a bit more maintenance work because there is no simple way how to find the tarball automatically. The sdist url is directly referenced from PyPI so it could be easily found without manual intervention.

BTW, if tests should be run using cargo test why there is noxfile.py file?

from maturin.

noxfile.py is only for automating some Emscripten stuff.

from maturin.

I'm going to close this because we don't have any tests written in Python to distribute, and I'm removing noxfile.py from sdist in #1679.

from maturin.