Git Product home page Git Product logo

Comments (5)

privefl avatar privefl commented on June 18, 2024
  • big_spLinReg() may perform some scaling internally, but it will always return effect sizes corresponding to the input data (i.e. before any internal scaling).
  • I guess the way you compute r2 is wrong since it should be invariant of any scale of either pred and true; just use cor()^2 or pcor()^2 (possibly also keeping the sign).

from bigstatsr.

annilk avatar annilk commented on June 18, 2024

Thank you for the very fast response!

Do you mean that if I want my predictors to be on the same scale in test data than in training data, I should scale them externally? How to do that then in case of genotype data?

Thanks for pointing out the mistake in R2 calculation. However, I'm a little confused because I have been taught that when calculating R2, MSE should be used to ensure that predictions are on the correct scale of the outcome variable, and that using cor()^2 can be misleadingly optimistic. Can you explain why I should ignore the linear scale difference between the prediction and the outcome?

from bigstatsr.

privefl avatar privefl commented on June 18, 2024

I am not saying that you should not care about the prediction not being calibrated; I'm just saying that R2 does not measure calibration.

If you use the training data as is, which is then scale internally in big_spLinReg() but unscale to report the effects, then you should not have to scale the test data.

from bigstatsr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.