Comments (4)
Rangi42
commented on June 11, 2024
To do: test what happens when a givepoke gift mon goes to the current PC box with a full party; and what happens when both the party and current PC box are full.
A valid fix may just be "always check VAR_PARTYCOUNT for PARTY_LENGTH before doing givepoke", if handling the Gen 2 PC would otherwise be too complicated.
from pokecrystal.
aaaaaa123456789
commented on June 11, 2024
As far as I can tell, generating a Pokémon straight into the PC would give it zero DVs, since GivePoke calls LoadEnemyMon in that case out of battle, which I assume will have a value of zero in wBattleMode. I haven't tested this, though. I'm not sure if it can accidentally attempt to load a trainer mon instead, though.
from pokecrystal.
Idain
commented on June 11, 2024
A valid fix may just be "always check
VAR_PARTYCOUNTforPARTY_LENGTHbefore doinggivepoke", if handling the Gen 2 PC would otherwise be too complicated.
Which is funny, since that's what the vanilla game usually does.
from pokecrystal.
vulcandth
commented on June 11, 2024
Just now read this; yeah, I think i've encountered this before myself.
from pokecrystal.
Related Issues (20)
- Bad comment in RTC-checking code HOT 3
- Verify that there aren't too many OAM constants
- Bug: After a trainer uses its 1st item, it'll start reading past the item list for items to use HOT 4
- Add dupeframes.py tool to find duplicate Pokemon frames
- Bug: Mind Reader and Lock-On don't prevent the AI from failing status moves that have a 25% chance to fail (when used by AI) HOT 1
- Make types easier to edit with rept HOT 4
- [Bug] ["no-maps" Branch] Whiting out while set to the default spawnpoint causes a crash HOT 1
- Inaccurate function names HOT 5
- Use grayscale PNGs plus normal.pal files for Pokemon and trainer sprites HOT 3
- Refactor tools/dupeframes.py HOT 2
- Incorrect Mystery Gift decorations HOT 5
- Support `-` for stdin and stdout in bpp2png and other tools HOT 1
- The `list_start` macro should take a max string length for `li` to check HOT 3
- Move charmap.asm to constants/
- Lowercase "pret" in Discord link HOT 2
- Sweet scent can still be used after being overwritten by a newly learned move HOT 2
- Bug: CheckObjectCoveredByTextbox doesn't account for the background scroll (SCX/SCY)
- Bug: Map cursor on New Bark Town when on S.S. Aqua HOT 1
- Use named constants for warp IDs? HOT 16
- Bug: Closing textboxes overlapping tiles $80+ glitches out for a frame HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pokecrystal.