Comments (4)
I can only imagine this adding confusion for little gain.
It does look neater, however.
from pokecrystal.
My rationale is repeatedly seeing people say "I added a new type and it doesn't work" or "I made Dark/Fairy/etc physical and it doesn't work". The constants look like this:
const_def
DEF PHYSICAL EQU const_value
const NORMAL
...
const STEEL
DEF UNUSED_TYPES EQU const_value
const_next 19
const CURSE_TYPE
DEF UNUSED_TYPES_END EQU const_value
DEF SPECIAL EQU const_value
const FIRE
...
const DARK
DEF TYPES_END EQU const_value
I expect the rept
to be easier to work with than the current bunch of dw Normal
s that need manually curating when the physical types change. It would only fail if you add more than 19 physical types, which I've never heard of.
from pokecrystal.
You're right, the behavior of both tables should match. I don't mind unrolling the const table (instead of using const_next) either.
from pokecrystal.
Hmm. I'd prefer not to unroll the const table, because using const_next
shows how the special types start at 20. Also even if the const_next 19
were replaced with const_skip
, it would be idiomatic to do one const_skip N
, not on const_skip
line for each dw Normal
line.
from pokecrystal.
Related Issues (20)
- Lowercase "pret" in Discord link HOT 2
- Sweet scent can still be used after being overwritten by a newly learned move HOT 2
- Bug: CheckObjectCoveredByTextbox doesn't account for the background scroll (SCX/SCY)
- Bug: Map cursor on New Bark Town when on S.S. Aqua HOT 1
- Use named constants for warp IDs? HOT 16
- Bug: Closing textboxes overlapping tiles $80+ glitches out for a frame HOT 3
- TextCommand_WAIT_BUTTON naming HOT 2
- Bug: Mania uses wrong dialogue for trying to return Shuckie with no other Pokémon
- .editorconfig support HOT 3
- Install instructions are inscrutable HOT 4
- Maybe add comments explaining that `stat_multipliers.asm` and `stat_multipliers_2.asm` are stored in different banks HOT 2
- "Make evening the fourth time of day" is not compatible with RGDBS 0.7.0 HOT 1
- Comment `; unreferenced` not `; unused` on various unreferenced `db`s/`dw`s
- Document the hard-coded logic of Headbutt
- Document more sprite oversights
- Document the Kanto Trainer battle theme bug HOT 1
- `AI_Smart_Curse.approve`, `.greatly_encourage`, and `.encourage` look like wrong labels HOT 1
- Use explicit RGBGFX palette input for Pokemon and trainer sprites?
- Sort Pokemon and trainer sprite palettes from lightest to darkest, with Makefile-specified exceptions HOT 4
- Incorrect labelling on Sweet Scent Bug Contest functionality
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pokecrystal.