Comments (5)
mid-kid
commented on June 11, 2024
That PR solves this entire issue?
Yeah, that still has to be merged. Some accepted PRs linger for a while before someone bothers porting it to the other decomp as well. You can help out by submitting an equivalent PR to crystal.
I guess I'll do it for now.
from pokecrystal.
SnorlaxMonster
commented on June 11, 2024
Almost the entire issue. The one thing it doesn't fix is the fallback item, which should be the Red Carpet instead of the Polkadot Bed, according to bayleaf's research.
I assume the fallback item DECO_POLKADOT_BED should just be changed to DECOFLAG_RED_CARPET, but I have not tested it.
from pokecrystal.
mid-kid
commented on June 11, 2024
Merged as of b0ddb07
Did that fix it?
from pokecrystal.
SnorlaxMonster
commented on June 11, 2024
Merged as of b0ddb07 Did that fix it?
Not quite, it didn't fix the default decoration. I've just submitted pull request #1084 that fixes that as well. Merging that will fully resolve this issue.
from pokecrystal.
vulcandth
commented on June 11, 2024
resolved in 75f0ad3
from pokecrystal.
Related Issues (20)
- Add dupeframes.py tool to find duplicate Pokemon frames
- Bug: Mind Reader and Lock-On don't prevent the AI from failing status moves that have a 25% chance to fail (when used by AI) HOT 1
- Make types easier to edit with rept HOT 4
- [Bug] ["no-maps" Branch] Whiting out while set to the default spawnpoint causes a crash HOT 1
- Inaccurate function names HOT 5
- Use grayscale PNGs plus normal.pal files for Pokemon and trainer sprites HOT 3
- Refactor tools/dupeframes.py HOT 2
- Support `-` for stdin and stdout in bpp2png and other tools HOT 1
- The `list_start` macro should take a max string length for `li` to check HOT 3
- Move charmap.asm to constants/
- Lowercase "pret" in Discord link HOT 2
- Sweet scent can still be used after being overwritten by a newly learned move HOT 2
- Bug: CheckObjectCoveredByTextbox doesn't account for the background scroll (SCX/SCY)
- Bug: Map cursor on New Bark Town when on S.S. Aqua HOT 1
- Use named constants for warp IDs? HOT 16
- Bug: Closing textboxes overlapping tiles $80+ glitches out for a frame HOT 3
- TextCommand_WAIT_BUTTON naming HOT 2
- Bug: Mania uses wrong dialogue for trying to return Shuckie with no other Pokémon
- .editorconfig support HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pokecrystal.